Commit Graph
8489 Commits
Author SHA1 Message Date
Dan Abramov 77add81e28 Merge branch 'master' into rollup 2017-03-29 13:59:44 +01:00
Dominic Gannaway 09f0a5ded9 Merge pull request #9276 from trueadm/getDeclarationErrorAddendum_DEV
[Fiber] Adds DEV condition around getDeclarationErrorAddendum
2017-03-29 13:55:04 +01:00
Dominic Gannaway 660306982c added DEV condition around getDeclarationErrorAddendum contents 2017-03-29 13:49:30 +01:00
Dominic Gannaway 28e9cb240f fixed fixtures and updated cjs/umd paths 2017-03-29 13:00:00 +01:00
Dominic Gannaway 607b021d49 added external babel helpers plugin 2017-03-29 11:42:07 +01:00
Sasha Aickin aaabd655a6 Added jest-cli to the package.json for the Fiber record-tests script. (#9270) 2017-03-28 22:55:22 +01:00
Brian Vaughn a749f4fb63 Adding fix to EventPropagators that was accidentally omitted from PR #9219 (#9274) 2017-03-28 11:24:13 -07:00
Brian Vaughn fca5d3ffc5 Added missing @flow annotation to ReactNativeFeatureFlags file (#9267) 2017-03-27 14:59:37 -07:00
Andrew Clark 090efbdb17 Merge branch 'giamir-add_toggle_to_fiber_triangle_demo' 2017-03-27 12:48:39 -07:00
Andrew Clark f6a64cad5d Use radio buttons for toggle 2017-03-27 12:48:05 -07:00
Andrew Clark ef9dac518f Merge branch 'add_toggle_to_fiber_triangle_demo' of https://github.com/giamir/react into giamir-add_toggle_to_fiber_triangle_demo 2017-03-27 11:46:59 -07:00
Dominic Gannaway f79b32a6af keeps comments in prod 2017-03-27 19:21:07 +01:00
Dan Abramov 02a0b8c7bc Use right haste names 2017-03-27 18:35:17 +01:00
Nathan Hunzaker 29d9710892 Fix Chrome number input backspace and invalid input issue (#7359)
* Only re-assign defaultValue if it is different

* Do not set value if it is the same

* Properly cover defaultValue

* Use coercion to be smart about value assignment

* Add explanation of loose type checks in value assignment.

* Add test coverage for setAttribute update.

* Only apply loose value check to text inputs

* Fix case where empty switches to zero

* Handle zero case in controlled input

* Correct mistake with default value assignment after rebase

* Do not assign bad input to number input

* Only trigger number input value attribute updates on blur

* Remove reference to LinkedValueUtils

* Record new fiber tests

* Add tests for blurred number input behavior

* Replace onBlur wrapper with rule in ChangeEventPlugin

* Sift down to only number inputs

* Re-record fiber tests

* Add test case for updating attribute on uncontrolled inputs. Make related correction

* Handle uncontrolled inputs, integrate fiber

* Reorder boolean to mitigate DOM checks

* Only assign value if it is different

* Add number input browser test fixtures

During the course of the number input fix, we uncovered many edge
cases. This commit adds browser test fixtures for each of those instances.

* Address edge case preventing number precision lower than 1 place

0.0 coerces to 0, however they are not the same value when doing
string comparision. This prevented controlled number inputs from
inputing the characters `0.00`.

Also adds test cases.

* Accommodate lack of IE9 number input support

IE9 does not support number inputs. Number inputs in IE9 fallback to
traditional text inputs. This means that accessing `input.value` will
report the raw text, rather than parsing a numeric value.

This commit makes the ReactDOMInput wrapper check to see if the `type`
prop has been configured to `"number"`. In those cases, it will
perform a comparison based upon `parseFloat` instead of the raw input
value.

* Remove footnotes about IE exponent issues

With the recent IE9 fix, IE properly inserts `e` when it produces an
invalid number.

* Address exception in IE9/10 ChangeEventPlugin blur event

On blur, inputs have their values assigned. This is so that number
inputs do not conduct unexpected behavior in
Chrome/Safari. Unfortunately, there are cases where the target
instance might be undefined in IE9/10, raising an exception.

* Migrate over ReactDOMInput.js number input fixes to Fiber

Also re-record tests

* Update number fixtures to use latest components

* Add number input test case for dashes and negative numbers

* Replace trailing dash test case with replace with dash

Also run prettier
2017-03-27 11:39:18 -05:00
Dominic Gannaway ceeebd8e56 added __DEV__ flag behind a footer/header 2017-03-27 16:53:39 +01:00
Dominic Gannaway 65aae08bd1 added a __DEV__ wrapping code to FB_DEV 2017-03-27 16:38:13 +01:00
Dominic Gannaway 88293c7180 added shims for DEV only code so it does not get included in prod bundles 2017-03-27 16:02:42 +01:00
Dominic Gannaway b025c43487 Added init() dev block to ReactTestUtils 2017-03-27 15:46:18 +01:00
Dominic Gannaway 4e81eac859 Merge branch 'rollup' of github.com:trueadm/react into rollup 2017-03-27 15:26:00 +01:00
Dominic Gannaway c95ee10aee should no longer mangle FB_PROD output 2017-03-27 15:25:50 +01:00
Dan Abramov 5f994ee71b Remove deps on specific builds from shims 2017-03-27 15:23:30 +01:00
Dominic Gannaway 9e5271ab45 splits FB into FB_DEV and FB_PROD 2017-03-27 15:07:47 +01:00
Dominic Gannaway d526452b0b fixed merge conflicts with upstream master 2017-03-27 12:32:58 +01:00
Dominic Gannaway 7afb09ea00 updated error codes 2017-03-27 11:52:09 +01:00
Sasha Aickin c51411c812 Adding new SSR tests for context, refs, and reviving markup. (#9257) 2017-03-26 13:32:23 -07:00
Giamir Buoncristiani b62f851e64 Add a button to switch from Fiber with time-slicing to Fiber without it 2017-03-26 17:24:26 +01:00
najisawas c47f334ac9 Fixed typo on implementation notes page (#9258)
Added paren to "mountComponent()" for consistency
2017-03-25 20:57:28 -05:00
Brian Vaughn cb585229bc Ran yarn and fixed line-length lint issue 2017-03-24 19:59:05 -07:00
Dan Abramov 9347ca0115 Work around Jest issue with CurrentOwner shared state in www 2017-03-25 00:55:10 +00:00
Dan Abramov 56c42b53fd Revert "😭😭😭"
This reverts commit 7dba33b2cf.
2017-03-25 00:05:18 +00:00
Brian Vaughn 71a87bcfee Updating packages for 16.0.0-alpha.6 release 2017-03-24 23:16:34 +00:00
Brian Vaughn c5156eb0be ReactElementValidator uses temporary ReactNative View propTypes getter (#9256) 2017-03-24 23:16:24 +00:00
Sasha Aickin 60e78e37b8 Add more SSR unit tests for elements and children. (#9221)
* Adding more SSR unit tests for elements and children.

* Some of my SSR tests were testing for react-text and react-empty elements that no longer exist in Fiber. Fixed the tests so that they expect correct markup in Fiber.

* Tweaked some test names after @gaearon review comment https://github.com/facebook/react/pull/9221#discussion_r107045673 . Also realized that one of the tests was essentially a direct copy of another, so deleted it.

* Responding to code review https://github.com/facebook/react/pull/9221#pullrequestreview-28996315 . Thanks @spicyj!
2017-03-24 23:16:24 +00:00
Dan Abramov 7dba33b2cf 😭😭😭 2017-03-24 23:16:19 +00:00
Brian Vaughn 1a29b4e2a3 Updating packages for 16.0.0-alpha.6 release 2017-03-24 15:44:09 -07:00
Brian Vaughn 1acf949240 ReactElementValidator uses temporary ReactNative View propTypes getter (#9256) 2017-03-24 15:37:21 -07:00
Sasha Aickin 25deff6203 Add more SSR unit tests for elements and children. (#9221)
* Adding more SSR unit tests for elements and children.

* Some of my SSR tests were testing for react-text and react-empty elements that no longer exist in Fiber. Fixed the tests so that they expect correct markup in Fiber.

* Tweaked some test names after @gaearon review comment https://github.com/facebook/react/pull/9221#discussion_r107045673 . Also realized that one of the tests was essentially a direct copy of another, so deleted it.

* Responding to code review https://github.com/facebook/react/pull/9221#pullrequestreview-28996315 . Thanks @spicyj!
2017-03-24 13:31:15 -07:00
Dan Abramov 4691521ccb Merge branch 'master' into rollup 2017-03-24 18:19:44 +00:00
Dan Abramov 0a41890eaa Remove rethrowCaughtError injection (#9252) 2017-03-24 18:19:12 +00:00
Dominic Gannaway 0fd8aa604f removed react-native-renderer package and made build make a react-native build dir instead 2017-03-24 18:01:18 +00:00
Dominic Gannaway b5bdf70036 Merge branch 'rollup' of github.com:trueadm/react into rollup 2017-03-24 17:40:16 +00:00
Dominic Gannaway b4f9895c9c building facebook-www/build is now all sync to prevent IO issues plus handles extra facebook-www src assets 2017-03-24 17:25:01 +00:00
Dominic Gannaway beaf32c0a9 removed unnecessary resolve 2017-03-24 16:57:10 +00:00
Dominic Gannaway 8af3ca2274 facebook-www shims now get copied over correctly to build 2017-03-24 16:56:23 +00:00
Dan Abramov bd4ff9d6bf Unflowify shims 2017-03-24 16:22:05 +00:00
Johan Tinglöf 38d8f3ee6b Updated Router import for example (#9233)
Updated import in order to be a correct working example as in accordance with the docs
2017-03-24 09:37:32 -05:00
Dan Abramov a57e1403d9 Tweak reactComponentExpect to make it standalone-ish in www 2017-03-23 21:25:59 +00:00
Dan Abramov c84f4e03bc Add missing ReactErrorUtils shim 2017-03-23 21:15:30 +00:00
Dan Abramov 05bd00af2e More descriptive filenames 2017-03-23 20:32:36 +00:00
Dan Abramov 4458f156ad Move files around 2017-03-23 20:32:05 +00:00