Commit Graph
1546 Commits
Author SHA1 Message Date
Ben Alpert 76a7e2de75 Fix copying files to build/npm-react recursively
The intention of the `npm-react/**/*` rule was to copy recursively but it would have flattened any nested directory structure. I changed the `build/modules` rule to copy recursively as well, which is necessary for `ReactTestUtils` to be able to require `test/mock-modules.js` successfully. (`ReactTestUtils` isn't included in a clean `npm-react` build currently but it will be in the future.)

This also makes running ART tests more practical.
2014-01-17 01:15:15 -08:00
Pete Hunt 17de85689e Merge pull request #895 from spicyj/zomgperf
Make findComponentRoot faster with more nodeCache
2014-01-14 18:58:54 -08:00
Paul O’Shannessy b131da3869 Merge pull request #884 from spicyj/tut-datatype
Add dataType to all $.ajax calls for consistency
2014-01-14 18:48:05 -08:00
Ben Alpert d96c6914c7 Make findComponentRoot faster with more nodeCache
This is an alternative, less-invasive, fix for #891.

Test Plan:
On http://jsbin.com/OqOJidIQ/2/edit, got timings like

[75, 56, 30, 36, 27, 27, 28, 32, 27, 27, 28, 31]

instead of the old

[75, 729, 46, 32, 28, 34, 26, 27, 27, 30, 26, 26].

I also added a counter to getID and saw it was called 3014 times instead of the old 636264. (3014 is the number of nodes (3000) plus 3 calls that happen for the initial render and 1 for each of the 11 renders after that.)
2014-01-14 18:32:40 -08:00
cpojer c885abbf21 Allow null return values for functions to-be-merged. 2014-01-14 13:05:31 -08:00
Ben Alpert eb2ac7f2f2 Add dataType to all $.ajax calls for consistency
Fixes https://groups.google.com/forum/#!topic/reactjs/WWA3ZqU6y4w.
2014-01-13 19:54:09 -08:00
Pete Hunt d9b959884b Merge pull request #878 from spicyj/mount-unmounted
Improve "Can only mount when umounted" message
2014-01-13 14:38:07 -08:00
Ben Alpert 2f027fce2d Improve "Can only mount when umounted" message 2014-01-13 13:26:24 -08:00
Isaac Salier-Hellendag ad70848e80 Use fallback data for composition events if necessary 2014-01-13 13:15:17 -08:00
Pete Hunt c6f91ee6e8 Merge pull request #864 from spicyj/transition-key-set-faster
Rewrite mergeKeySets to be O(n) instead of O(n^3)
2014-01-13 12:50:42 -08:00
Christoph Pojer ca1ecc626b Merge pull request #876 from spicyj/cb-ctx
Always call callback in component context
2014-01-13 09:04:33 -08:00
Ben Alpert 1825f30353 Always call callback in component context
This brings these other call sites in line with line 67 of ReactUpdates.js:

callbacks[j].call(component);
2014-01-13 08:59:48 -08:00
Christoph Pojer 124096a9fe Fix #845, Trivial year change
This was accidentally pulled into gh-pages.
2014-01-13 08:56:20 -08:00
Christoph Pojer ad6a982cd0 Fix #874: Edit thinking-in-react
Accidentally pulled #874 into gh-pages.
2014-01-13 08:51:29 -08:00
Cheng Lou 3d47177596 fix propTypes.any.weak test
accidentally copied over `.string.weak` and didn't change it
2014-01-12 20:47:16 -08:00
Pete Hunt ddcab8be99 Merge pull request #871 from fernandoacorreia/jquery-mobile-example
jQuery Mobile React Example
2014-01-12 13:03:36 -08:00
Fernando Correia 425fd2ca08 jQuery Mobile React Example 2014-01-12 17:04:42 -02:00
Paul O’Shannessy 59cba3e9f7 Add missing semicolon I missed in #865 2014-01-11 23:29:35 -08:00
Paul O’Shannessy 6ebb1cb3ee Merge pull request #865 from jergason/link-to-docs-on-keys-warning
link to docs in unique key prop warning
2014-01-11 23:21:46 -08:00
Jamison Dance 972acb4581 link to docs in unique key prop warning 2014-01-11 22:17:06 -07:00
Paul O'Shannessy 2c335b0e57 Quieter devtools upsell
Check that we're not in a iframe before upselling.
2014-01-10 21:11:33 -08:00
Cheng Lou d14ce00dc3 add React.PropTypes.any
add the ability for React propTypes to accept an `any` type: `someProp: React.PropTypes.any`.
This is more useful when combined with `.isRequired`, to enforce that _something_ is passed:
`someProp: React.PropTypes.any.isRequired`
2014-01-10 21:11:11 -08:00
Pete Hunt d8a8f6a881 Upsell dev tools
People probably don't know these exist. Add some information about React
dev mode as well as a link to the developer tools when using Chrome.
2014-01-10 21:10:54 -08:00
Tim Yung bcacd17f8b Better LinkedValueMixin Warning
Input elements of type `checkbox`, `hidden`, or `radio` can have a `value` without `onChange`. Also, if the input is `disabled`, who cares that it doesn't have an `onChange`?
2014-01-10 21:10:01 -08:00
Tim Yung f71dbab31a Fix Undefined ownerDocument Fatal in IE8
This fixes a JS fatal in IE8 when `topLevelTarget.ownerDocument` is sometimes undefined.
2014-01-10 21:07:23 -08:00
Tim Yung 73d9d286ee Fix EnterLeaveEventPlugin Test in jsdom
This is a follow-up to #803.

In jsdom (used for internal testing), `<iframe>` does not properly create a default document. This makes the `EnterLeaveEventPlugin` tests work for jsdom, too.

Open source does not need this because it uses PhantomJS.
2014-01-10 21:04:39 -08:00
Paul O’Shannessy 49d6d2169d Remove trailing whitespace 2014-01-10 21:04:39 -08:00
Ben Alpert 1efb14bcf6 Rewrite mergeKeySets to be O(n) instead of O(n^3) 2014-01-10 15:31:15 -08:00
Pete Hunt 979ee27e2b Merge pull request #862 from cpojer/docs-proptypes
Document PropTypes.renderable and PropTypes.component
2014-01-10 09:55:19 -08:00
cpojer d73f80ecb2 Document PropTypes.renderable and PropTypes.component 2014-01-10 09:36:22 -08:00
Timothy Yung 338ce603f9 Merge pull request #797 from spicyj/should-update
Fix cases where owner warning is shown
2014-01-09 18:50:21 -08:00
cpojer 95cb79a93e Remove CallbackRegistry 2014-01-09 16:58:48 -08:00
cpojer b713c2c696 Add PropTypes.component to demand a single React component. 2014-01-09 16:58:47 -08:00
Ben Alpert f5a48f1ff4 Fix cases where owner warning is shown
In b0431a5 I added the check in the wrong place which could cause the warning to be shown because of key changes rather than owner changes like the warning suggests.
2014-01-09 16:48:58 -08:00
Timothy Yung f47238be41 Merge pull request #803 from spicyj/gh-788
Use proper window object for iframe in enter/leave
2014-01-09 16:35:07 -08:00
Timothy Yung 851f08bdc2 Merge pull request #780 from syranide/newhasevent
Further cleanup of isEventSupported
2014-01-09 16:34:57 -08:00
Timothy Yung 68bac7fbf0 Merge pull request #778 from syranide/flipwheel
Fix WheelEvent incorrectly flipping sign of deltaY
2014-01-09 16:34:47 -08:00
Timothy Yung dea6063dc9 Merge pull request #771 from spicyj/gh-694
Don't get selection if no active element
2014-01-09 16:34:27 -08:00
cpojer 8dbc530d1c Add --harmony option to jsx. 2014-01-09 15:21:48 -08:00
Paul O’Shannessy 1f5c8d21d8 Merge pull request #786 from spicyj/gh-781
Fix potential memory leak when unmounting
2014-01-09 13:08:07 -08:00
Timothy Yung 2c93cd0267 Merge pull request #640 from spicyj/immutable-props-2
Don't mutate passed-in props, take 2
2014-01-09 12:52:58 -08:00
Christopher Chedeau e3e3b477d3 Merge pull request #850 from spicyj/docs-ref-unmount
Document return value of unmountComponentAtNode
2014-01-09 09:21:39 -08:00
Ben Alpert 87a95155be Document return value of unmountComponentAtNode 2014-01-08 21:56:59 -08:00
Ben Alpert 2716f38861 Spy on purgeID instead of unmountIDFromEnvironment 2014-01-08 21:48:48 -08:00
Ben Alpert e2f094614f Fix potential memory leak when unmounting
Fixes #781.
2014-01-08 21:43:52 -08:00
Paul O’Shannessy 09011493c5 Merge pull request #718 from syranide/npmenvify
Fix npm react having wrong version dependency for envify
2014-01-08 15:33:59 -08:00
Paul O’Shannessy 0c3628cd8d Merge pull request #757 from spicyj/ng
Don't tack on EventPluginHub globally
2014-01-08 15:23:47 -08:00
Ben Alpert 1db788b62c Don't tack on EventPluginHub globally 2014-01-08 15:20:05 -08:00
Christopher Chedeau 2052caf0cc Merge pull request #846 from spicyj/docs-nomin
Remove two more react.min.js references
2014-01-08 11:45:25 -08:00
Ben Alpert 76a0a9cba7 Remove two more react.min.js references 2014-01-08 11:40:53 -08:00