Ben Alpert
697c09a26e
Merge pull request #4759 from spicyj/devprod
...
Fix diverging behavior of ReactFragment in `__DEV__`
2015-09-01 17:35:14 -07:00
Ben Alpert
c04d02e5e8
Add warnings to React module
2015-09-01 14:36:41 -07:00
Ben Alpert
b1e16b9d7e
React -> ReactDOM in test files
2015-09-01 14:34:37 -07:00
Ben Alpert
31cb102650
Merge pull request #4762 from spicyj/ts
...
Make TypeScript test work with ReactDOM
2015-09-01 14:30:56 -07:00
Ben Alpert
589c8364b0
Make TypeScript test work with ReactDOM
2015-09-01 14:28:12 -07:00
Ben Alpert
7e5ce19a94
Fix diverging behavior of ReactFragment in __DEV__
...
We could also remove the return statements but this is not a hot path and this seems safer.
2015-09-01 13:27:17 -07:00
Paul O’Shannessy
7645c07720
Use eslintrc from fbjs
2015-08-31 23:05:04 -07:00
Michelle Todd
719fe15b9e
Update warning messages to use ReactDOM and ReactDOMServer as appropriate
...
Fixes #4710 .
- `React.findDOMNode` => `ReactDOM.findDOMNode`
- `React.render` => `ReactDOM.render` or "top-level render" (depends on whether we're in DOM-specific usage or generic cases)
- `React.renderToString` => `ReactDOMServer.renderToString`
- `React.renderToStaticMarkup` => `ReactDOMServer.renderToStaticMarkup`
2015-08-31 22:55:27 -07:00
Ben Alpert
487cc586f7
Merge pull request #4731 from spicyj/map-one-pass
...
Make React.Children.map do one pass only
2015-08-31 18:52:51 -07:00
Ben Alpert
6013105a9c
Make React.Children.map do one pass only
...
Changed: createFragment no longer includes nulls in its output (since toArray doesn't and they share code).
Changed: React.Children.map no longer warns for clashing keys; traverseAllChildren will later when rendering.
Also change the generated key format around to accomodate. My keys are probably not bulletproof but should definitely be safe against accidental collisions.
2015-08-31 18:47:09 -07:00
Ben Alpert
dc4f011f57
Merge pull request #4735 from spicyj/shallow-error
...
Better error for invalid element when shallow rendering
2015-08-31 13:30:56 -07:00
Ben Alpert
42602a8922
Fix code style/grammar on synthetic event warning
2015-08-31 11:32:12 -07:00
Jim
0ff65cc892
Merge pull request #4635 from edvinerikson/event-pooling-warning
...
Added warning when calling methods on a released event.
2015-08-31 10:49:01 -07:00
Olivier Tassinari
0304051591
[adler32] fix wrong name
2015-08-29 19:07:36 +01:00
Ben Alpert
f4d7feb8be
Better error for invalid element when shallow rendering
...
Fixes #4721 , fixes #4730 .
2015-08-28 18:21:30 -07:00
Ben Alpert
a7230de902
Merge pull request #4727 from spicyj/gh-4233
...
Make findDOMNode error clearer
2015-08-28 12:52:18 -07:00
Paul O’Shannessy
2e5b047f04
Reverse condition of a ternary for readability
2015-08-28 11:34:50 -07:00
Ben Alpert
024f71535c
Merge pull request #4720 from spicyj/destructor
...
Add destructors to pooled classes in ReactChildren
2015-08-27 19:06:11 -07:00
Ben Alpert
16d8f20576
Add destructors to pooled classes in ReactChildren
...
And make destructors mandatory so we're less likely to forget again.
2015-08-27 19:05:56 -07:00
Niole Nelson
70c07c67b7
resolves issue #4168 , style prop error now names React class that erroring element is a child of.
2015-08-27 18:10:51 -07:00
Ben Alpert
72d5b8f116
Merge pull request #4700 from spicyj/frag-array
...
Make createFragment return an array, disallow objects as children
2015-08-26 11:12:06 -07:00
Ben Alpert
127917d454
Merge pull request #4701 from spicyj/gh-4525
...
Add deprecation notice for React.addons.batchedUpdates
2015-08-25 11:40:33 -07:00
Edvin Erikson
34af8f8597
Added warning when calling methods on a released event.
2015-08-25 14:45:56 +02:00
Ben Alpert
e64b402df9
Add deprecation notice for React.addons.batchedUpdates
...
Fixes #4525 .
2015-08-24 16:20:56 -07:00
Ben Alpert
6a2cdd58a4
Make findDOMNode error clearer
...
Fixes #4233 .
2015-08-24 16:15:44 -07:00
Ben Alpert
6abf025d46
Make createFragment return an array, disallow objects as children
2015-08-24 16:09:08 -07:00
Ning Xia
3232a59743
Fix typo
...
Can not should be a single word: 'cannot'
2015-08-21 13:26:58 -07:00
Espen Hovlandsdal
75805e4835
Allow results and autosave attributes (WebKit/Blink)
2015-08-21 10:10:32 +02:00
Ben Alpert
102fafce7f
Add a simple production-mode sanity check test
2015-08-19 22:26:42 -07:00
Daniel Rodgers-Pryor
6bd6ef208b
ReactCSSTransitionGroup timeouts
...
As discussed in issue 1326
(https://github.com/facebook/react/issues/1326 ) transitionend events are
unreliable; they may not fire because the element is no longer painted,
the browser tab is no longer focused or for a range of other reasons.
This is particularly harmful during leave transitions since the leaving
element will be permanently stuck in the DOM (and possibly visible).
The ReactCSSTransitionGroup now requires timeouts to be passed in
explicitly for each type of animation. Omitting the timeout duration
for a transition now triggers a PropTypes warning with a link to the
updated documentation.
2015-08-20 11:38:27 +10:00
Ben Alpert
b126926390
Ensure IE8 style expansion list is up to date
...
In conjunction with #1953 , fixes #2407 . This seems to be all of the shorthand style properties that IE8 supports, excluding a few nonstandard ones.
2015-08-19 17:22:37 -07:00
Andreas Svensson
f4f22a0baa
Apply CSS shorthand expansion to IE8 only
...
Closes #1953 .
2015-08-19 17:17:51 -07:00
Paul O’Shannessy
17d5440751
Merge pull request #4567 from koba04/fix-set-boolean-properties
...
Fixed consistency of behavior boolean properties
2015-08-19 10:20:49 -07:00
Paul O’Shannessy
eb056fcf5d
Re-sort some constants
2015-08-18 22:33:51 -07:00
Sebastian Markbåge
4a92860b00
Merge pull request #4089 from sebmarkbage/killowner
...
Don't use owner to determine if the auto-bailout should be used
2015-08-18 18:09:01 -07:00
Ben Alpert
81b4f7295d
Merge pull request #4611 from spicyj/create-element
...
Use createElement instead of HTML generation
2015-08-18 18:04:54 -07:00
Ben Alpert
cfd6f7a1b8
Use createElement instead of HTML generation
...
Behind a feature flag. This is a relatively simple change; adopting this strategy universally would mean that we could clean up a lot of code but this doesn't attempt to restructure more than necessary.
2015-08-18 17:44:20 -07:00
Sebastian Markbage
9315517dec
Don't use owner to determine if the auto-bailout should be used
...
I didn't realize that we actually special cased this. This is an
unfortunate heuristic but it helps minimize the harm that this optimization
does.
2015-08-18 17:33:13 -07:00
Ben Alpert
6663fb3135
Remove _isReactElement
...
As of this commit, we still support objects as maps so if anyone has an object with keys 'type' and 'props' this will change behavior, but otherwise this should be pretty safe.
2015-08-18 12:55:34 -07:00
Jim
87530049f8
Merge pull request #4481 from dmatteo/Simulate.change-tests
...
add tests for React.addons.TestUtils.Simulate.change
2015-08-17 11:23:12 -07:00
Bartosz Kaszubowski
1ca77c6ae6
tiny code tweak in ReactMultiChild
2015-08-15 01:25:09 +02:00
Paul O’Shannessy
b4b028dec0
Merge pull request #4622 from jorrit/instanceofreporttype
...
Report the actual type when PropTypes.instanceOf fails
2015-08-14 11:05:57 -07:00
Jorrit Schippers
cf6222dd71
Report the actual type when PropTypes.instanceOf fails
2015-08-14 17:46:24 +02:00
Paul O’Shannessy
6708059b51
Merge pull request #4607 from hekar/add/html-table-summary-attr
...
Added support for more HTML attributes: `summary`
2015-08-13 21:28:50 -07:00
Hekar Khani
be1fc794f0
Added support for more HTML attributes: summary
...
This attribute is used on <table> to support screen readers.
It is deprecated, so take a look at <caption> instead.
2015-08-13 22:41:37 -05:00
Igor Scekic
0e834fabca
swap places of mounted and pending update checks
...
prevents a type error if the component isn't mounted
2015-08-13 16:34:47 +02:00
Sebastian Markbåge
d3f338ff27
Fix typecheck
2015-08-12 00:32:52 -07:00
Ben Alpert
a54d321765
Remove accidental .only
2015-08-11 18:19:42 -07:00
Ben Alpert
dc5a5adfaf
Merge pull request #4477 from mridgway/autobind-opt-out
...
Allow classes created with React.createClass to opt out of autobinding
2015-08-11 18:03:41 -07:00
Ben Alpert
655b82fb7b
Merge pull request #3332 from spicyj/warn-r2
...
Warn with two copies of React
2015-08-11 17:17:53 -07:00
Ben Alpert
Ben Alpert
Paul O’Shannessy
Michelle Todd
Jim
Olivier Tassinari
Niole Nelson
Edvin Erikson
Ning Xia
Espen Hovlandsdal
Daniel Rodgers-Pryor
Andreas Svensson
Sebastian Markbåge
Sebastian Markbage
Bartosz Kaszubowski
Jorrit Schippers
Hekar Khani
Igor Scekic