393cdbc745
Consolidate ReactCurrentFiber and ReactDebugLifeCycle
2017-02-24 11:16:58 -08:00
d2c28be69b
Use ReactDebugLifeCycle to track if we're inside getChildContext
2017-02-24 11:02:21 -08:00
309dea5b4c
Track which lifecycle method we're in during DEV
...
Use this to detect setState inside of render instead of relying on
the owner.
2017-02-24 11:02:21 -08:00
ebfde985d9
Warn about nested renders
2017-02-24 11:02:21 -08:00
75ee3c1424
Warn about setState inside getChildContext
...
Stack uses a module called ReactInvalidSetStateWarningHook, but all it
does is warn about setState inside getChildContext. Doesn't seem worth
keeping around, so I didn't use it for Fiber, but if I'm mistaken I'll
change it.
2017-02-24 11:02:21 -08:00
2f3df5f0b3
Warn about setState in render
2017-02-24 11:02:21 -08:00
769c6e0ebe
Merge pull request #9060 from acdlite/fixrecordtestsscript
...
Fix record-tests script
2017-02-24 10:59:44 -08:00
3bdc6d0c8e
Fix record-tests script
...
Result of readConfig changed slightly in Jest 0.19.
2017-02-24 10:46:49 -08:00
1ae7436d01
Merge pull request #9058 from nihgwu/patch-1
...
fix version
2017-02-24 10:10:11 -08:00
18229fdeda
fix version
...
per https://github.com/facebook/react/commit/ca4325e3eff16b86879188eb996ebcc9a933336a#commitcomment-21033948
2017-02-24 17:35:27 +08:00
ca4325e3ef
16.0.0-alpha.3
2017-02-23 15:36:08 -08:00
18217cfede
Merge pull request #9054 from acdlite/fiberpreventextensions
...
[Fiber] Prevent extensions to fiber in DEV
2017-02-23 14:42:16 -08:00
f3c2d9f308
Merge pull request #9004 from acdlite/proptypescheck
...
API for checking external objects against React prop types
2017-02-23 14:37:19 -08:00
b81175d37a
Removed unnecessary if ( #9031 )
2017-02-23 15:14:21 -06:00
49840f2e6b
Missing onLoad and onError events on image tag ( #9042 )
2017-02-23 15:05:38 -06:00
d724aed404
Update tutorial.md ( #9051 )
2017-02-23 14:54:03 -06:00
ddf59c403a
Prevent extensions to fiber in DEV
...
Helps us avoid accidentally adding fields to the fiber class
2017-02-23 11:23:44 -08:00
03ed3437c9
Fix build config
...
ReactDebugCurrentFrame is shared state.
checkPropTypes should be imported via the main React export,
not imported directly.
2017-02-23 11:14:15 -08:00
0320b8ecb4
Wrap checkPropTypes in DEV conditional so it's stripped out in prod
2017-02-23 11:14:15 -08:00
e6d6ad3e88
Remove closure in checkReactTypeSpec by tracking stack info globally
...
There's a lot of overlap between ReactCurrentOwner,
ReactDebugCurrentFrame, and ReactDebugCurrentFiber that should
be consolidated.
2017-02-23 11:14:14 -08:00
9993fdd957
Change formatMessage parameter to getStack
...
Gives us flexibility in the future to deal with the stack and the
message separately.
2017-02-23 11:14:14 -08:00
6ff5211dee
Remove warnOnRepeat option
...
Don't need this internally; doubt external users will need it either
2017-02-23 11:14:14 -08:00
3746a9dafb
Invert dependency between checkPropTypes and checkReactTypeSpec
...
Expressing checkReactTypeSpec using the public API frees us to move it
to a separate module in the future.
2017-02-23 11:14:14 -08:00
e4acd12a9b
Test that checkPropTypes does not throw or return a value
2017-02-23 11:14:14 -08:00
600685bdef
Add PropTypes.checkPropTypes API
...
Allows users to check arbitrary objects against React prop types without
relying on the implementation details of the prop validators themselves.
An example of why this is important: some prop validators may throw,
while others return an error object. Calling a prop validator manually
requires handling both cases. `checkPropTypes` does this for you.
2017-02-23 11:14:14 -08:00
bef723e47f
Remove ReactPropTypeLocationNames module
...
ReactPropTypeLocationNames was a map of location identifiers to location
display names, for use in warnings. But in practice, this did nothing
except rename "childContext" to "child context." Not worth it, IMO.
Since we are going to add an API for running prop type checks manually,
we need the ability to support arbitrary prop type locations. So
each place that used to accept a ReactPropTypeLocation now just accepts
a string.
2017-02-23 11:14:14 -08:00
91e8081cf0
Merge pull request #9045 from trueadm/emptyObject-reference-mismatch-due-to-mocking
...
[Fiber] fix ensure class components refs get re-assigned to emptyObject on mount
2017-02-23 15:38:10 +00:00
23f245173a
Merge pull request #9043 from trueadm/fix-fiber-functional-componment-childcontext
...
[Fiber] adds `childContextTypes` warnings for functional components
2017-02-23 15:37:48 +00:00
bde5df1d76
addressed code in feedback
2017-02-23 15:37:19 +00:00
a99d77e073
added a regression test for factory components
2017-02-23 14:00:02 +00:00
925743bfc9
reverted ReactDOMFeatureFlags
2017-02-23 13:40:16 +00:00
e7d7809eb1
reverted the getChildContext warning from showing on functional components in Fiber
2017-02-23 13:39:08 +00:00
25f4abc9d5
mountClassInstance() now re-assigns instance.refs to emptyObject
2017-02-23 12:58:37 +00:00
a749083b85
fixed comment that was incorrect
2017-02-23 12:42:21 +00:00
724ae9b35a
reverts previous changes to inlining requires and fixes test suite instead
2017-02-23 12:31:58 +00:00
5f6f3277f5
Add test for hack to stop bubbling ( #8922 )
2017-02-22 14:02:10 -08:00
9503abe5c7
Pass errorBoundary to logCapturedError ( #9050 )
2017-02-22 13:06:49 -08:00
2081a0053a
Merge pull request #8949 from acdlite/fibercomponentlifecycletests
...
[Fiber] Component lifecycle tests
2017-02-22 12:54:42 -08:00
a44a5d68d8
Fix bugs that occur when event responder unmounts during a touch event sequence
...
> This PR adds a test (initially failing) for this case along with a fix for stack and fiber. The stack fix was copied from a Diff submitted by @sema. The fiber fix just required us to stop leaking properties for unmounted views.
> Longer term we may want to explicitly invoke a release event listener for a responder just before unmounting it. This PR does not do that.
2017-02-22 12:47:34 -08:00
42c375b136
Merge pull request #9040 from acdlite/assignstateincwrp
...
Support for assigning to this.state inside componentWillReceiveProps
2017-02-22 12:45:58 -08:00
5cc2a4fe3e
Fixed typo: "Calcutor" to "Calculator" ( #9047 )
2017-02-22 17:37:55 +00:00
55f18f20ea
Update Fiber debugger deps
2017-02-22 17:20:53 +00:00
67c1fde70e
Upgrade Jest to v19 ( #9034 )
2017-02-22 16:59:18 +00:00
b8cf75a5b4
updated tests-failing and test-passing
2017-02-22 16:16:21 +00:00
3a7d6f5384
moved require(emptyObject) to inline calls to get around referential mismatch
...
Due to how Jest and other mocking libraries work in userland, modules that are required might not be referentially equal at various stages of the application lifecycle. This isnt a perfect fix, but by having the require calls inline, it has a better liklihood of ensuring emptyObject is the same reference
2017-02-22 16:12:51 +00:00
a9325e2ec4
adds childContextTypes warnings for functional components
...
ReactStatelessComponent-test.js fails due to warnings not showing up when functional components mount or update. This PR ports the existing warnings from stack and re-applies them to fiber functional components and attempts to re-use some logic in ReactFiberContext that currently exists for showing warnings when dealing with class components.
2017-02-22 14:21:10 +00:00
d649ebc6e1
Test should ensure that update is applied before corresponding render
...
Tightens up the test a bit to prevent regressions.
2017-02-21 16:47:25 -08:00
3d44a6a486
Improved stack/fiber type-check to avoid false negative match when inst._rootNodeID is 0
2017-02-21 15:14:18 -08:00
28dbbe5734
Run test script
2017-02-21 14:43:01 -08:00
d3cbbe3b36
Add deprecation warning for assigning to this.state inside cWRP
...
We'll remove support for this in a future release, though we'll likely
still warn.
2017-02-21 14:42:12 -08:00
Andrew Clark
Andrew Clark
Neo
Maxwel D'souza
mdogadailo
Dai Nguyen
Dominic Gannaway
Dominic Gannaway
Ben Alpert
Brian Vaughn
Stephie
Dan Abramov
Michał Pierzchała