Commit Graph
927 Commits
Author SHA1 Message Date
Andreas SvenssonandPaul O’Shannessy 36cf618ee7 Fix ReactDOMTextarea missing "rows" and "cols" attribute, incorrect "size" property 2013-12-17 10:45:01 -08:00
Andreas SvenssonandPaul O’Shannessy 68edaa3cfd Add HAS_POSITIVE_NUMERIC_VALUE to DOMProperty and normalize behavior of null values
Uniformly remove null values, rather than sometimes set/remove, could potentially assign 'null' or 'undefined'
2013-12-17 10:45:01 -08:00
Paul O’Shannessy 6235c6b346 Update shrinkwrap 2013-12-13 15:17:26 -08:00
Thomas AylottandPaul O’Shannessy 1bf4de4110 fixes browserify task transforms support 2013-12-13 15:08:38 -08:00
Paul O’Shannessy 57b34a120e Move npm-react-core to npm-react, fix tasks accordingly 2013-12-13 14:24:14 -08:00
Paul O’Shannessy d0be71c8f3 Update react package readme 2013-12-13 14:24:14 -08:00
petehuntandPaul O’Shannessy c278a788ac Version bump, make tests work
Conflicts:
	grunt/tasks/populist.js
	package.json
	src/core/React.js
2013-12-13 14:24:11 -08:00
petehuntandPaul O’Shannessy 1dd0ae5eb7 update README 2013-12-13 14:15:57 -08:00
petehuntandPaul O’Shannessy 207f2ddb00 version bump to 0.8 to get on top of react.js
Conflicts:
	package.json
2013-12-13 14:15:54 -08:00
petehuntandPaul O’Shannessy 1188ba5047 rename to with associated warnings 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy caebca54b8 rename to with associated warnings 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy 39b7ba2842 revert muffinize :( 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy 280243f28b response to code review 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy 5361a2bc92 update npm-react-core package.json 2013-12-13 14:14:42 -08:00
Paul O’Shannessy 4262a4089e react-core npm module 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy 66b7a5ba0c muffinification 2013-12-13 14:14:42 -08:00
petehuntandPaul O’Shannessy 0d69d37d06 first work: __DEV__
fix invariant

Get browserify working

remove dead code elimination step since it is not needed due to minifier

use industry standard NODE_ENV

Conflicts:
	grunt/config/browserify.js
	package.json
2013-12-13 14:14:40 -08:00
Ben NewmanandPaul O’Shannessy 92fd516ab8 Explicitly require the assert module in vendor/constants.js. 2013-12-13 14:12:45 -08:00
Ben NewmanandPaul O’Shannessy 0b584b9f8e Better comments for vendor/constants.js. 2013-12-13 14:12:45 -08:00
Ben NewmanandPaul O’Shannessy 1d9a0ce7ff Rewrite vendor/constants.js to use require("ast-types").traverse.
Most notably, this new style of transformation gives us access to
this.parent.node, which allows us to avoid replacing identifiers that are
not actually free variables, such as member expression properties.

Closes #496.

Conflicts:
	package.json
2013-12-13 14:11:22 -08:00
Paul O’Shannessy a426f1f216 Update depedencies 2013-12-13 13:46:48 -08:00
Paul O’Shannessy 107fbfa809 Disable AnalyticsEventPlugin-test
It gets stuck in web worker issues for some reason. I don't particularly
care and I don't think any of the changes we merged in should be
actually breaking it.
2013-12-13 13:44:35 -08:00
Thomas AylottandPaul O’Shannessy c93db82538 skip Worker test unless the browser supports them 2013-12-12 16:38:05 -08:00
Sean KinseyandPaul O’Shannessy f1a4b84e4c [ReactTransitionGroup] Add onTransitionEnter and onTransitionLeave
It is valuable to know when the number of children in a TransitionGroup is going
to increase or decrease, since we might want to apply extra animations.
For instance, when used with overflow:auto, we might want to apply different css
based on it overflowing or not - to do this we need to calculate this after new
nodes has entered and after nodes has been removed.
2013-12-12 16:01:50 -08:00
John WatsonandPaul O’Shannessy 6438a87264 Separate replaceState invariant violations
It'd be nice if we knew which error we were hitting when this invariant hit.
2013-12-12 16:01:50 -08:00
Ben AlpertandPaul O’Shannessy 8cb528f0d3 Remove unused updatePropertiesByID 2013-12-12 16:01:50 -08:00
Pete HuntandPaul O’Shannessy 656e1bd1b1 Fix lint warnings 2013-12-12 16:01:50 -08:00
Ben AlpertandPaul O’Shannessy b0a8103668 Add missing license header 2013-12-12 16:01:49 -08:00
Ben AlpertandPaul O’Shannessy 7c702fd312 Remove unused event plugin registrationNamesKeys 2013-12-12 16:01:49 -08:00
Ben AlpertandPaul O’Shannessy 52c7c95be6 ReactErrorUtils: In prod, just return the original
This will save a stack frame (nice when in a debugger) and presumably be a bit faster.
2013-12-12 16:01:49 -08:00
Ben AlpertandPaul O’Shannessy b6c7300d48 Don't use .returnValue if .defaultPrevented exists
`.defaultPrevented` exists in IE9+. I checked in IE9, Chrome, and Firefox that it does default to `false`.

Fixes #527.
2013-12-12 16:01:49 -08:00
Christoph PojerandPaul O’Shannessy bc219a2d6e Ensure ReactPerf always uses a string as a URL 2013-12-12 16:01:49 -08:00
Paul O'ShannessyandPaul O’Shannessy ad693d9541 order object properties consistently 2013-12-12 16:01:49 -08:00
Pete HuntandPaul O’Shannessy 2d5142bc35 Better error message for renderComponentToString()
Reported on Twitter by AirBnb (who are integrating React into their open-source JS framework). They made a mistake and passed a string in as the
component. We should have a better error message for that.
2013-12-12 16:01:49 -08:00
Marshall RochandPaul O’Shannessy 6f9f371d2b Rename receiveProps to receiveComponent
This renames receiveProps and changes it to take the next component to copy props from instead of just the props. That is,

  component.receiveComponent(nextComponent, transaction)

instead of

  component.receiveProps(nextComponent.props, transaction)

This is a precursor to adding contexts, which will also need to get propagated just like props. This change allows ReactCompositeComponent to override `receiveProps` and do something like

  this._pendingContext = nextComponent.context;

Conflicts:
	src/core/ReactCompositeComponent.js
2013-12-12 16:01:43 -08:00
Simon HøjbergandPaul O’Shannessy 9e9b3f7348 Transitions: Handle undefined input to mergeKeySet
Gracefully handle undefined input to mergeKeySet.
2013-12-12 15:58:54 -08:00
Simon HøjbergandPaul O’Shannessy 012ac24728 ReactTransitions: Don't animate undefined children 2013-12-12 15:58:54 -08:00
Brian KimandPaul O’Shannessy 4915a63973 Fix failing tests
Two of your tests were failing because of commit
1e71df5399
I fixed them by:
1) Using jasmine's spyOn in ReactCompositeComponentError-test.js
2) Inverting the function wrapping in the above commit.
Godspeed.
2013-12-12 15:58:54 -08:00
Tim YungandPaul O’Shannessy 55c5178a55 Rename nodeContains to containsNode
Conflicts:
	src/core/ReactMount.js
2013-12-12 15:58:51 -08:00
Mouad DebbarandPaul O’Shannessy f142b9b99b Add support for oncontextmenu in React. 2013-12-12 15:57:00 -08:00
Felix KlingandPaul O’Shannessy 4eb9487c97 Improve error logging for event handlers of React components.
This guards every auto-bound method and uses the name of the component and method as guard name.
2013-12-12 15:57:00 -08:00
Andreas SvenssonandPaul O’Shannessy 3f31ee8d3c Fix wheelDelta misspelled 2013-12-12 15:57:00 -08:00
Ben AlpertandPaul O’Shannessy 89480e9f38 Make submit button default value appear correctly
Fixes #473.
2013-12-12 15:57:00 -08:00
SanderSpiesandPaul O’Shannessy 4361fb36f9 Removing 'isEventSupported' 2013-12-12 15:57:00 -08:00
SanderSpiesandPaul O’Shannessy e1fce03d64 Removing unused useSelect variable. 2013-12-12 15:57:00 -08:00
Laurence RoweandPaul O’Shannessy 0b4f89cecb Script async and defer properties 2013-12-12 15:57:00 -08:00
Paul O’Shannessy c09bc39a34 Oxford comma 2013-12-12 15:57:00 -08:00
Josh DuckandPaul O’Shannessy 996cda82e1 Fix ReactDOMSelection for IE 11
IE 11 no longer supports the legacy document.selection API.
Their implementation of window.getSelection() doesn't support
the extend() method, which we were relying on.

If the selection is RTL and selection extend is missing, then just
flip the selection.
2013-12-12 15:57:00 -08:00
Matti NelimarkkaandPaul O’Shannessy efa3618955 Clear error message when rendering a nonvalid component 2013-12-12 15:57:00 -08:00
Tim YungandPaul O’Shannessy c6d2f06697 Better getUnboundedScrollPosition for windows
Instead of using browser sniffing, `getUnboundedScrollPosition` can do
better and not have to depend on the `getDocumentScrollElement` module.
2013-12-12 15:56:59 -08:00