29ca22c2ff
Merge pull request #2852 from zpao/lint-fail-travis
...
Add eslint grunt task, fail travis for it
2015-01-13 16:12:15 -08:00
84c83dca2d
Add eslint grunt task, fail travis for it
...
This is it...
2015-01-13 16:11:42 -08:00
54c82da15f
Merge pull request #2751 from zpao/eslint-fixup
...
Eslint fixup
2015-01-13 15:27:54 -08:00
47ee780caf
[lint] fix consistent-returns
2015-01-13 15:26:33 -08:00
2126600c37
[lint] disable a couple rules since rest args aren't processed right
2015-01-13 15:26:33 -08:00
847357e42e
[lint] Fix reasonable lines to 80
...
I don't agree with 80 on principal but it's what we have for now.
This fixes the reasonable cases. Most of the long lines are in docblocks
with long type information or containing links.
2015-01-13 15:26:33 -08:00
e27da99731
[lint] Fix majority of issues eslint found
2015-01-13 15:26:33 -08:00
df2ddc5dfa
[lint] convert to single quotes
2015-01-13 15:26:33 -08:00
df64a67b7f
codemod "use strict" to 'use strict' for better linting
2015-01-13 15:26:32 -08:00
fa40eefa00
Merge pull request #2818 from jsfb/unmasked-context-in-performContextUpdate
...
Context warning should fire on update, not just initial mount.
Renamed a couple instances of context
2015-01-13 15:05:45 -08:00
aeffbef21f
Merge pull request #2662 from zpao/eslint
...
Use eslint
2015-01-13 14:03:16 -08:00
3f8d4eaa63
Use eslint
...
These rules are very close to what we have internally. We may still miss
a couple things (jsdoc params being a big one) but it's good enough.
This is also more restrictive than what we enforce internally, but it's
for the best.
2015-01-13 14:01:34 -08:00
7a3083af36
Merge pull request #2806 from sebmarkbage/baseclass
...
Warn when defined methods are used in plain JS classes
2015-01-13 11:40:52 -08:00
2330962d25
Warn when defined methods are used in plain JS classes
...
In ReactClass we use early validation to warn you if a accidentally defined
propTypes in the wrong place or if you mispelled componentShouldUpdate.
For plain JS classes there is no early validation process. Therefore, we
wait to do this validation until the component is mounted before we issue
the warning.
This should bring us to warning-parity with ReactClass.
2015-01-13 11:29:28 -08:00
d138f9a35b
Merge pull request #2805 from sebmarkbage/baseclass1
...
Introducing ReactComponentBase base class
2015-01-13 11:00:56 -08:00
ff032dc857
Introducing ReactComponentBase base class
...
This is the base class that will be used by ES6 classes.
I'm only moving setState and forceUpdate to this base class and the other
functions are disabled for modern classes as we're intending to deprecate
them. The base classes only have getters that warn if accessed. It's as if
they didn't exist.
ReactClass now extends ReactComponentBase but also adds the deprecated
methods. They are not yet fully deprecated on the ReactClass API.
I added some extra tests to composite component which we weren't testing
to avoid regressions.
I also added some test for ES6 classes. These are not testing the new
state initialization process. That's coming in a follow up.
2015-01-13 10:54:19 -08:00
e4842b4ae2
Context warning should fire on update, not just initial mount.
...
Renamed a couple instances of context to make it clear if it was masked/unmasked
2015-01-12 16:40:08 -08:00
90053da7bd
Merge pull request #2844 from kchia/patch-1
...
Update README.md insert comma
2015-01-12 09:45:52 -10:00
08c7c556de
Update README.md insert comma
...
The file change inserts a missing comma.
Best,
Hou
2015-01-12 11:29:17 -08:00
d94acc0363
Merge pull request #2830 from jsfb/remove-tag-warning
...
Removed unknown tag warning/whitelist.
2015-01-12 10:42:44 -08:00
f50da7ec63
Merge pull request #2832 from kikyous/patch-1
...
Update 07-forms.md
2015-01-10 13:54:05 -08:00
61f7a5613b
Removed unknown tag warning/whitelist.
2015-01-09 11:46:47 -08:00
bb52715f1c
Update 07-forms.md
2015-01-09 10:19:42 +08:00
5394acdb4b
Merge pull request #2799 from stkb/master
...
Wrap setInnerHTML in Windows 8 apps (Fixes #441 )
2015-01-07 16:47:32 -08:00
4772967e29
Remove period from findDOMNode test filename
2015-01-07 15:16:31 -08:00
6204aeec7d
Merge pull request #2822 from zpao/rm-immutable
...
Remove LegacyImmutableObject
2015-01-07 13:27:21 -08:00
9514861d93
Merge pull request #2814 from jsfb/testutils-consolemock
...
Added jasmine matcher that expects calls to console.warn.
2015-01-07 13:10:53 -08:00
7863175cd9
Remove LegacyImmutableObject
...
We don't use it and it's not part of the build so nobody else is using
it. You should probably use immutable instead anyway.
2015-01-07 11:37:52 -08:00
cdec83732d
suggesting the use of immutable js for comparisons
2015-01-07 10:46:50 -08:00
bd4aff062d
Added jasmine matcher that expects calls to console.warn.
2015-01-06 14:05:37 -08:00
a45472e050
Merge pull request #2793 from huang47/improve/use-bundle-collapser-to-reduce-file-size
...
use bundle-collapser to reduce browserified file size
2015-01-05 15:43:04 -08:00
680bfd54a6
Merge pull request #2807 from JoshSGman/patch-1
...
Fix Outdated Copyright Year
2015-01-05 15:42:12 -08:00
e5b3f9aefa
Merge pull request #2520 from jsfb/warn-for-dangerouslySetInnerHtml
...
Added checks for incorrect usage of innerHTML. Fixes #1370
2015-01-05 13:39:16 -08:00
158e0dd35a
Merge pull request #2614 from jsfb/monitor-should-update-owner-is-useful
...
Find cases where shouldUpdateReactComponent is det
2015-01-05 13:32:43 -08:00
2a28189bea
Merge pull request #2800 from jsfb/getDOMNode-becomes-findDOMNode
...
Minor updates to findDOMNode, as per additional post-commit CR feedback.
2015-01-05 13:29:14 -08:00
f507ba3c2b
Minor updates to findDOMNode, as per additional post-commit CR feedback.
2015-01-05 13:26:35 -08:00
9bc1961936
apply browserify bundle collapser to all build type
2015-01-05 13:15:16 -08:00
e926d4ff54
Fix Outdated Copyright Year
...
Fix outdated copyright year (update to 2015)
The copyright year was out of date. Copyright notices must reflect the current year. This commit updates the listed year to 2015.
2015-01-05 13:52:20 -05:00
a7028c467f
Merge pull request #2801 from jsfb/componentDidUpdate-docs
...
Update docs to indicate that componentDDidUpdate is fired after changes are flushed to the DOM. Fix
2015-01-05 09:34:38 -08:00
9c55b961d3
code formatting fixes
2015-01-05 18:21:53 +01:00
26636e501d
Merge pull request #2791 from rickbeerendonk/patch-1
...
Update ref-09-glossary.md
2015-01-05 09:05:46 -08:00
7295f36b0f
Merge pull request #2788 from mihaip/master
...
SyntheticEvent.timeStamp is a number, not a Date
2015-01-05 09:05:19 -08:00
08c5e42649
Update docs to indicate that componentDDidUpdate is fired after changes are flushed to the DOM. Fixes #2796
2015-01-02 14:02:44 -08:00
3287ea52fe
Wrap setInnerHTML in Windows 8 apps
2015-01-02 20:28:58 +01:00
f214776a97
use bundle-collapser to reduce browserified file size
2014-12-30 23:16:04 -08:00
717b6d6249
Update ref-09-glossary.md
...
Minor grammatical fix.
2014-12-30 23:42:38 -05:00
c0e33e8e76
SyntheticEvent.timeStamp is a number, not a Date
...
Also makes the a few other attribute types use lowercase (primitive) naming, to be consistent.
2014-12-30 12:06:49 -08:00
ebf4cb4fab
Merge pull request #2785 from c-das/patch-1
...
Update 02-displaying-data.md
2014-12-30 06:45:18 -08:00
b25e2e70d8
Update 02-displaying-data.md
...
Just a couple of minor grammatical fixes.
2014-12-30 10:49:44 +00:00
82a30268a3
Merge pull request #2767 from sebmarkbage/moderntypevalidation
...
Add late class validation warnings for statics
2014-12-29 12:45:49 -05:00
Paul O’Shannessy
Jim
Sebastian Markbåge
Sebastian Markbage
Jim
Ben Alpert
Hou Chia
Christopher Chedeau
chen
Jason Bonta
ShihChi Huang
Joshua Goldberg
Steve Baker
Rick Beerendonk
Mihai Parparita
Chitharanjan Das