Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,155 Commits 681 Branches 148 Tags
23eac0bbbb3a22b9d15bd68dd36e7a32f03ea7be
Commit Graph
1155 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Cheng Lou 23eac0bbbb docs tips expose component function 2013-12-30 17:07:24 -05:00
Pete Hunt 22dc8fa765 Merge pull request #602 from chenglou/tips-bind 
docs tips pass arguments to callbacks
 2013-12-01 19:07:14 -08:00
Cheng Lou e98244adb5 docs tips parent-child communication 2013-12-01 21:39:22 -05:00
Pete Hunt 92b62bf1fe Merge pull request #576 from spicyj/immutable-props 
Don't mutate passed-in props
 2013-12-01 18:26:41 -08:00
Pete Hunt 2a84b6c6b2 Merge pull request #537 from hojberg/dont_animate_undefined_children 
ReactTransitions: Don't animate undefined children
 2013-12-01 14:21:11 -08:00
Pete Hunt 285e3a8929 Merge pull request #440 from petehunt/new-taglines 
New marketing copy
 2013-12-01 14:00:13 -08:00
Pete Hunt ab36b114fc Merge pull request #581 from chenglou/docs-select-value 
docs `select` `value` to control chosen option
 2013-12-01 13:53:12 -08:00
Paul O’Shannessy d8a1dbb19c Merge pull request #618 from chenglou/didmout-didUpdate-new 
docs remove rootNode for componentDidMount/Update
 2013-11-27 18:50:10 -08:00
Cheng Lou cffb115480 docs remove rootNode for componentDidMount/Update 2013-11-27 21:46:02 -05:00
Paul O’Shannessy 98b9e2faeb Merge pull request #599 from chenglou/dl-addons 
docs add download links for react-with-addons
 2013-11-27 14:48:42 -08:00
Cheng Lou 11638b7824 docs add download links for react-with-addons 2013-11-27 17:31:27 -05:00
Paul O’Shannessy 8fbdb50a9d Merge pull request #597 from spicyj/gh-527 
Don't use .returnValue if .defaultPrevented exists
 2013-11-27 14:28:26 -08:00
Paul O’Shannessy 5fbd8109f8 Merge pull request #598 from spicyj/gh-516 
Be resilient to fn.name not existing in IE
 2013-11-27 14:28:02 -08:00
Paul O’Shannessy 126ef094fc Merge pull request #593 from spicyj/run-lint 
Run lint on Travis in a matrix
 2013-11-27 14:14:33 -08:00
Ben Alpert 2104327ba1 Run lint automatically on Travis (in a matrix) 2013-11-27 16:53:57 -05:00
Paul O’Shannessy 42eef0e9d6 Merge pull request #610 from chenglou/jsx-js 
make docs jsx compiler highlight transpiled js code
 2013-11-27 12:22:51 -08:00
Paul O’Shannessy e31fdfd0b3 Merge pull request #616 from davidhellsing/patch-1 
Backbone example: changed key from Math.random() to todo.cid
 2013-11-27 12:14:40 -08:00
Marshall Roch 697a9113c0 ReactPropTypes: add oneOfType to support union types 
Summary:
e.g.

  propTypes: {
    foo: React.PropTypes.oneOfType([
      React.PropTypes.string,
      React.PropTypes.number
    ]);
  }

to do this, I exposed a `.weak` chainable validator that returns instead of throws, e.g.

  React.PropTypes.string.isRequired.weak
  React.PropTypes.string.weak

which returns true or false. Technically, `React.PropTypes.string.weak.isRequired` also exists, but `oneOfType` will never call it. Might be useful to people creating custom validators though.
 2013-11-27 12:10:50 -08:00
Marshall Roch 351dcfed01 Validate propTypes, contextTypes, childContextTypes 
who watches the watchmen?
 2013-11-27 12:10:50 -08:00
Pete Hunt fcfe516a2e Less verbose ReactPropTypeLocations logging 
Since we use keyMirror() and invariant() messages are only shown in __DEV__, we don't have to do manual constant->string translation. Also fixes a few
undefined keys that just happened to work before.
 2013-11-27 12:10:50 -08:00
Paul O’Shannessy 9886e40395 Merge pull request #594 from spicyj/skip-spec 
Allow running one spec/suite in the web interface
 2013-11-27 11:54:31 -08:00
Paul O’Shannessy a7811fb75b Merge pull request #595 from spicyj/old-logger 
Remove reference to old browser logger
 2013-11-27 11:46:15 -08:00
David Hellsing a79ef7fc29 Changed key from Math.random() to todo.cid 
It doesn’t make much sense to generate a random key for each todo render, because it will re-draw all todo’s DOM nodes on each model change. I changed it to the unique identifier ``todo.cid`` already supplied by the backbone model.
 2013-11-26 18:07:56 +01:00
Cheng Lou 92ea31c7b7 make docs jsx compiler highlight transpiled js code 2013-11-25 19:04:28 -05:00
Thomas Aylott 564c8669f8 Merge pull request #596 from spicyj/gh-532 
'getElementsByClassName' doesn't exist in IE8
 2013-11-25 09:29:52 -08:00
Pete Hunt a7f0afceec Merge pull request #589 from balanceiskey/master 
Minor spelling correction in docs
 2013-11-24 20:53:35 -08:00
Ben Newman 1f8f0ae2d6 Merge pull request #601 from spicyj/commoner-088 
Update commoner to 0.8.8 for Windows support.
 2013-11-24 13:06:59 -08:00
Ben Alpert 0e2840abce Update commoner to 0.8.8 for Windows support 
benjamn/commoner#44 fixed commoner to work on Windows when module path relativization isn't used; with this, the `jsx` binary should work properly on Windows (though `jsx-internal` still won't).

Fixes #316, fixes #391, fixes #567.
 2013-11-24 16:02:01 -05:00
Ben Alpert 685dec022a Be resilient to fn.name not existing in IE 
Fixes #516.
 2013-11-24 01:53:53 -05:00
Ben Alpert 4bd0a40037 Don't use .returnValue if .defaultPrevented exists 
`.defaultPrevented` exists in IE9+. I checked in IE9, Chrome, and Firefox that it does default to `false`.

Fixes #527.
 2013-11-24 01:35:49 -05:00
Ben Alpert b99fd93684 'getElementsByClassName' doesn't exist in IE8 
Fixes #532.
 2013-11-24 01:22:00 -05:00
Ben Alpert 67c851792a Remove reference to old browser logger 
The file was removed in 37bb9b76aba0deb445874273b93955ffb1c18bf8; this was giving a 404.
 2013-11-24 01:04:09 -05:00
Ben Alpert 3a75d70501 Allow running one spec/suite in the web interface 
This is the proper way to make it filter the spec list:

https://github.com/pivotal/jasmine/blob/1_3_x/spec/runner.html

I submitted the jasmine-jsreporter change as a pull request here:

https://github.com/detro/jasmine-jsreporter/pull/2

Fixes #563.
 2013-11-24 00:53:29 -05:00
Sundeep Malladi b7ef221b27 Minor spelling correction in docs 2013-11-22 14:32:53 -06:00
Pete Hunt d51ae6b8bc Merge pull request #575 from spicyj/owner 
Move __owner__ off of props
 2013-11-21 17:44:48 -08:00
Ben Alpert 61abc645e5 Move __owner__ off of props 2013-11-21 17:34:52 -08:00
Ben Newman 2a66c9b089 Merge pull request #586 from benjamn/reinstate-ReactEventEmitter-mocking 
Add back mocking removed to make ReactEventTopLevelCallback-test pass.
 2013-11-21 11:07:57 -08:00
Ben Newman 52d3b47f48 Add back mocking removed to make ReactEventTopLevelCallback-test pass. 
This is a partial reversion of commit 9937f0c8bd.
 2013-11-21 10:57:24 -08:00
Ben Newman 97bbd852b2 Merge pull request #584 from spicyj/mock 
Mock modules properly in test runner.
 2013-11-21 10:31:59 -08:00
Ben Alpert af95b35f27 Have faith in var hoisting 2013-11-21 10:31:20 -08:00
Ben Alpert c7bb3af760 Mock modules properly in test runner 
As an added bonus, the jasmine web interface now groups tests by file.

Test Plan:
grunt test passes on b2507066, the parent of 566f8b2e (which committed a workaround for buggy module mocking).
 2013-11-21 00:39:37 -08:00
Cheng Lou 0a3d0163d0 docs select value to control chosen option 2013-11-20 22:34:53 -05:00
Ben Newman 566f8b2e85 Merge pull request #573 from spicyj/tests 
Make ReactEventTopLevelCallback-test pass
 2013-11-20 16:54:15 -08:00
Paul O’Shannessy b2507066b6 Don't call utils.traverse in transform 
Accidental change we missed in review of #495.
 2013-11-20 15:36:54 -08:00
Christopher Chedeau e73900dad4 Remove rootNode from componentDidMount and componentDidUpdate 
We can already access the DOM node using `this.getDOMNode()`. Passing it as an argument was a bad decision.

Previous API:

```
componentDidMount(DOMElement rootNode)
componentDidUpdate(object prevProps, object prevState, object prevContext, DOMElement rootNode)
```

Next API:

```
componentDidMount()
componentDidUpdate(object prevProps, object prevState, object prevContext)
```
 2013-11-20 14:20:35 -08:00
Christoph Pojer 2fe2cd5337 Ensure ReactPerf always uses a string as a URL 2013-11-20 14:19:13 -08:00
Tim Yung 04c3e2e407 Add nextContext to componentWillReceiveProps 
Add `nextContext` as an argument to `componentWillReceiveProps`. We can figure out what to rename the method to later.
 2013-11-20 14:19:01 -08:00
Christopher Chedeau a23d43bf05 Use this.getDOMNode() instead of last argument of componentDidMount 2013-11-20 14:18:49 -08:00
Marshall Roch 934ef1d4c2 Fix context in callbacks 
callbacks like shouldComponentUpdate, componentDidUpdate, etc. were getting the full, unsanitized context, instead of the one that's been filtered down to only the fields allowed to be visible by contextTypes.
 2013-11-20 14:18:28 -08:00
Christopher Chedeau c8b6fe51d9 Use this.getDOMNode() instead of last argument of componentDidUpdate 
Context is adding another argument that shifts all of them by one. Since we can already use this.getDOMNode(), it doesn't really make sense to pass it as an argument to that function.
 2013-11-20 14:18:07 -08:00