Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove IE8 event.target polyfill via srcElement (#11515)

Browse Source
This commit is contained in:
Dan Abramov
2018-01-05 17:21:33 +00:00
committed by GitHub
parent 43af41be53
commit fe10b8d0cd
5 changed files with 1 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-dom/src/events/__tests__/SyntheticClipboardEvent-test.js
Vendored
-62
View File
@@ -79,68 +79,6 @@ describe('SyntheticClipboardEvent', () => {
});
describe('EventInterface', () => {
it('normalizes properties from the Event interface', () => {
let expectedCount = 0;
let div;
const eventHandler = type => event => {
expect(event.target).toBe(div);
expect(event.type).toBe(type);
expectedCount++;
};
div = ReactDOM.render(
<div
onCopy={eventHandler('copy')}
onCut={eventHandler('cut')}
onPaste={eventHandler('paste')}
/>,
container,
);
let event;
event = document.createEvent('Event');
event.initEvent('copy', true, true);
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
event = document.createEvent('Event');
event.initEvent('cut', true, true);
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
event = document.createEvent('Event');
event.initEvent('paste', true, true);
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
expect(expectedCount).toBe(3);
});
it('is able to `preventDefault` and `stopPropagation`', () => {
let expectedCount = 0;
packages/react-dom/src/events/__tests__/SyntheticEvent-test.js
Vendored
-27
View File
@@ -30,33 +30,6 @@ describe('SyntheticEvent', () => {
container = null;
});
it('should normalize `target` from the nativeEvent', () => {
let node;
let expectedCount = 0;
const eventHandler = syntheticEvent => {
expect(syntheticEvent.target).toBe(node);
expectedCount++;
};
node = ReactDOM.render(<div onClick={eventHandler} />, container);
const event = document.createEvent('Event');
event.initEvent('click', true, true);
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return node;
},
});
node.dispatchEvent(event);
expect(expectedCount).toBe(1);
});
it('should be able to `preventDefault`', () => {
let node;
let expectedCount = 0;
packages/react-dom/src/events/__tests__/SyntheticKeyboardEvent-test.js
Vendored
-70
View File
@@ -454,76 +454,6 @@ describe('SyntheticKeyboardEvent', () => {
});
describe('EventInterface', () => {
it('normalizes properties from the Event interface', () => {
let expectedCount = 0;
let div;
const eventHandler = type => event => {
expect(event.target).toBe(div);
expect(event.type).toBe(type);
expectedCount++;
};
div = ReactDOM.render(
<div
onKeyDown={eventHandler('keydown')}
onKeyPress={eventHandler('keypress')}
onKeyUp={eventHandler('keyup')}
/>,
container,
);
let event;
event = new KeyboardEvent('keydown', {
keyCode: 40,
bubbles: true,
cancelable: true,
});
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
event = new KeyboardEvent('keyup', {
keyCode: 40,
bubbles: true,
cancelable: true,
});
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
event = new KeyboardEvent('keypress', {
charCode: 40,
keyCode: 40,
bubbles: true,
cancelable: true,
});
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return div;
},
});
div.dispatchEvent(event);
expect(expectedCount).toBe(3);
});
it('is able to `preventDefault` and `stopPropagation`', () => {
let expectedCount = 0;
const eventHandler = event => {
packages/react-dom/src/events/__tests__/SyntheticWheelEvent-test.js
Vendored
-27
View File
@@ -29,33 +29,6 @@ describe('SyntheticWheelEvent', () => {
container = null;
});
it('should normalize properties from the Event interface', () => {
const events = [];
const onWheel = event => {
event.persist();
events.push(event);
};
ReactDOM.render(<div onWheel={onWheel} />, container);
const event = new MouseEvent('wheel', {
bubbles: true,
});
// Emulate IE8
Object.defineProperty(event, 'target', {
get() {},
});
Object.defineProperty(event, 'srcElement', {
get() {
return container.firstChild;
},
});
container.firstChild.dispatchEvent(event);
expect(events.length).toBe(1);
expect(events[0].target).toBe(container.firstChild);
expect(events[0].type).toBe('wheel');
});
it('should normalize properties from the MouseEvent interface', () => {
const events = [];
const onWheel = event => {
packages/react-dom/src/events/getEventTarget.js
Vendored
+1 -1
View File
@@ -15,7 +15,7 @@ import {TEXT_NODE} from '../shared/HTMLNodeType';
* @return {DOMEventTarget} Target node.
*/
function getEventTarget(nativeEvent) {
let target = nativeEvent.target || nativeEvent.srcElement || window;
let target = nativeEvent.target || window;
// Normalize SVG <use> element events #4963
if (target.correspondingUseElement) {