Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Transition Tracing] Push Transition When Offscreen Becomes Visible (#24718)

Browse Source 
This PR pushes all of a suspense boundary's transitions onto the transition stack when it goes from hidden to visible so we can pass it to any child suspense boundaries or tracing markers.
This commit is contained in:
Luna Ruan
2022-06-15 11:51:51 -07:00
committed by GitHub
parent 522f47345f
commit fcd720d363
2 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberBeginWork.new.js
+11 -1
View File
@@ -779,7 +779,17 @@ function updateOffscreenComponent(
prevCachePool = prevState.cachePool;
}
pushTransition(workInProgress, prevCachePool, null);
let transitions = null;
if (
workInProgress.memoizedState !== null &&
workInProgress.memoizedState.transitions !== null
) {
// We have now gone from hidden to visible, so any transitions should
// be added to the stack to get added to any Offscreen/suspense children
transitions = workInProgress.memoizedState.transitions;
}
pushTransition(workInProgress, prevCachePool, transitions);
// Since we're not hidden anymore, reset the state
workInProgress.memoizedState = null;
packages/react-reconciler/src/ReactFiberBeginWork.old.js
+11 -1
View File
@@ -779,7 +779,17 @@ function updateOffscreenComponent(
prevCachePool = prevState.cachePool;
}
pushTransition(workInProgress, prevCachePool, null);
let transitions = null;
if (
workInProgress.memoizedState !== null &&
workInProgress.memoizedState.transitions !== null
) {
// We have now gone from hidden to visible, so any transitions should
// be added to the stack to get added to any Offscreen/suspense children
transitions = workInProgress.memoizedState.transitions;
}
pushTransition(workInProgress, prevCachePool, transitions);
// Since we're not hidden anymore, reset the state
workInProgress.memoizedState = null;