Add rootContainerInstance param to createTextInstance.

This mirrors a recent change in params passed to  and cleans up a HACK currently required for the native fiber renderer to create text views.
This commit is contained in:
Brian Vaughn
2016-12-12 10:12:43 -08:00
parent 92665e2cb1
commit f8cb22ad83
5 changed files with 6 additions and 5 deletions
+1 -1
View File
@@ -446,7 +446,7 @@ const ARTRenderer = ReactFiberReconciler({
return instance;
},
createTextInstance(text, internalInstanceHandle) {
createTextInstance(text, rootContainerInstance, internalInstanceHandle) {
return text;
},
+1 -1
View File
@@ -152,7 +152,7 @@ var DOMRenderer = ReactFiberReconciler({
domElement.textContent = '';
},
createTextInstance(text : string, internalInstanceHandle : Object) : TextInstance {
createTextInstance(text : string, rootContainerInstance : Container, internalInstanceHandle : Object) : TextInstance {
var textNode : TextInstance = document.createTextNode(text);
precacheFiberNode(internalInstanceHandle, textNode);
return textNode;
+1 -1
View File
@@ -81,7 +81,7 @@ var NoopRenderer = ReactFiberReconciler({
resetTextContent(instance : Instance) : void {},
createTextInstance(text : string) : TextInstance {
createTextInstance(text : string, rootContainerInstance : Container, internalInstanceHandle : Object) : TextInstance {
var inst = { text : text, id: instanceCounter++ };
// Hide from unit tests
Object.defineProperty(inst, 'id', { value: inst.id, enumerable: false });
@@ -292,7 +292,8 @@ module.exports = function<T, P, I, TI, C, CX>(
return null;
}
}
const textInstance = createTextInstance(newText, workInProgress);
const rootContainerInstance = getRootHostContainer();
const textInstance = createTextInstance(newText, rootContainerInstance, workInProgress);
workInProgress.stateNode = textInstance;
}
workInProgress.memoizedProps = newText;
@@ -54,7 +54,7 @@ export type HostConfig<T, P, I, TI, C, CX> = {
shouldSetTextContent(props : P) : boolean,
resetTextContent(instance : I) : void,
createTextInstance(text : string, internalInstanceHandle : OpaqueNode) : TI,
createTextInstance(text : string, rootContainerInstance : C, internalInstanceHandle : OpaqueNode) : TI,
commitTextUpdate(textInstance : TI, oldText : string, newText : string) : void,
appendChild(parentInstance : I | C, child : I | TI) : void,