Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[react-interactions] Make events non-passive to allow preventDefault (#17136)

Browse Source
This commit is contained in:
Dominic Gannaway
2019-10-21 22:37:27 +02:00
committed by GitHub
parent 1022ee0ec1
commit f7ec65eeba
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-interactions/events/src/dom/PressLegacy.js
Vendored
+11 -4
View File
@@ -114,11 +114,18 @@ const DEFAULT_PRESS_RETENTION_OFFSET = {
};
const targetEventTypes = hasPointerEvents
? ['keydown_active', 'pointerdown', 'click_active']
: ['keydown_active', 'touchstart', 'mousedown', 'click_active'];
? ['keydown_active', 'pointerdown_active', 'click_active']
: ['keydown_active', 'touchstart', 'mousedown_active', 'click_active'];
const rootEventTypes = hasPointerEvents
? ['pointerup', 'pointermove', 'pointercancel', 'click', 'keyup', 'scroll']
? [
'pointerup_active',
'pointermove',
'pointercancel',
'click',
'keyup',
'scroll',
]
: [
'click',
'keyup',
@@ -128,7 +135,7 @@ const rootEventTypes = hasPointerEvents
'touchcancel',
// Used as a 'cancel' signal for mouse interactions
'dragstart',
'mouseup',
'mouseup_active',
'touchend',
];
packages/react-interactions/events/src/dom/__tests__/PressLegacy-test.internal.js
+5 -1
View File
@@ -1134,11 +1134,13 @@ describe.each(environmentTable)('Press responder', hasPointerEvents => {
it('event.preventDefault works as expected', () => {
const onPress = jest.fn(e => e.preventDefault());
const onPressStart = jest.fn(e => e.preventDefault());
const onPressEnd = jest.fn(e => e.preventDefault());
const preventDefault = jest.fn();
const buttonRef = React.createRef();
const Component = () => {
const listener = usePress({onPress});
const listener = usePress({onPress, onPressStart, onPressEnd});
return <button ref={buttonRef} listeners={listener} />;
};
ReactDOM.render(<Component />, container);
@@ -1147,5 +1149,7 @@ describe.each(environmentTable)('Press responder', hasPointerEvents => {
target.pointerdown();
target.pointerup({preventDefault});
expect(preventDefault).toBeCalled();
expect(onPressStart).toBeCalled();
expect(onPressEnd).toBeCalled();
});
});