Add suppressContentEditableWarning

See #5837
This commit is contained in:
Max
2016-02-24 20:41:07 +01:00
parent 308badbc03
commit f7276b304c
2 changed files with 9 additions and 1 deletions
@@ -174,7 +174,9 @@ function assertValidProps(component, props) {
'For more information, lookup documentation on `dangerouslySetInnerHTML`.'
);
warning(
!props.contentEditable || props.children == null,
props.suppressContentEditableWarning ||
!props.contentEditable ||
props.children == null,
'A component is `contentEditable` and contains `children` managed by ' +
'React. It is now your responsibility to guarantee that none of ' +
'those nodes are unexpectedly modified or duplicated. This is ' +
@@ -947,6 +947,12 @@ describe('ReactDOMComponent', function() {
expect(console.error.argsForCall[0][0]).toContain('contentEditable');
});
it('should respect suppressContentEditableWarning', function() {
spyOn(console, 'error');
mountComponent({contentEditable: true, children: '', suppressContentEditableWarning: true});
expect(console.error.argsForCall.length).toBe(0);
});
it('should validate against invalid styles', function() {
expect(function() {
mountComponent({style: 'display: none'});