Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only define MyElement when needed (#11069)

Browse Source
This commit is contained in:
Brandon Dail
2017-10-03 10:23:59 -07:00
committed by GitHub
parent 589c0a25df
commit f6a79d1f16
1 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fixtures/dom/src/components/fixtures/custom-elements/index.js
+16 -17
View File
@@ -12,24 +12,23 @@ class HelloWorld extends React.Component {
}
}
// Babel breaks web components.
// https://github.com/w3c/webcomponents/issues/587
// eslint-disable-next-line no-new-func
const MyElement = new Function(
'React',
'ReactDOM',
'HelloWorld',
`
return class MyElement extends HTMLElement {
constructor() {
super();
const shadowRoot = this.attachShadow({ mode:'open' });
ReactDOM.render(React.createElement(HelloWorld), shadowRoot);
}
}`
)(React, ReactDOM, HelloWorld);
if (supportsCustomElements) {
// Babel breaks web components.
// https://github.com/w3c/webcomponents/issues/587
// eslint-disable-next-line no-new-func
const MyElement = new Function(
'React',
'ReactDOM',
'HelloWorld',
`
return class MyElement extends HTMLElement {
constructor() {
super();
const shadowRoot = this.attachShadow({ mode:'open' });
ReactDOM.render(React.createElement(HelloWorld), shadowRoot);
}
}`
)(React, ReactDOM, HelloWorld);
customElements.define('my-element', MyElement);
}