Fix for destructuring with partial context variables

compiler/packages/babel-plugin-react-forget/src/HIR/BuildHIR.ts

@@ -3434,7 +3434,12 @@ function lowerAssignment(
        */
       const forceTemporaries =
         kind === InstructionKind.Reassign &&
-        elements.some((element) => !element.isIdentifier());
+        (elements.some((element) => !element.isIdentifier()) ||
+          elements.some(
+            (element) =>
+              element.isIdentifier() &&
+              getStoreKind(builder, element) !== "StoreLocal"
+          ));
       for (let i = 0; i < elements.length; i++) {
         const element = elements[i];
         if (element.node == null) {

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/error.todo-incompatible-destructuring-kinds.expect.md

@@ -1,35 +0,0 @@
-
-## Input
-
-```javascript
-import { useMemo } from "react";
-import { Stringify } from "shared-runtime";
-
-function Component({}) {
-  let a = "a";
-  let b = "";
-  [a, b] = [null, null];
-  return <Stringify a={a} b={b} onClick={() => a} />;
-}
-
-export const FIXTURE_ENTRYPOINT = {
-  fn: Component,
-  params: [{}],
-};
-
-```
-
-
-## Error
-
-```
-   5 |   let a = "a";
-   6 |   let b = "";
->  7 |   [a, b] = [null, null];
-     |       ^ [ReactForget] Invariant: Expected consistent kind for destructuring. Other places were 'Const' but 'store b$36[10:12]' is reassigned (7:7)
-   8 |   return <Stringify a={a} b={b} onClick={() => a} />;
-   9 | }
-  10 |
-```
-          
-      

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/incompatible-destructuring-kinds.expect.md

@@ -0,0 +1,67 @@
+
+## Input
+
+```javascript
+import { useMemo } from "react";
+import { Stringify } from "shared-runtime";
+
+function Component({}) {
+  let a = "a";
+  let b = "";
+  [a, b] = [null, null];
+  // NOTE: reference `a` in a callback to force a context variable
+  return <Stringify a={a} b={b} onClick={() => a} />;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{}],
+};
+
+```
+
+## Code
+
+```javascript
+import { useMemo, unstable_useMemoCache as useMemoCache } from "react";
+import { Stringify } from "shared-runtime";
+
+function Component(t0) {
+  const $ = useMemoCache(4);
+  let t1;
+  let a;
+  let b;
+  if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
+    a = "a";
+
+    const [t2, t3] = [null, null];
+    t1 = t3;
+    a = t2;
+    $[0] = t1;
+    $[1] = a;
+    $[2] = b;
+  } else {
+    t1 = $[0];
+    a = $[1];
+    b = $[2];
+  }
+  b = t1;
+  let t2;
+  if ($[3] === Symbol.for("react.memo_cache_sentinel")) {
+    t2 = <Stringify a={a} b={b} onClick={() => a} />;
+    $[3] = t2;
+  } else {
+    t2 = $[3];
+  }
+  return t2;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Component,
+  params: [{}],
+};
+
+```
+      
+### Eval output
+(kind: ok) <div>{"a":null,"b":"[[ cyclic ref *1 ]]","onClick":"[[ function params=0 ]]"}</div>

compiler/packages/babel-plugin-react-forget/src/__tests__/fixtures/compiler/incompatible-destructuring-kinds.js

@@ -5,6 +5,7 @@ function Component({}) {
   let a = "a";
   let b = "";
   [a, b] = [null, null];
+  // NOTE: reference `a` in a callback to force a context variable
   return <Stringify a={a} b={b} onClick={() => a} />;
 }