Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[react-events] Keyboard: fix callback return types (#16693)

Browse Source
This commit is contained in:
Nicolas Gallagher
2019-09-09 09:07:42 -07:00
committed by GitHub
parent 9444c876d5
commit f26fe8c0a7
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-events/src/dom/Keyboard.js
Vendored
+7 -5
View File
@@ -20,8 +20,8 @@ type KeyboardEventType = 'keydown' | 'keyup';
type KeyboardProps = {
disabled: boolean,
onKeyDown: (e: KeyboardEvent) => void,
onKeyUp: (e: KeyboardEvent) => void,
onKeyDown: (e: KeyboardEvent) => ?boolean,
onKeyUp: (e: KeyboardEvent) => ?boolean,
preventKeys: Array<string>,
};
@@ -162,7 +162,7 @@ function createKeyboardEvent(
function dispatchKeyboardEvent(
event: ReactDOMResponderEvent,
listener: KeyboardEvent => void,
listener: KeyboardEvent => ?boolean,
context: ReactDOMResponderContext,
type: KeyboardEventType,
defaultPrevented: boolean,
@@ -209,9 +209,11 @@ const keyboardResponderImpl = {
const config = ((preventKey[1]: any): Object);
for (let s = 0; s < modifiers.length; s++) {
const modifier = modifiers[s];
const configModifier = config[modifier];
const eventModifier = nativeEvent[modifier];
if (
(config[modifier] && !nativeEvent[modifier]) ||
(!config[modifier] && nativeEvent[modifier])
(configModifier && !eventModifier) ||
(!configModifier && eventModifier)
) {
continue preventKeyLoop;
}