Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Performance: avoid triggering map deopt in V8 (#28569)

Browse Source 
The shape of the objects changed by this PR are both created in 2
locations with 2 different shapes, which most JS engines won't like.
I've noticed this in particular in V8 while benchmarking production
code.

https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberCacheComponent.js#L66-L77

https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHostContext.js#L47-L54

https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3530-L3531

https://github.com/facebook/react/blob/1293047d6063f3508af15e68cca916660ded791e/packages/react-reconciler/src/ReactFiberHooks.js#L3492-L3493

DiffTrain build for commit https://github.com/facebook/react/commit/4d686a2da138cad9e76c7de9feadd81ca2aa29e5.
This commit is contained in:
kassens
2024-03-18 15:58:15 +00:00
parent fbba8d45e4
commit f0775f378f
13 changed files with 64 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
Vendored
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<a3b83de91596e95a8c9484b94ff6b74c>>
* @generated SignedSource<<65b88d386b80bb668ee1220244f5891b>>
*/
"use strict";
@@ -2570,11 +2570,11 @@ if (__DEV__) {
var HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function requiredContext(c) {
@@ -9616,8 +9616,8 @@ if (__DEV__) {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -25454,7 +25454,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-canary-45d56071b-20240318";
var ReactVersion = "18.3.0-canary-4d686a2da-20240318";
// Might add PROFILE later.
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
Vendored
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<f286949b9793004b5a064c2aeef09640>>
* @generated SignedSource<<b8f1ce1ab15d9e71ef26da594ea2a0c5>>
*/
"use strict";
@@ -663,11 +663,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -3109,8 +3109,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -9175,7 +9175,7 @@ var devToolsConfig$jscomp$inline_1016 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-45d56071b-20240318",
version: "18.3.0-canary-4d686a2da-20240318",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1194 = {
@@ -9206,7 +9206,7 @@ var internals$jscomp$inline_1194 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-45d56071b-20240318"
reconcilerVersion: "18.3.0-canary-4d686a2da-20240318"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1195 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
Vendored
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<e7f6aa2c01048ac2a1b605aae48eb66a>>
* @generated SignedSource<<6adce1bb96c74af6db54e6a23f64cd73>>
*/
"use strict";
@@ -681,11 +681,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -3129,8 +3129,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -9603,7 +9603,7 @@ var devToolsConfig$jscomp$inline_1058 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-45d56071b-20240318",
version: "18.3.0-canary-4d686a2da-20240318",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1235 = {
@@ -9634,7 +9634,7 @@ var internals$jscomp$inline_1235 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-45d56071b-20240318"
reconcilerVersion: "18.3.0-canary-4d686a2da-20240318"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js
Vendored
+1 -1
View File
@@ -26,7 +26,7 @@ if (__DEV__) {
}
var dynamicFlags = require("ReactNativeInternalFeatureFlags");
var ReactVersion = "18.3.0-canary-45d56071b-20240318";
var ReactVersion = "18.3.0-canary-4d686a2da-20240318";
// ATTENTION
// When adding new symbols to this file,
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js
Vendored
+1 -1
View File
@@ -628,4 +628,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-45d56071b-20240318";
exports.version = "18.3.0-canary-4d686a2da-20240318";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js
Vendored
+1 -1
View File
@@ -624,7 +624,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-45d56071b-20240318";
exports.version = "18.3.0-canary-4d686a2da-20240318";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
45d56071b8ce1dbccf1765acf3867263fe3e595b
4d686a2da138cad9e76c7de9feadd81ca2aa29e5
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<48c206274b16ddb872dd142a6fc17769>>
* @generated SignedSource<<e0529a44eea2a06c29b44e0f6f3094ea>>
*/
"use strict";
@@ -6050,11 +6050,11 @@ to return true:wantsResponderID| |
var HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function requiredContext(c) {
@@ -13570,8 +13570,8 @@ to return true:wantsResponderID| |
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -29801,7 +29801,7 @@ to return true:wantsResponderID| |
return root;
}
var ReactVersion = "18.3.0-canary-01f0d8b1";
var ReactVersion = "18.3.0-canary-dcb437de";
function createPortal$1(
children,
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<f468fcfeadb843d99ac63af6cde06553>>
* @generated SignedSource<<bad8dcf29728fb2c7ec3ee84033aabb1>>
*/
"use strict";
@@ -2001,11 +2001,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -4724,8 +4724,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -10626,7 +10626,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1103 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-canary-8f98d002",
version: "18.3.0-canary-45ebe421",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10669,7 +10669,7 @@ var internals$jscomp$inline_1330 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-8f98d002"
reconcilerVersion: "18.3.0-canary-45ebe421"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1331 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<6c9f7fe03ad0703b972eef9473b57c69>>
* @generated SignedSource<<26c28bc563c475bc48b8350e745dfaa4>>
*/
"use strict";
@@ -2123,11 +2123,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -4851,8 +4851,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -11332,7 +11332,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1184 = {
findFiberByHostInstance: getInstanceFromNode,
bundleType: 0,
version: "18.3.0-canary-e8e1a13c",
version: "18.3.0-canary-154313d4",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11388,7 +11388,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-e8e1a13c"
reconcilerVersion: "18.3.0-canary-154313d4"
});
exports.createPortal = function (children, containerTag) {
return createPortal$1(
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
+6 -6
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<51a07e08c2e142d6d820d76841b5f546>>
* @generated SignedSource<<961c930d323670120a1ce352e0cf2d5c>>
*/
"use strict";
@@ -6345,11 +6345,11 @@ to return true:wantsResponderID| |
var HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function requiredContext(c) {
@@ -13841,8 +13841,8 @@ to return true:wantsResponderID| |
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -30241,7 +30241,7 @@ to return true:wantsResponderID| |
return root;
}
var ReactVersion = "18.3.0-canary-1330e5ea";
var ReactVersion = "18.3.0-canary-2c537ce9";
function createPortal$1(
children,
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<bc43046bc42eaf317b7aeaf37a3f6972>>
* @generated SignedSource<<1220d516fcec3101959c6d1fd5cbc8c0>>
*/
"use strict";
@@ -2075,11 +2075,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -4790,8 +4790,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -10843,7 +10843,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1172 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-canary-b9c95560",
version: "18.3.0-canary-ca090109",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10886,7 +10886,7 @@ var internals$jscomp$inline_1413 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-b9c95560"
reconcilerVersion: "18.3.0-canary-ca090109"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1414 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
+7 -7
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<4c2fc2a3edb92cc2791566659afae3c1>>
* @generated SignedSource<<0ba22ea61c0329ae1b586a36af00af49>>
*/
"use strict";
@@ -2197,11 +2197,11 @@ var objectIs = "function" === typeof Object.is ? Object.is : is,
hostTransitionProviderCursor = createCursor(null),
HostTransitionContext = {
$$typeof: REACT_CONTEXT_TYPE,
Provider: null,
Consumer: null,
_currentValue: null,
_currentValue2: null,
_threadCount: 0,
Provider: null,
Consumer: null
_threadCount: 0
};
function pushHostContainer(fiber, nextRootInstance) {
push(rootInstanceStackCursor, nextRootInstance);
@@ -4917,8 +4917,8 @@ var ContextOnlyDispatcher = {
useContext: throwInvalidHookError,
useEffect: throwInvalidHookError,
useImperativeHandle: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useLayoutEffect: throwInvalidHookError,
useInsertionEffect: throwInvalidHookError,
useMemo: throwInvalidHookError,
useReducer: throwInvalidHookError,
useRef: throwInvalidHookError,
@@ -11550,7 +11550,7 @@ var roots = new Map(),
devToolsConfig$jscomp$inline_1253 = {
findFiberByHostInstance: getInstanceFromTag,
bundleType: 0,
version: "18.3.0-canary-591d8411",
version: "18.3.0-canary-e8ed23e9",
rendererPackageName: "react-native-renderer",
rendererConfig: {
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11606,7 +11606,7 @@ var roots = new Map(),
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-591d8411"
reconcilerVersion: "18.3.0-canary-e8ed23e9"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
computeComponentStackForErrorReporting: function (reactTag) {