mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
change destroy to safelyCallDestroy (#19605)
We use safelyCallDestroy for commitUnmount and passive effects unmounts but we call destroy directly in commitHookEffectListUnmount (AKA layout effects unmounts because we don't use this anywhere else). This PR changes the direct destroy call to safelyCallDestroy for consistency
This commit is contained in:
@@ -335,7 +335,7 @@ function commitHookEffectListUnmount(tag: HookEffectTag, finishedWork: Fiber) {
|
||||
const destroy = effect.destroy;
|
||||
effect.destroy = undefined;
|
||||
if (destroy !== undefined) {
|
||||
destroy();
|
||||
safelyCallDestroy(finishedWork, destroy);
|
||||
}
|
||||
}
|
||||
effect = effect.next;
|
||||
|
||||
Reference in New Issue
Block a user