Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup enableProfilerNestedUpdateScheduledHook feature flag (#28509)

Browse Source 
## Summary

Looks like this was added years ago for instrumentation at meta that
never ended up rolling out. Should be safe to clean up.

## How did you test this change?
`yarn test`

DiffTrain build for [0d1ae5d753](https://github.com/facebook/react/commit/0d1ae5d753044fae99bc37a7815aa947447de3f8)
This commit is contained in:
noahlemen
2024-03-11 15:41:11 +00:00
parent 8506f82a4b
commit eaaebddcb7
12 changed files with 54 additions and 344 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled/facebook-www/REVISION
+1 -1
View File
@@ -1 +1 @@
64f354cf27a17c4e5b0dfcd908e47940cf947771
0d1ae5d753044fae99bc37a7815aa947447de3f8
compiled/facebook-www/React-prod.classic.js
+1 -1
View File
@@ -633,4 +633,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-www-classic-8c94b449";
exports.version = "18.3.0-www-classic-0d16943c";
compiled/facebook-www/ReactART-dev.classic.js
+2 -43
View File
@@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}
var ReactVersion = "18.3.0-www-classic-81c495cd";
var ReactVersion = "18.3.0-www-classic-db11990b";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -194,8 +194,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -25344,10 +25342,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -25543,32 +25538,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig.transition;
@@ -27548,12 +27517,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -27585,10 +27548,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
compiled/facebook-www/ReactART-dev.modern.js
+2 -43
View File
@@ -66,7 +66,7 @@ if (__DEV__) {
return self;
}
var ReactVersion = "18.3.0-www-modern-c4d09ac8";
var ReactVersion = "18.3.0-www-modern-d1dd2d63";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -194,8 +194,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler;
@@ -25003,10 +25001,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -25202,32 +25197,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig.transition;
@@ -27198,12 +27167,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -27235,10 +27198,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
compiled/facebook-www/ReactDOM-dev.classic.js
+2 -43
View File
@@ -160,8 +160,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableFormActions = true;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
@@ -31163,10 +31161,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -31362,32 +31357,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
@@ -33429,12 +33398,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -33474,10 +33437,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
@@ -36034,7 +35993,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-3e5b27d2";
var ReactVersion = "18.3.0-www-classic-26a9fc54";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-dev.modern.js
+2 -43
View File
@@ -155,8 +155,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableFormActions = true;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
@@ -31019,10 +31017,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -31218,32 +31213,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
@@ -33276,12 +33245,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -33321,10 +33284,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
@@ -35881,7 +35840,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-b7723bc0";
var ReactVersion = "18.3.0-www-modern-9c67d6cd";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-profiling.classic.js
+17 -39
View File
@@ -70,8 +70,6 @@ var ReactSharedInternals =
enableRefAsProp = dynamicFeatureFlags.enableRefAsProp,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook,
enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler,
REACT_ELEMENT_TYPE = Symbol.for("react.element"),
REACT_PORTAL_TYPE = Symbol.for("react.portal"),
@@ -10867,7 +10865,6 @@ function addTransitionProgressCallbackToPendingTransition(
var hasUncaughtError = !1,
firstUncaughtError = null,
legacyErrorBoundariesThatAlreadyFailed = null,
rootCommittingMutationOrLayoutEffects = null,
rootDoesHavePassiveEffects = !1,
rootWithPendingPassiveEffects = null,
pendingPassiveEffectsLanes = 0,
@@ -10915,36 +10912,21 @@ function scheduleUpdateOnFiber(root, fiber, lane) {
markRootUpdated(root, lane);
if (0 === (executionContext & 2) || root !== workInProgressRoot) {
isDevToolsPresent && addFiberToLanesMap(root, fiber, lane);
if (
enableProfilerNestedUpdateScheduledHook &&
0 !== (executionContext & 4) &&
root === rootCommittingMutationOrLayoutEffects &&
fiber.mode & 2
)
for (var current = fiber; null !== current; ) {
if (12 === current.tag) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id;
_current$memoizedProp = _current$memoizedProp.onNestedUpdateScheduled;
"function" === typeof _current$memoizedProp &&
_current$memoizedProp(id);
}
current = current.return;
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
if (
null !== transition &&
null != transition.name &&
(-1 === transition.startTime && (transition.startTime = now$1()),
enableTransitionTracing)
) {
var transitionLanesMap = root.transitionLanes,
index$11 = 31 - clz32(lane),
transitions = transitionLanesMap[index$11];
null === transitions && (transitions = new Set());
transitions.add(transition);
transitionLanesMap[index$11] = transitions;
}
if (
enableTransitionTracing &&
((current = ReactCurrentBatchConfig$1.transition),
null !== current &&
null != current.name &&
(-1 === current.startTime && (current.startTime = now$1()),
enableTransitionTracing))
) {
id = root.transitionLanes;
_current$memoizedProp = 31 - clz32(lane);
var transitions = id[_current$memoizedProp];
null === transitions && (transitions = new Set());
transitions.add(current);
id[_current$memoizedProp] = transitions;
}
root === workInProgressRoot &&
(0 === (executionContext & 2) &&
@@ -11827,8 +11809,6 @@ function commitRootImpl(
finishedWork
);
commitTime = now();
enableProfilerNestedUpdateScheduledHook &&
(rootCommittingMutationOrLayoutEffects = root);
commitMutationEffects(root, finishedWork, lanes);
shouldFireAfterActiveInstanceBlur$208 &&
((_enabled = !0),
@@ -11849,8 +11829,6 @@ function commitRootImpl(
null !== injectedProfilingHooks &&
"function" === typeof injectedProfilingHooks.markLayoutEffectsStopped &&
injectedProfilingHooks.markLayoutEffectsStopped();
enableProfilerNestedUpdateScheduledHook &&
(rootCommittingMutationOrLayoutEffects = null);
requestPaint();
executionContext = prevExecutionContext;
currentUpdatePriority = spawnedLane;
@@ -18006,7 +17984,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1907 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-f40ff6ee",
version: "18.3.0-www-classic-819e0a71",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -18050,7 +18028,7 @@ var devToolsConfig$jscomp$inline_1907 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-f40ff6ee"
reconcilerVersion: "18.3.0-www-classic-819e0a71"
});
assign(Internals, {
ReactBrowserEventEmitter: {
@@ -18368,7 +18346,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
};
exports.version = "18.3.0-www-classic-f40ff6ee";
exports.version = "18.3.0-www-classic-819e0a71";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled/facebook-www/ReactDOM-profiling.modern.js
+17 -39
View File
@@ -83,8 +83,6 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
enableRefAsProp = dynamicFeatureFlags.enableRefAsProp,
enableClientRenderFallbackOnTextMismatch =
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook,
enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler,
assign = Object.assign,
ReactSharedInternals =
@@ -10698,7 +10696,6 @@ function addTransitionProgressCallbackToPendingTransition(
var hasUncaughtError = !1,
firstUncaughtError = null,
legacyErrorBoundariesThatAlreadyFailed = null,
rootCommittingMutationOrLayoutEffects = null,
rootDoesHavePassiveEffects = !1,
rootWithPendingPassiveEffects = null,
pendingPassiveEffectsLanes = 0,
@@ -10746,36 +10743,21 @@ function scheduleUpdateOnFiber(root, fiber, lane) {
markRootUpdated(root, lane);
if (0 === (executionContext & 2) || root !== workInProgressRoot) {
isDevToolsPresent && addFiberToLanesMap(root, fiber, lane);
if (
enableProfilerNestedUpdateScheduledHook &&
0 !== (executionContext & 4) &&
root === rootCommittingMutationOrLayoutEffects &&
fiber.mode & 2
)
for (var current = fiber; null !== current; ) {
if (12 === current.tag) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id;
_current$memoizedProp = _current$memoizedProp.onNestedUpdateScheduled;
"function" === typeof _current$memoizedProp &&
_current$memoizedProp(id);
}
current = current.return;
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
if (
null !== transition &&
null != transition.name &&
(-1 === transition.startTime && (transition.startTime = now$1()),
enableTransitionTracing)
) {
var transitionLanesMap = root.transitionLanes,
index$9 = 31 - clz32(lane),
transitions = transitionLanesMap[index$9];
null === transitions && (transitions = new Set());
transitions.add(transition);
transitionLanesMap[index$9] = transitions;
}
if (
enableTransitionTracing &&
((current = ReactCurrentBatchConfig$1.transition),
null !== current &&
null != current.name &&
(-1 === current.startTime && (current.startTime = now$1()),
enableTransitionTracing))
) {
id = root.transitionLanes;
_current$memoizedProp = 31 - clz32(lane);
var transitions = id[_current$memoizedProp];
null === transitions && (transitions = new Set());
transitions.add(current);
id[_current$memoizedProp] = transitions;
}
root === workInProgressRoot &&
(0 === (executionContext & 2) &&
@@ -11654,8 +11636,6 @@ function commitRootImpl(
finishedWork
);
commitTime = now();
enableProfilerNestedUpdateScheduledHook &&
(rootCommittingMutationOrLayoutEffects = root);
commitMutationEffects(root, finishedWork, lanes);
shouldFireAfterActiveInstanceBlur$207 &&
((_enabled = !0),
@@ -11676,8 +11656,6 @@ function commitRootImpl(
null !== injectedProfilingHooks &&
"function" === typeof injectedProfilingHooks.markLayoutEffectsStopped &&
injectedProfilingHooks.markLayoutEffectsStopped();
enableProfilerNestedUpdateScheduledHook &&
(rootCommittingMutationOrLayoutEffects = null);
requestPaint();
executionContext = prevExecutionContext;
currentUpdatePriority = spawnedLane;
@@ -17516,7 +17494,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1866 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-c4d09ac8",
version: "18.3.0-www-modern-d1dd2d63",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -17561,7 +17539,7 @@ var devToolsConfig$jscomp$inline_1866 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-c4d09ac8"
reconcilerVersion: "18.3.0-www-modern-d1dd2d63"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
@@ -17807,7 +17785,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactCurrentDispatcher$2.current.useHostTransitionStatus();
};
exports.version = "18.3.0-www-modern-c4d09ac8";
exports.version = "18.3.0-www-modern-d1dd2d63";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled/facebook-www/ReactDOMTesting-dev.classic.js
+2 -43
View File
@@ -152,8 +152,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableFormActions = true;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
@@ -31787,10 +31785,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -31986,32 +31981,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
@@ -34053,12 +34022,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -34098,10 +34061,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
@@ -36658,7 +36617,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-8c94b449";
var ReactVersion = "18.3.0-www-classic-0d16943c";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-dev.modern.js
+2 -43
View File
@@ -147,8 +147,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var enableProfilerNestedUpdateScheduledHook =
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
var enableFormActions = true;
var enableAsyncActions = true; // Logs additional User Timing API marks for use with an experimental profiling tool.
@@ -31643,10 +31641,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
// to track which root is currently committing layout effects.
var rootCommittingMutationOrLayoutEffects = null;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -31842,32 +31837,6 @@ if (__DEV__) {
warnIfUpdatesNotWrappedWithActDEV(fiber);
if (enableProfilerNestedUpdateScheduledHook) {
if (
(executionContext & CommitContext) !== NoContext &&
root === rootCommittingMutationOrLayoutEffects
) {
if (fiber.mode & ProfileMode) {
var current = fiber;
while (current !== null) {
if (current.tag === Profiler) {
var _current$memoizedProp = current.memoizedProps,
id = _current$memoizedProp.id,
onNestedUpdateScheduled =
_current$memoizedProp.onNestedUpdateScheduled;
if (typeof onNestedUpdateScheduled === "function") {
onNestedUpdateScheduled(id);
}
}
current = current.return;
}
}
}
}
if (enableTransitionTracing) {
var transition = ReactCurrentBatchConfig$1.transition;
@@ -33900,12 +33869,6 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
if (enableProfilerNestedUpdateScheduledHook) {
// Track the root here, rather than in commitLayoutEffects(), because of ref setters.
// Updates scheduled during ref detachment should also be flagged.
rootCommittingMutationOrLayoutEffects = root;
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork, lanes);
@@ -33945,10 +33908,6 @@ if (__DEV__) {
if (enableSchedulingProfiler) {
markLayoutEffectsStopped();
}
if (enableProfilerNestedUpdateScheduledHook) {
rootCommittingMutationOrLayoutEffects = null;
} // Tell Scheduler to yield at the end of the frame, so the browser has an
// opportunity to paint.
@@ -36505,7 +36464,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-684de21c";
var ReactVersion = "18.3.0-www-modern-396ecb0a";
function createPortal$1(
children,
compiled/facebook-www/ReactTestRenderer-dev.classic.js
+3 -3
View File
@@ -21991,7 +21991,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -24004,7 +24004,7 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork);
// the mutation phase, so that the previous tree is still current during
@@ -26105,7 +26105,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-classic-0d3fa4a8";
var ReactVersion = "18.3.0-www-classic-e84830b7";
// Might add PROFILE later.
compiled/facebook-www/ReactTestRenderer-dev.modern.js
+3 -3
View File
@@ -21991,7 +21991,7 @@ if (__DEV__) {
}
var hasUncaughtError = false;
var firstUncaughtError = null;
var legacyErrorBoundariesThatAlreadyFailed = null; // Only used when enableProfilerNestedUpdateScheduledHook is true;
var legacyErrorBoundariesThatAlreadyFailed = null;
var rootDoesHavePassiveEffects = false;
var rootWithPendingPassiveEffects = null;
var pendingPassiveEffectsLanes = NoLanes;
@@ -24004,7 +24004,7 @@ if (__DEV__) {
// Mark the current commit time to be shared by all Profilers in this
// batch. This enables them to be grouped later.
recordCommitTime();
}
} // The next phase is the mutation phase, where we mutate the host tree.
commitMutationEffects(root, finishedWork);
// the mutation phase, so that the previous tree is still current during
@@ -26105,7 +26105,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-www-modern-625f3aa8";
var ReactVersion = "18.3.0-www-modern-a4b882bd";
// Might add PROFILE later.