Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove createRootStrictEffectsByDefault flag (#28102)

Browse Source 
There's no need to separate strict mode from strict effects mode any
more.

I didn't clean up the `StrictEffectMode` fiber flag, because it's used
to prevent strict effects in legacy mode. I could replace those checks
with `LegacyMode` checks, but when we remove legacy mode, we can remove
that flag and condense them into one StrictMode flag away.

DiffTrain build for commit https://github.com/facebook/react/commit/3d1da1f9ab7d54984c096e6a04c8729f3a50fd8a.
This commit is contained in:
rickhanlonii
2024-02-01 19:59:01 +00:00
parent e12f0de391
commit ea5df469a7
9 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js
Vendored
+3 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<bd897fcea644b2a95f4293822e1f08be>>
* @generated SignedSource<<fdc597b6fd2e169218abbcc3fbb6bc8c>>
*/
"use strict";
@@ -142,7 +142,6 @@ if (__DEV__) {
var enableProfilerTimer = true;
var enableProfilerCommitHooks = true;
var enableProfilerNestedUpdatePhase = true;
var createRootStrictEffectsByDefault = false;
var syncLaneExpirationMs = 250;
var transitionLaneExpirationMs = 5000;
var enableLazyContextPropagation = false;
@@ -25204,7 +25203,7 @@ if (__DEV__) {
if (tag === ConcurrentRoot) {
mode = ConcurrentMode;
if (isStrictMode === true || createRootStrictEffectsByDefault) {
if (isStrictMode === true) {
mode |= StrictLegacyMode | StrictEffectsMode;
}
@@ -25623,7 +25622,7 @@ if (__DEV__) {
return root;
}
var ReactVersion = "18.3.0-canary-4dd475c97-20240201";
var ReactVersion = "18.3.0-canary-3d1da1f9a-20240201";
// Might add PROFILE later.
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js
Vendored
+2 -2
View File
@@ -9149,7 +9149,7 @@ var devToolsConfig$jscomp$inline_1031 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-4dd475c97-20240201",
version: "18.3.0-canary-3d1da1f9a-20240201",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1207 = {
@@ -9180,7 +9180,7 @@ var internals$jscomp$inline_1207 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-4dd475c97-20240201"
reconcilerVersion: "18.3.0-canary-3d1da1f9a-20240201"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1208 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js
Vendored
+2 -2
View File
@@ -9577,7 +9577,7 @@ var devToolsConfig$jscomp$inline_1073 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-4dd475c97-20240201",
version: "18.3.0-canary-3d1da1f9a-20240201",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1248 = {
@@ -9608,7 +9608,7 @@ var internals$jscomp$inline_1248 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-4dd475c97-20240201"
reconcilerVersion: "18.3.0-canary-3d1da1f9a-20240201"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1249 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js
Vendored
+1 -1
View File
@@ -24,7 +24,7 @@ if (__DEV__) {
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var ReactVersion = "18.3.0-canary-4dd475c97-20240201";
var ReactVersion = "18.3.0-canary-3d1da1f9a-20240201";
// ATTENTION
// When adding new symbols to this file,
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js
Vendored
+1 -1
View File
@@ -545,4 +545,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-4dd475c97-20240201";
exports.version = "18.3.0-canary-3d1da1f9a-20240201";
compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js
Vendored
+1 -1
View File
@@ -541,7 +541,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-4dd475c97-20240201";
exports.version = "18.3.0-canary-3d1da1f9a-20240201";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
+1 -1
View File
@@ -1 +1 @@
4dd475c97799f3fb83bdd2fff2d028e0e30041cf
3d1da1f9ab7d54984c096e6a04c8729f3a50fd8a
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
+3 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<b9de33ad77303e612467451dba484b4f>>
* @generated SignedSource<<23d1b7cce95eeba5b7251f184412d23c>>
*/
"use strict";
@@ -3247,7 +3247,6 @@ to return true:wantsResponderID| |
var enableProfilerNestedUpdatePhase = true;
var syncLaneExpirationMs = 250;
var transitionLaneExpirationMs = 5000;
var createRootStrictEffectsByDefault = false;
var enableLazyContextPropagation = false;
var enableAsyncActions = false;
@@ -27378,7 +27377,7 @@ to return true:wantsResponderID| |
if (tag === ConcurrentRoot) {
mode = ConcurrentMode;
if (isStrictMode === true || createRootStrictEffectsByDefault) {
if (isStrictMode === true) {
mode |= StrictLegacyMode | StrictEffectsMode;
}
@@ -27856,7 +27855,7 @@ to return true:wantsResponderID| |
return root;
}
var ReactVersion = "18.3.0-canary-a4243e8c";
var ReactVersion = "18.3.0-canary-e1f5390e";
function createPortal$1(
children,
compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
+3 -4
View File
@@ -7,7 +7,7 @@
* @noflow
* @nolint
* @preventMunge
* @generated SignedSource<<ba7079d4e2b3c30850f1187f2cda38c9>>
* @generated SignedSource<<901a1526ca77447e4134b09fdc38f5d6>>
*/
"use strict";
@@ -2955,7 +2955,6 @@ to return true:wantsResponderID| |
var enableProfilerNestedUpdatePhase = true;
var syncLaneExpirationMs = 250;
var transitionLaneExpirationMs = 5000;
var createRootStrictEffectsByDefault = false;
var enableLazyContextPropagation = false;
var enableAsyncActions = false;
@@ -27819,7 +27818,7 @@ to return true:wantsResponderID| |
if (tag === ConcurrentRoot) {
mode = ConcurrentMode;
if (isStrictMode === true || createRootStrictEffectsByDefault) {
if (isStrictMode === true) {
mode |= StrictLegacyMode | StrictEffectsMode;
}
@@ -28297,7 +28296,7 @@ to return true:wantsResponderID| |
return root;
}
var ReactVersion = "18.3.0-canary-a490d791";
var ReactVersion = "18.3.0-canary-4393a1cb";
function createPortal$1(
children,