Renamed nativeHookIndex -> index

This commit is contained in:
Brian Vaughn
2019-02-21 08:59:46 -08:00
parent 8cd8b29015
commit e35819e68d
5 changed files with 14 additions and 14 deletions
+4 -4
View File
@@ -225,7 +225,7 @@ type ReactCurrentDispatcher = {
};
type HooksNode = {
nativeHookIndex: number,
index: number,
name: string,
value: mixed,
subHooks: Array<HooksNode>,
@@ -367,7 +367,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
const rootChildren = [];
let prevStack = null;
let levelChildren = rootChildren;
let nativeHookIndex = 0;
let index = 0;
const stackOfChildren = [];
for (let i = 0; i < readHookLog.length; i++) {
const hook = readHookLog[i];
@@ -401,7 +401,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
levelChildren.push({
name: parseCustomHookName(stack[j - 1].functionName),
value: undefined,
nativeHookIndex: -1,
index: -1,
subHooks: children,
});
stackOfChildren.push(levelChildren);
@@ -412,7 +412,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
levelChildren.push({
name: hook.primitive,
value: hook.value,
nativeHookIndex: hook.primitive === 'DebugValue' ? -1 : nativeHookIndex++,
index: hook.primitive === 'DebugValue' ? -1 : index++,
subHooks: [],
});
}
+3 -3
View File
@@ -25,7 +25,7 @@ type InspectSelectParams = {|
type OverrideHookParams = {|
id: number,
nativeHookIndex: number,
index: number,
path: Array<string | number>,
rendererID: number,
value: any,
@@ -133,7 +133,7 @@ export default class Agent extends EventEmitter {
overrideHook = ({
id,
nativeHookIndex,
index,
path,
rendererID,
value,
@@ -142,7 +142,7 @@ export default class Agent extends EventEmitter {
if (renderer == null) {
console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`);
} else {
renderer.setInHook(id, nativeHookIndex, path, value);
renderer.setInHook(id, index, path, value);
}
};
+2 -2
View File
@@ -1168,14 +1168,14 @@ export function attach(
function setInHook(
id: number,
nativeHookIndex: number,
index: number,
path: Array<string | number>,
value: any
) {
const fiber = findCurrentFiberUsingSlowPath(idToFiberMap.get(id));
if (fiber !== null) {
if (typeof overrideHook === 'function') {
overrideHook(fiber, nativeHookIndex, path, value);
overrideHook(fiber, index, path, value);
}
}
}
+3 -3
View File
@@ -37,7 +37,7 @@ export type ReactRenderer = {
// 16.9+
overrideHook?: ?(
fiber: Object,
nativeHookIndex: number,
index: number,
path: Array<string | number>,
value: any
) => void,
@@ -68,7 +68,7 @@ export type RendererInterface = {
setInContext: (id: number, path: Array<string | number>, value: any) => void,
setInHook: (
id: number,
nativeHookIndex: number,
index: number,
path: Array<string | number>,
value: any
) => void,
@@ -99,7 +99,7 @@ export type DevToolsHook = {
};
export type HooksNode = {
nativeHookIndex: number,
index: number,
name: string,
value: mixed,
subHooks: Array<HooksNode>,
+2 -2
View File
@@ -56,7 +56,7 @@ type HookViewProps = {|
|};
function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
const { name, nativeHookIndex, subHooks, value } = hook;
const { name, index, subHooks, value } = hook;
const bridge = useContext(BridgeContext);
const store = useContext(StoreContext);
@@ -126,7 +126,7 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
const rendererID = store.getRendererIDForElement(id);
bridge.send('overrideHook', {
id,
nativeHookIndex,
index,
path,
rendererID,
value,