Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix expect() slipping into the non-test code

Browse Source
This commit is contained in:
Dan Abramov
2016-04-21 22:23:35 +01:00
parent 1f2e78359f
commit e20d366ea8
1 changed files with 23 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/isomorphic/devtools/ReactComponentTreeDevtool.js
+23 -4
View File
@@ -11,6 +11,8 @@
'use strict';
var invariant = require('invariant');
var unmountedContainerIDs = [];
var allChildIDsByContainerID = {};
var tree = {};
@@ -65,10 +67,27 @@ var ReactComponentTreeDevtool = {
nextChildIDs.forEach(nextChildID => {
var item = tree[nextChildID];
expect(item).toBeDefined();
expect(item.isComposite).toBeDefined();
expect(item.displayName).toBeDefined();
expect(item.childIDs || item.text).toBeDefined();
invariant(
item,
'Expected devtool events to fire for the child ' +
'before its parent includes it in onSetChildren().'
);
invariant(
item.isComposite != null,
'Expected onSetIsComposite() to fire for the child ' +
'before its parent includes it in onSetChildren().'
);
invariant(
item.displayName != null,
'Expected onSetDisplayName() to fire for the child ' +
'before its parent includes it in onSetChildren().'
);
invariant(
item.childIDs != null || item.text != null,
'Expected either onSetChildren() or onSetText() to fire for the child ' +
'before its parent includes it in onSetChildren().'
);
if (tree[nextChildID] && prevChildIDs.indexOf(nextChildID) === -1) {
tree[nextChildID].parentID = id;