Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Codegen TValue are just Expressions (#839)

Browse Source
This commit is contained in:
Jan Kassens
2022-12-01 12:56:45 -05:00
parent 509aa9f0e5
commit df58546f4e
1 changed files with 4 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/HIR/Codegen.ts
+4 -14
View File
@@ -91,12 +91,7 @@ type Temporaries = Map<IdentifierId, t.Expression>;
class CodegenVisitor
implements
Visitor<
Array<t.Statement>,
t.Expression | t.Statement | t.JSXFragment,
t.Statement,
t.SwitchCase
>
Visitor<Array<t.Statement>, t.Expression, t.Statement, t.SwitchCase>
{
depth: number = 0;
temp: Map<IdentifierId, t.Expression> = new Map();
@@ -105,15 +100,10 @@ class CodegenVisitor
this.depth++;
return [];
}
visitValue(
value: InstructionValue
): t.Expression | t.Statement | t.JSXFragment {
visitValue(value: InstructionValue): t.Expression {
return codegenInstructionValue(this.temp, value);
}
visitInstruction(
instr: Instruction,
value: t.Expression | t.Statement | t.JSXFragment
): t.Statement {
visitInstruction(instr: Instruction, value: t.Expression): t.Statement {
if (t.isStatement(value)) {
return value;
}
@@ -256,7 +246,7 @@ function codegenLabel(id: BlockId): string {
function codegenInstructionValue(
temp: Temporaries,
instrValue: InstructionValue
): t.Expression | t.JSXFragment | t.Statement {
): t.Expression {
let value: t.Expression;
switch (instrValue.kind) {
case "ArrayExpression": {