Tweaked colors based on Andrew's feedback

This commit is contained in:
Brian Vaughn
2019-02-21 14:02:45 -08:00
parent 290e8c6926
commit ddeb78001c
4 changed files with 27 additions and 10 deletions
+6 -2
View File
@@ -7,17 +7,21 @@
padding-left: 0.75rem;
}
.Header {
font-family: var(--font-family-sans);
color: var(--color-dim);
}
.NameValueRow {
display: flex;
}
.Name {
color: var(--color-attribute-name);
color: var(--color-text-color);
flex: 0 0 auto;
}
.Name:after {
content: ': ';
color: var(--color-text-color);
margin-right: 0.5rem;
}
+8 -2
View File
@@ -19,7 +19,7 @@ export function HooksTreeView({ canEditHooks, hooks, id }: HooksTreeViewProps) {
} else {
return (
<div className={styles.HooksTreeView}>
<div className={styles.Item}>hooks</div>
<div className={styles.Header}>hooks</div>
<InnerHooksTreeView canEditHooks={canEditHooks} hooks={hooks} id={id} />
</div>
);
@@ -96,7 +96,12 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
<div className={styles.NameValueRow}>
<span className={styles.Name}>{name}</span>
</div>
<KeyValue depth={1} name="DebugValue" value={value} />
<KeyValue
depth={1}
name="DebugValue"
nameClassName={styles.Name}
value={value}
/>
<InnerHooksTreeView
canEditHooks={canEditHooks}
hooks={subHooks}
@@ -141,6 +146,7 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
<KeyValue
depth={0}
name={name}
nameClassName={styles.Name}
overrideValueFn={overrideValueFn}
value={value}
/>
@@ -6,6 +6,11 @@
border-top: none;
}
.Header {
font-family: var(--font-family-sans);
color: var(--color-dim);
}
.Item {
display: flex;
}
+8 -6
View File
@@ -30,7 +30,7 @@ export default function InspectedElementTree({
// TODO Add click and key handlers for toggling element open/close state.
return (
<div className={styles.InspectedElementTree}>
<div className={styles.Item}>{label}</div>
<div className={styles.Header}>{label}</div>
{isEmpty && <div className={styles.Empty}>None</div>}
{!isEmpty &&
Object.keys((data: any)).map(name => (
@@ -51,6 +51,7 @@ export default function InspectedElementTree({
type KeyValueProps = {|
depth: number,
name: string,
nameClassName?: string,
overrideValueFn?: ?OverrideValueFn,
path?: Array<any>,
value: any,
@@ -59,6 +60,7 @@ type KeyValueProps = {|
export function KeyValue({
depth,
name,
nameClassName = styles.Name,
overrideValueFn,
path = [],
value,
@@ -87,7 +89,7 @@ export function KeyValue({
children = (
<div key="root" className={styles.Item} style={{ paddingLeft }}>
<span className={styles.Name}>{name}</span>
<span className={nameClassName}>{name}</span>
{typeof overrideValueFn === 'function' ? (
<EditableValue
dataType={dataType}
@@ -104,7 +106,7 @@ export function KeyValue({
// TODO Is this type even necessary? Can we just drop it?
children = (
<div key="root" className={styles.Item} style={{ paddingLeft }}>
<span className={styles.Name}>{name}</span>
<span className={nameClassName}>{name}</span>
<span className={styles.Value}>{getMetaValueLabel(value)}</span>
</div>
);
@@ -126,7 +128,7 @@ export function KeyValue({
className={styles.Item}
style={{ paddingLeft }}
>
<span className={styles.Name}>{name}</span>
<span className={nameClassName}>{name}</span>
<span>Array</span>
</div>
);
@@ -148,7 +150,7 @@ export function KeyValue({
className={styles.Item}
style={{ paddingLeft }}
>
<span className={styles.Name}>{name}</span>
<span className={nameClassName}>{name}</span>
<span>Object</span>
</div>
);
@@ -239,7 +241,7 @@ export function EditableValue({
value={dataType === 'boolean' ? undefined : inputValue}
/>
</label>
{hasPendingChanges && (
{hasPendingChanges && dataType !== 'boolean' && (
<Button
className={styles.ResetButton}
onClick={handleReset}