[compiler] Repro for false positive mutation of a value derived from props (#35139)

Repro from the compiler WG (Thanks Cody!) of a case where the compiler
incorrectly thinks a value is mutable.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/35139).
* #35140
* __->__ #35139
This commit is contained in:
Joseph Savona authored and GitHub committed 2025-11-14 12:14:23 -08:00
1 parent 21f282425c
commit dbf2538355
2 files changed
+58

No files matched your search

@@ -0,0 +1,43 @@
## Input
```javascript
export function useFormatRelativeTime(opts = {}) {
const {timeZone, minimal} = opts;
const format = useCallback(function formatWithUnit() {}, [minimal]);
// We record `{timeZone}` as capturing timeZone into the object,
// then assume that dateTimeFormat() mutates that object,
// which in turn can mutate timeZone and the object it came from,
// which means that the value `minimal` is derived from can change.
//
// The bug is that we shouldn't be recording a Capture effect given
// that `opts` is known maybe-frozen. If we correctly recorded
// an ImmutableCapture, this wouldn't be mistaken as mutating
// opts/minimal
dateTimeFormat({timeZone});
return format;
}
```
## Error
```
Found 1 error:
Compilation Skipped: Existing memoization could not be preserved
React Compiler has skipped optimizing this component because the existing manual memoization could not be preserved. This dependency may be mutated later, which could cause the value to change unexpectedly.
error.todo-repro-destructure-from-prop-with-default-value.ts:3:60
1 | export function useFormatRelativeTime(opts = {}) {
2 | const {timeZone, minimal} = opts;
> 3 | const format = useCallback(function formatWithUnit() {}, [minimal]);
| ^^^^^^^ This dependency may be modified later
4 | // We record `{timeZone}` as capturing timeZone into the object,
5 | // then assume that dateTimeFormat() mutates that object,
6 | // which in turn can mutate timeZone and the object it came from,
```
@@ -0,0 +1,15 @@
export function useFormatRelativeTime(opts = {}) {
const {timeZone, minimal} = opts;
const format = useCallback(function formatWithUnit() {}, [minimal]);
// We record `{timeZone}` as capturing timeZone into the object,
// then assume that dateTimeFormat() mutates that object,
// which in turn can mutate timeZone and the object it came from,
// which means that the value `minimal` is derived from can change.
//
// The bug is that we shouldn't be recording a Capture effect given
// that `opts` is known maybe-frozen. If we correctly recorded
// an ImmutableCapture, this wouldn't be mistaken as mutating
// opts/minimal
dateTimeFormat({timeZone});
return format;
}