Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Distribute bundles more evenly into CI shards (#26208)

Browse Source 
## Summary

Previously, we distributed bundles into shards and then checked if we
need to actually build that bundle. This can under-utilize shards
heavily (e.g.
https://app.circleci.com/pipelines/github/facebook/react/38611/workflows/df9e56e7-d476-49ee-9392-d8b37c81aa66/jobs/630545/parallel-runs/28?filterBy=ALL
only building a single bundle).

This won't result in an optimal distribution but, if we're lucky, we
might end up with shard #26 not taking 7mins anymore. The slowest shard
ultimately decicdes when we can start with testing builds.

## How did you test this change?

- [x] `CIRCLE_NODE_INDEX=28 CIRCLE_NODE_TOTAL=40 yarn build` building
more than 1 bundle
- [x] Check timings of `yarn_build` so that we don't up with an
over-stuffed shard (e.g. a shard having to build all the expensive
bundles). Casually dropping 60min idle time 🎉:
- Before:
https://app.circleci.com/pipelines/github/facebook/react/38683/workflows/a41533d7-811c-439d-9751-214ba06035c5/jobs/632230/timing
- After:
https://app.circleci.com/pipelines/github/facebook/react/38686/workflows/8a770df6-5b3e-41ea-b3b5-10abeae703e7/jobs/632247/timing

DiffTrain build for commit c7967b194b.
This commit is contained in:
eps1lon
2023-02-20 21:22:13 +00:00
parent 8a67cf0679
commit d8eed112dc
28 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled/facebook-www/REVISION
+1 -1
View File
@@ -1 +1 @@
bb1e3d0e19f1e36ecb5b9e58d40bbf59fa220b73
c7967b194b41cb16907eed718b78d89120089f6a
compiled/facebook-www/REVISION_TRANSFORMS
+1 -1
View File
@@ -1 +1 @@
bb1e3d0e19f1e36ecb5b9e58d40bbf59fa220b73
c7967b194b41cb16907eed718b78d89120089f6a
compiled/facebook-www/React-dev.classic.js
+1 -1
View File
@@ -27,7 +27,7 @@ if (
}
"use strict";
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
// ATTENTION
// When adding new symbols to this file,
compiled/facebook-www/React-dev.modern.js
+1 -1
View File
@@ -27,7 +27,7 @@ if (
}
"use strict";
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
// ATTENTION
// When adding new symbols to this file,
compiled/facebook-www/React-prod.classic.js
+1 -1
View File
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-classic-c7967b194-20230220";
compiled/facebook-www/React-prod.modern.js
+1 -1
View File
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-modern-c7967b194-20230220";
compiled/facebook-www/React-profiling.classic.js
+1 -1
View File
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-classic-c7967b194-20230220";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/React-profiling.modern.js
+1 -1
View File
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-modern-c7967b194-20230220";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactART-dev.classic.js
+1 -1
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
compiled/facebook-www/ReactART-dev.modern.js
+1 -1
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
compiled/facebook-www/ReactART-prod.classic.js
+2 -2
View File
@@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
version: "18.3.0-www-classic-c7967b194-20230220",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1301 = {
@@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled/facebook-www/ReactART-prod.modern.js
+2 -2
View File
@@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
version: "18.3.0-www-modern-c7967b194-20230220",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1281 = {
@@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled/facebook-www/ReactDOM-dev.classic.js
+1 -1
View File
@@ -41996,7 +41996,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-dev.modern.js
+1 -1
View File
@@ -41600,7 +41600,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-prod.classic.js
+3 -3
View File
@@ -15469,7 +15469,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1742 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
version: "18.3.0-www-classic-c7967b194-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2109 = {
@@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
compiled/facebook-www/ReactDOM-prod.modern.js
+3 -3
View File
@@ -14998,7 +14998,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1701 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
version: "18.3.0-www-modern-c7967b194-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2073 = {
@@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
compiled/facebook-www/ReactDOM-profiling.classic.js
+3 -3
View File
@@ -16239,7 +16239,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
version: "18.3.0-www-classic-c7967b194-20230220",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
});
assign(Internals, {
ReactBrowserEventEmitter: {
@@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactDOM-profiling.modern.js
+3 -3
View File
@@ -15758,7 +15758,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
version: "18.3.0-www-modern-c7967b194-20230220",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
@@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactDOMServer-dev.classic.js
+1 -1
View File
@@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
// This refers to a WWW module.
var warningWWW = require("warning");
compiled/facebook-www/ReactDOMServer-dev.modern.js
+1 -1
View File
@@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
// This refers to a WWW module.
var warningWWW = require("warning");
compiled/facebook-www/ReactDOMServer-prod.classic.js
+1 -1
View File
@@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-classic-c7967b194-20230220";
compiled/facebook-www/ReactDOMServer-prod.modern.js
+1 -1
View File
@@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-bb1e3d0e1-20230220";
exports.version = "18.3.0-www-modern-c7967b194-20230220";
compiled/facebook-www/ReactDOMTesting-dev.classic.js
+1 -1
View File
@@ -31233,7 +31233,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-dev.modern.js
+1 -1
View File
@@ -37624,7 +37624,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-prod.classic.js
+3 -3
View File
@@ -11541,7 +11541,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1536 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-bb1e3d0e1-20230220",
version: "18.3.0-www-classic-c7967b194-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2059 = {
@@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
compiled/facebook-www/ReactDOMTesting-prod.modern.js
+3 -3
View File
@@ -13856,7 +13856,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1653 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-bb1e3d0e1-20230220",
version: "18.3.0-www-modern-c7967b194-20230220",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2033 = {
@@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-bb1e3d0e1-20230220"
reconcilerVersion: "18.3.0-next-c7967b194-20230220"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-bb1e3d0e1-20230220";
exports.version = "18.3.0-next-c7967b194-20230220";
compiled/facebook-www/ReactTestRenderer-dev.classic.js
+1 -1
View File
@@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-classic-c7967b194-20230220";
// Might add PROFILE later.
compiled/facebook-www/ReactTestRenderer-dev.modern.js
+1 -1
View File
@@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-bb1e3d0e1-20230220";
var ReactVersion = "18.3.0-www-modern-c7967b194-20230220";
// Might add PROFILE later.