Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[react-interactions] Fix typo in FocusTable (#16860)

Browse Source
This commit is contained in:
Dominic Gannaway
2019-09-23 14:20:43 +02:00
committed by GitHub
parent cef47cbc01
commit d7f6dd5a80
2 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-interactions/accessibility/src/FocusTable.js
Vendored
+4 -4
View File
@@ -149,7 +149,7 @@ export function createFocusTable(): Array<React.Component> {
onKeyDown(event: KeyboardEvent): void {
const currentCell = scopeRef.current;
switch (event.key) {
case 'UpArrow': {
case 'ArrowUp': {
const [cells, rowIndex] = getRowCells(currentCell);
if (cells !== null) {
const [columns, columnIndex] = getRows(currentCell);
@@ -164,7 +164,7 @@ export function createFocusTable(): Array<React.Component> {
}
return;
}
case 'DownArrow': {
case 'ArrowDown': {
const [cells, rowIndex] = getRowCells(currentCell);
if (cells !== null) {
const [columns, columnIndex] = getRows(currentCell);
@@ -181,7 +181,7 @@ export function createFocusTable(): Array<React.Component> {
}
return;
}
case 'LeftArrow': {
case 'ArrowLeft': {
const [cells, rowIndex] = getRowCells(currentCell);
if (cells !== null) {
if (rowIndex > 0) {
@@ -192,7 +192,7 @@ export function createFocusTable(): Array<React.Component> {
}
return;
}
case 'RightArrow': {
case 'ArrowRight': {
const [cells, rowIndex] = getRowCells(currentCell);
if (cells !== null) {
if (rowIndex !== -1) {
packages/react-interactions/accessibility/src/__tests__/FocusTable-test.internal.js
+15 -15
View File
@@ -116,35 +116,35 @@ describe('ReactFocusTable', () => {
const a1 = createEventTarget(buttons[0]);
a1.focus();
a1.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A2');
const a2 = createEventTarget(document.activeElement);
a2.keydown({
key: 'DownArrow',
key: 'ArrowDown',
});
expect(document.activeElement.textContent).toBe('B2');
const b2 = createEventTarget(document.activeElement);
b2.keydown({
key: 'LeftArrow',
key: 'ArrowLeft',
});
expect(document.activeElement.textContent).toBe('B1');
const b1 = createEventTarget(document.activeElement);
b1.keydown({
key: 'DownArrow',
key: 'ArrowDown',
});
expect(document.activeElement.textContent).toBe('C1');
const c1 = createEventTarget(document.activeElement);
c1.keydown({
key: 'DownArrow',
key: 'ArrowDown',
});
expect(document.activeElement.textContent).toBe('C1');
c1.keydown({
key: 'UpArrow',
key: 'ArrowUp',
});
expect(document.activeElement.textContent).toBe('B1');
});
@@ -201,55 +201,55 @@ describe('ReactFocusTable', () => {
let a1 = createEventTarget(buttons[0]);
a1.focus();
a1.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A2');
let a2 = createEventTarget(document.activeElement);
a2.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A3');
let a3 = createEventTarget(document.activeElement);
a3.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A1');
a1 = createEventTarget(document.activeElement);
a1.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A2');
a2 = createEventTarget(document.activeElement);
a2.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A3');
a3 = createEventTarget(document.activeElement);
a3.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A1');
a1 = createEventTarget(document.activeElement);
a1.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A2');
a2 = createEventTarget(document.activeElement);
a2.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A3');
a3 = createEventTarget(document.activeElement);
a3.keydown({
key: 'RightArrow',
key: 'ArrowRight',
});
expect(document.activeElement.textContent).toBe('A3');
});