Set enableFastJSX flag to true (#30343)

When these to diffs are landed, we can merge this

- [x] D59772879
- [x] D59773043
This commit is contained in:
Jan Kassens
2024-07-22 11:50:35 -04:00
committed by GitHub
parent 06763852de
commit d025ddd3b9
11 changed files with 4 additions and 16 deletions
@@ -377,7 +377,7 @@ describe('ReactJSXRuntime', () => {
expect(didCall).toBe(false);
});
// @gate enableFastJSX && enableRefAsProp
// @gate enableRefAsProp
it('does not clone props object if key and ref is not spread', async () => {
const config = {
foo: 'foo',
+3 -6
View File
@@ -23,7 +23,6 @@ import {
enableRefAsProp,
disableStringRefs,
disableDefaultPropsExceptForClasses,
enableFastJSX,
enableOwnerStacks,
} from 'shared/ReactFeatureFlags';
import {checkPropStringCoercion} from 'shared/CheckStringCoercion';
@@ -82,9 +81,7 @@ if (__DEV__) {
didWarnAboutElementRef = {};
}
const enableFastJSXWithStringRefs = enableFastJSX && enableRefAsProp;
const enableFastJSXWithoutStringRefs =
enableFastJSXWithStringRefs && disableStringRefs;
const enableFastJSXWithoutStringRefs = enableRefAsProp && disableStringRefs;
function hasValidRef(config) {
if (__DEV__) {
@@ -416,7 +413,7 @@ export function jsxProd(type, config, maybeKey) {
let props;
if (
(enableFastJSXWithoutStringRefs ||
(enableFastJSXWithStringRefs && !('ref' in config))) &&
(enableRefAsProp && !('ref' in config))) &&
!('key' in config)
) {
// If key was not spread in, we can reuse the original props object. This
@@ -701,7 +698,7 @@ function jsxDEVImpl(
let props;
if (
(enableFastJSXWithoutStringRefs ||
(enableFastJSXWithStringRefs && !('ref' in config))) &&
(enableRefAsProp && !('ref' in config))) &&
!('key' in config)
) {
// If key was not spread in, we can reuse the original props object. This
-1
View File
@@ -195,7 +195,6 @@ export const enableInfiniteRenderLoopDetection = true;
// during element creation.
export const enableRefAsProp = true;
export const disableStringRefs = true;
export const enableFastJSX = true;
// Warn on any usage of ReactTestRenderer
export const enableReactTestRendererWarning = true;
@@ -19,7 +19,6 @@
export const alwaysThrottleRetries = __VARIANT__;
export const enableAddPropertiesFastPath = __VARIANT__;
export const enableFastJSX = __VARIANT__;
export const enableObjectFiber = __VARIANT__;
export const enableShallowPropDiffing = __VARIANT__;
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
@@ -21,7 +21,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
export const {
alwaysThrottleRetries,
enableAddPropertiesFastPath,
enableFastJSX,
enableObjectFiber,
enableShallowPropDiffing,
passChildrenWhenCloningPersistedNodes,
@@ -45,7 +45,6 @@ export const enableCreateEventHandleAPI = false;
export const enableDebugTracing = false;
export const enableDeferRootSchedulingToMicrotask = true;
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
export const enableFastJSX = true;
export const enableFilterEmptyStringAttributesDOM = true;
export const enableFizzExternalRuntime = true;
export const enableFlightReadableStream = true;
@@ -89,7 +89,6 @@ export const enableShallowPropDiffing = false;
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
export const enableRefAsProp = true;
export const disableStringRefs = true;
export const enableFastJSX = true;
export const disableLegacyMode = true;
export const disableLegacyContext = true;
export const disableLegacyContextForFunctionComponents = true;
@@ -37,7 +37,6 @@ export const enableCreateEventHandleAPI = false;
export const enableDebugTracing = false;
export const enableDeferRootSchedulingToMicrotask = true;
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
export const enableFastJSX = true;
export const enableFilterEmptyStringAttributesDOM = true;
export const enableFizzExternalRuntime = true;
export const enableFlightReadableStream = true;
@@ -81,7 +81,6 @@ export const enableInfiniteRenderLoopDetection = false;
export const enableRefAsProp = true;
export const disableStringRefs = false;
export const enableFastJSX = false;
export const enableReactTestRendererWarning = false;
export const disableLegacyMode = true;
@@ -21,7 +21,6 @@ export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
export const enableAddPropertiesFastPath = __VARIANT__;
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
export const enableFastJSX = __VARIANT__;
export const enableLazyContextPropagation = __VARIANT__;
export const enableNoCloningMemoCache = __VARIANT__;
export const enableObjectFiber = __VARIANT__;
@@ -23,7 +23,6 @@ export const {
enableDebugTracing,
enableDeferRootSchedulingToMicrotask,
enableDO_NOT_USE_disableStrictPassiveEffect,
enableFastJSX,
enableInfiniteRenderLoopDetection,
enableLazyContextPropagation,
enableNoCloningMemoCache,