Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary clearContainer call (#22979)

Browse Source 
This was added when we added error recovery for hydration errors. However,
when the fix up pass happens later on, it'll still call clearContainer in
the commit phase. So this call is unnecessary.
This commit is contained in:
Sebastian Markbåge
2021-12-17 09:40:39 -08:00
committed by GitHub
parent aa8f2bdbce
commit ceee524a8f
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberWorkLoop.new.js
-2
View File
@@ -86,7 +86,6 @@ import {
cancelTimeout,
noTimeout,
afterActiveInstanceBlur,
clearContainer,
getCurrentEventPriority,
supportsMicrotasks,
errorHydratingContainer,
@@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) {
if (__DEV__) {
errorHydratingContainer(root.containerInfo);
}
clearContainer(root.containerInfo);
}
let exitStatus;
packages/react-reconciler/src/ReactFiberWorkLoop.old.js
-2
View File
@@ -86,7 +86,6 @@ import {
cancelTimeout,
noTimeout,
afterActiveInstanceBlur,
clearContainer,
getCurrentEventPriority,
supportsMicrotasks,
errorHydratingContainer,
@@ -885,7 +884,6 @@ function recoverFromConcurrentError(root, errorRetryLanes) {
if (__DEV__) {
errorHydratingContainer(root.containerInfo);
}
clearContainer(root.containerInfo);
}
let exitStatus;