Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix up Flow annotations to be a bit more explicit where the unsoundness is

Browse Source
This commit is contained in:
Sebastian Markbage
2016-11-18 14:40:51 +00:00
parent 57f0cf376f
commit cd0f963fa3
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderers/dom/fiber/ReactDOMFiberComponent.js
+6 -4
View File
@@ -159,7 +159,7 @@ var mediaEvents = {
topWaiting: 'waiting',
};
function trapClickOnNonInteractiveElement(node : any) {
function trapClickOnNonInteractiveElement(node : HTMLElement) {
// Mobile Safari does not fire properly bubble click events on
// non-interactive elements, which means delegated click listeners do not
// fire. The workaround for this bug involves attaching an empty click
@@ -496,7 +496,7 @@ var ReactDOMFiberComponent = {
var div = ownerDocument.createElement('div');
div.innerHTML = '<script></script>';
// This is guaranteed to yield a script element.
var firstChild = ((div.firstChild : any) : Element);
var firstChild = ((div.firstChild : any) : HTMLScriptElement);
domElement = div.removeChild(firstChild);
} else if (props.is) {
domElement = ownerDocument.createElement(tag, props.is);
@@ -622,7 +622,8 @@ var ReactDOMFiberComponent = {
break;
default:
if (typeof props.onClick === 'function') {
trapClickOnNonInteractiveElement(domElement);
// TODO: This cast may not be sound for SVG, MathML or custom elements.
trapClickOnNonInteractiveElement(((domElement : any) : HTMLElement));
}
break;
}
@@ -655,7 +656,8 @@ var ReactDOMFiberComponent = {
default:
if (typeof lastProps.onClick !== 'function' &&
typeof nextProps.onClick === 'function') {
trapClickOnNonInteractiveElement(domElement);
// TODO: This cast may not be sound for SVG, MathML or custom elements.
trapClickOnNonInteractiveElement(((domElement : any) : HTMLElement));
}
break;
}