mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Replace DevTools semver usages with compare-versions for smaller bundle size (#26122)
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.
Before submitting a pull request, please make sure the following is
done:
1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn debug-test --watch TestName`, open
`chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
This PR:
- Replaces the existing usages of methods from the `semver` library in
the React DevTools source with an inlined version based on
https://www.npmjs.com/package/semver-compare.
This appears to drop the unminified bundle sizes of 3 separate
`react-devtools-extensions` build artifacts by about 50K:
## How did you test this change?
I was originally working on [a fork of React
DevTools](https://github.com/replayio/react/pull/2) for use with
https://replay.io , specifically our integration of the React DevTools
UI to show the React component tree while users are debugging a recorded
application.
As part of the dev work on that fork, I wanted to shrink the bundle size
of the extension's generated JS build artifacts. I noted that the
official NPM `semver` library was taking up a noticeable chunk of space
in the bundles, and saw that it's only being used in a handful of places
to do some very simple version string comparisons.
I was able to replace the `semver` imports and usages with a simple
alternate comparison function, and confirmed via hands-on checks and
console logging that the checks behaved the same way.
Given that, I wanted to upstream this particular change to help shrink
the real extension's bundle sizes.
I know that it's an extension, so bundle size isn't _as_ critical a
concern as it would be for a pure library. But, smaller download sizes
do benefit all users, and that also includes sites like CodeSandbox and
Replay that are using the React DevTools as a library as well.
I'm happy to tweak this PR if necessary. Thanks!
DiffTrain build for [78d2e9e2a8](https://github.com/facebook/react/commit/78d2e9e2a894a7ea9aa3f9faadfc4c6038e86a75)
[View git log for this commit](https://github.com/facebook/react/commits/78d2e9e2a894a7ea9aa3f9faadfc4c6038e86a75)
This commit is contained in:
mondaychen
@@ -1 +1 @@
|
||||
a3152eda5f89e20f056521855f7fa101ce50e4c3
|
||||
78d2e9e2a894a7ea9aa3f9faadfc4c6038e86a75
|
||||
|
||||
@@ -1 +1 @@
|
||||
a3152eda5f89e20f056521855f7fa101ce50e4c3
|
||||
78d2e9e2a894a7ea9aa3f9faadfc4c6038e86a75
|
||||
|
||||
@@ -27,7 +27,7 @@ if (
|
||||
}
|
||||
"use strict";
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
// ATTENTION
|
||||
// When adding new symbols to this file,
|
||||
|
||||
@@ -27,7 +27,7 @@ if (
|
||||
}
|
||||
"use strict";
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
// ATTENTION
|
||||
// When adding new symbols to this file,
|
||||
|
||||
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
|
||||
return self;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
var LegacyRoot = 0;
|
||||
var ConcurrentRoot = 1;
|
||||
|
||||
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
|
||||
return self;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
var LegacyRoot = 0;
|
||||
var ConcurrentRoot = 1;
|
||||
|
||||
@@ -9845,7 +9845,7 @@ var slice = Array.prototype.slice,
|
||||
return null;
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-a3152eda5-20230208",
|
||||
version: "18.3.0-www-classic-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-art"
|
||||
};
|
||||
var internals$jscomp$inline_1318 = {
|
||||
@@ -9876,7 +9876,7 @@ var internals$jscomp$inline_1318 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
@@ -9510,7 +9510,7 @@ var slice = Array.prototype.slice,
|
||||
return null;
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-a3152eda5-20230208",
|
||||
version: "18.3.0-www-modern-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-art"
|
||||
};
|
||||
var internals$jscomp$inline_1309 = {
|
||||
@@ -9541,7 +9541,7 @@ var internals$jscomp$inline_1309 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
@@ -42695,7 +42695,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -42419,7 +42419,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -15575,7 +15575,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1750 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-a3152eda5-20230208",
|
||||
version: "18.3.0-www-classic-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2134 = {
|
||||
@@ -15605,7 +15605,7 @@ var internals$jscomp$inline_2134 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2135 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -15853,4 +15853,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
@@ -15136,7 +15136,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1718 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-a3152eda5-20230208",
|
||||
version: "18.3.0-www-modern-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2109 = {
|
||||
@@ -15167,7 +15167,7 @@ var internals$jscomp$inline_2109 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -15355,4 +15355,4 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
@@ -16345,7 +16345,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1824 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-a3152eda5-20230208",
|
||||
version: "18.3.0-www-classic-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
(function (internals) {
|
||||
@@ -16389,7 +16389,7 @@ var devToolsConfig$jscomp$inline_1824 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
});
|
||||
assign(Internals, {
|
||||
ReactBrowserEventEmitter: {
|
||||
@@ -16624,7 +16624,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -15896,7 +15896,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1792 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-a3152eda5-20230208",
|
||||
version: "18.3.0-www-modern-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
(function (internals) {
|
||||
@@ -15941,7 +15941,7 @@ var devToolsConfig$jscomp$inline_1792 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
});
|
||||
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
|
||||
exports.createPortal = function (children, container) {
|
||||
@@ -16116,7 +16116,7 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -19,7 +19,7 @@ if (__DEV__) {
|
||||
var React = require("react");
|
||||
var ReactDOM = require("react-dom");
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
// This refers to a WWW module.
|
||||
var warningWWW = require("warning");
|
||||
|
||||
@@ -19,7 +19,7 @@ if (__DEV__) {
|
||||
var React = require("react");
|
||||
var ReactDOM = require("react-dom");
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
// This refers to a WWW module.
|
||||
var warningWWW = require("warning");
|
||||
|
||||
@@ -3634,4 +3634,4 @@ exports.renderToString = function (children, options) {
|
||||
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
|
||||
);
|
||||
};
|
||||
exports.version = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
@@ -3548,4 +3548,4 @@ exports.renderToString = function (children, options) {
|
||||
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
|
||||
);
|
||||
};
|
||||
exports.version = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
@@ -31212,7 +31212,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -38514,7 +38514,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -11356,7 +11356,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1518 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-a3152eda5-20230208",
|
||||
version: "18.3.0-www-classic-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2047 = {
|
||||
@@ -11386,7 +11386,7 @@ var internals$jscomp$inline_2047 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2048 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -14903,4 +14903,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
@@ -14007,7 +14007,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1673 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-a3152eda5-20230208",
|
||||
version: "18.3.0-www-modern-78d2e9e2a-20230208",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2072 = {
|
||||
@@ -14038,7 +14038,7 @@ var internals$jscomp$inline_2072 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-a3152eda5-20230208"
|
||||
reconcilerVersion: "18.3.0-next-78d2e9e2a-20230208"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2073 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -14369,4 +14369,4 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-a3152eda5-20230208";
|
||||
exports.version = "18.3.0-next-78d2e9e2a-20230208";
|
||||
|
||||
@@ -23911,7 +23911,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-classic-78d2e9e2a-20230208";
|
||||
|
||||
// Might add PROFILE later.
|
||||
|
||||
|
||||
@@ -23911,7 +23911,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-a3152eda5-20230208";
|
||||
var ReactVersion = "18.3.0-www-modern-78d2e9e2a-20230208";
|
||||
|
||||
// Might add PROFILE later.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user