Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove now-unnecessary mutable range extension in LeaveSSA

Browse Source 
This is no longer necessary now that we extend phi operands' ranges in 
InferMutableRanges
This commit is contained in:
Joe Savona
2023-02-21 15:29:30 -08:00
parent 9a25b5a12a
commit bae2cb5f89
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/SSA/LeaveSSA.ts
+7 -6
View File
@@ -260,14 +260,15 @@ export function leaveSSA(fn: HIRFunction): void {
phi.id.mutableRange.end = makeInstructionId(terminal.id + 1);
}
} else if (isPhiMutatedAfterCreation) {
// The declaration is not guaranteed to flow into the phi, for example in the case of a variable
// that is reassigned in all control flow paths to a given phi. The original declaration's range
// has to be extended in this case (if the phi is later mutated) since we are reusing the original
// declaration instead of creating a new declaration.
//
// NOTE: this can *only* happen if the original declaration involves an instruction that DCE does
// not prune. Otherwise, the declaration would have been pruned and we'd synthesize a new one.
declaration.place.identifier.mutableRange.end = phi.id.mutableRange.end;
}
for (const [, operand] of phi.operands) {
if (isPhiMutatedAfterCreation) {
operand.mutableRange.end = phi.id.mutableRange.end;
}
}
}
// Similar logic for rewrite phis that occur in loops, except that instead of a new let binding