Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use value on <select> instead of setting selected on <option> (#11206)

Browse Source
This commit is contained in:
Clark Du
2017-10-16 07:46:24 -04:00
committed by Nathan Hunzaker
parent 17de6a35cf
commit b623bf43a0
1 changed files with 8 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fixtures/attribute-behavior/src/App.js
+8 -18
View File
@@ -958,35 +958,25 @@ class App extends React.Component {
return (
<div>
<div>
<select onChange={this.onUpdateSort}>
<option
selected={this.state.sortOrder === ALPHABETICAL}
value={ALPHABETICAL}>
<select value={this.state.sortOrder} onChange={this.onUpdateSort}>
<option value={ALPHABETICAL}>
alphabetical
</option>
<option
selected={this.state.sortOrder === REV_ALPHABETICAL}
value={REV_ALPHABETICAL}>
<option value={REV_ALPHABETICAL}>
reverse alphabetical
</option>
<option
selected={this.state.sortOrder === GROUPED_BY_ROW_PATTERN}
value={GROUPED_BY_ROW_PATTERN}>
<option value={GROUPED_BY_ROW_PATTERN}>
grouped by row pattern :)
</option>
</select>
<select onChange={this.onUpdateFilter}>
<option selected={this.state.sortOrder === ALL} value={ALL}>
<select value={this.state.filter} onChange={this.onUpdateFilter}>
<option value={ALL}>
all
</option>
<option
selected={this.state.sortOrder === INCOMPLETE}
value={INCOMPLETE}>
<option value={INCOMPLETE}>
incomplete
</option>
<option
selected={this.state.sortOrder === COMPLETE}
value={COMPLETE}>
<option value={COMPLETE}>
complete
</option>
</select>