Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bug: yarn flow dom does not exist, so console should suggest yarn flow dom-node (#26213)

Browse Source 
<!--
  Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please
provide enough information so that others can review your pull request.
The three fields below are mandatory.

Before submitting a pull request, please make sure the following is
done:

1. Fork [the repository](https://github.com/facebook/react) and create
your branch from `main`.
  2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch
TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It
supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`,
open `chrome://inspect`, and press "Inspect".
7. Format your code with
[prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only
check changed files.
  9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
  10. If you haven't already, complete the CLA.

Learn more about contributing:
https://reactjs.org/docs/how-to-contribute.html
-->

## Summary
The `yarn flow` command, as suggested for every PR Submission (Task No.
9), tells us `The yarn flow command now requires you to pick a primary
renderer` and provides a list for the same. However, in at the bottom of
the prompt, it suggests `If you are not sure, run yarn flow dom`. This
command `yarn flow dom` does not exist in the list and thus the command
does nothing and exits with `status code 1` without any flow test.

<!--
Explain the **motivation** for making this change. What existing problem
does the pull request solve?
-->
While trying to submit a different PR for code cleaning, just during
submission I read the PR Guidelines, and while doing `yarn test`, `yarn
lint`, and `yarn flow`, I came across this issue and thought of
submitting a PR for the same.

## How did you test this change?
Since this code change does not change any logic, just the text
information, I only ran `yarn linc` and `yarn test` for the same.

<!--
Demonstrate the code is solid. Example: The exact commands you ran and
their output, screenshots / videos if the pull request changes the user
interface.
How exactly did you verify that your PR solves the issue you wanted to
solve?
  If you leave this empty, your PR will very likely be closed.
-->
Here is how the issue currently looks like:

![facebook yarn flow
dom](https://user-images.githubusercontent.com/20269286/220337686-b8a9b786-92e0-4c66-88a9-e94bfbed6edf.JPG)

Signed-off-by: abhiram11 <abhiramsatpute@gmail.com>
Co-authored-by: abhiram11 <abhiramsatpute@gmail.com>

DiffTrain build for commit 212b89fa25.
This commit is contained in:
eps1lon
2023-02-21 20:36:48 +00:00
co-authored by abhiram11
parent 7df133e42a
commit b6024b9b77
28 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled/facebook-www/REVISION
+1 -1
View File
@@ -1 +1 @@
0a76fb9ec4999b2f21db2a385bfaa8b070b1f78b
212b89fa25fd0a39473e845d1665d45f9da9dad3
compiled/facebook-www/REVISION_TRANSFORMS
+1 -1
View File
@@ -1 +1 @@
0a76fb9ec4999b2f21db2a385bfaa8b070b1f78b
212b89fa25fd0a39473e845d1665d45f9da9dad3
compiled/facebook-www/React-dev.classic.js
+1 -1
View File
@@ -27,7 +27,7 @@ if (
}
"use strict";
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
// ATTENTION
// When adding new symbols to this file,
compiled/facebook-www/React-dev.modern.js
+1 -1
View File
@@ -27,7 +27,7 @@ if (
}
"use strict";
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
// ATTENTION
// When adding new symbols to this file,
compiled/facebook-www/React-prod.classic.js
+1 -1
View File
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-0a76fb9ec-20230221";
exports.version = "18.3.0-www-classic-212b89fa2-20230221";
compiled/facebook-www/React-prod.modern.js
+1 -1
View File
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-0a76fb9ec-20230221";
exports.version = "18.3.0-www-modern-212b89fa2-20230221";
compiled/facebook-www/React-profiling.classic.js
+1 -1
View File
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-classic-0a76fb9ec-20230221";
exports.version = "18.3.0-www-classic-212b89fa2-20230221";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/React-profiling.modern.js
+1 -1
View File
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-0a76fb9ec-20230221";
exports.version = "18.3.0-www-modern-212b89fa2-20230221";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactART-dev.classic.js
+1 -1
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
compiled/facebook-www/ReactART-dev.modern.js
+1 -1
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
compiled/facebook-www/ReactART-prod.classic.js
+2 -2
View File
@@ -9800,7 +9800,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-classic-0a76fb9ec-20230221",
version: "18.3.0-www-classic-212b89fa2-20230221",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1301 = {
@@ -9831,7 +9831,7 @@ var internals$jscomp$inline_1301 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1302 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled/facebook-www/ReactART-prod.modern.js
+2 -2
View File
@@ -9465,7 +9465,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-0a76fb9ec-20230221",
version: "18.3.0-www-modern-212b89fa2-20230221",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1281 = {
@@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1281 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1282 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
compiled/facebook-www/ReactDOM-dev.classic.js
+1 -1
View File
@@ -41996,7 +41996,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-dev.modern.js
+1 -1
View File
@@ -41600,7 +41600,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-prod.classic.js
+3 -3
View File
@@ -15469,7 +15469,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1742 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-0a76fb9ec-20230221",
version: "18.3.0-www-classic-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2109 = {
@@ -15499,7 +15499,7 @@ var internals$jscomp$inline_2109 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15747,4 +15747,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
compiled/facebook-www/ReactDOM-prod.modern.js
+3 -3
View File
@@ -14998,7 +14998,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1701 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-0a76fb9ec-20230221",
version: "18.3.0-www-modern-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2073 = {
@@ -15029,7 +15029,7 @@ var internals$jscomp$inline_2073 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2074 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -15213,4 +15213,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
compiled/facebook-www/ReactDOM-profiling.classic.js
+3 -3
View File
@@ -16239,7 +16239,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1822 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-0a76fb9ec-20230221",
version: "18.3.0-www-classic-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -16283,7 +16283,7 @@ var devToolsConfig$jscomp$inline_1822 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
});
assign(Internals, {
ReactBrowserEventEmitter: {
@@ -16518,7 +16518,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactDOM-profiling.modern.js
+3 -3
View File
@@ -15758,7 +15758,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1781 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-0a76fb9ec-20230221",
version: "18.3.0-www-modern-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
(function (internals) {
@@ -15803,7 +15803,7 @@ var devToolsConfig$jscomp$inline_1781 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
@@ -15974,7 +15974,7 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
compiled/facebook-www/ReactDOMServer-dev.classic.js
+1 -1
View File
@@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
// This refers to a WWW module.
var warningWWW = require("warning");
compiled/facebook-www/ReactDOMServer-dev.modern.js
+1 -1
View File
@@ -19,7 +19,7 @@ if (__DEV__) {
var React = require("react");
var ReactDOM = require("react-dom");
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
// This refers to a WWW module.
var warningWWW = require("warning");
compiled/facebook-www/ReactDOMServer-prod.classic.js
+1 -1
View File
@@ -3670,4 +3670,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-classic-0a76fb9ec-20230221";
exports.version = "18.3.0-www-classic-212b89fa2-20230221";
compiled/facebook-www/ReactDOMServer-prod.modern.js
+1 -1
View File
@@ -3568,4 +3568,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "18.3.0-www-modern-0a76fb9ec-20230221";
exports.version = "18.3.0-www-modern-212b89fa2-20230221";
compiled/facebook-www/ReactDOMTesting-dev.classic.js
+1 -1
View File
@@ -31233,7 +31233,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-dev.modern.js
+1 -1
View File
@@ -37624,7 +37624,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-prod.classic.js
+3 -3
View File
@@ -11541,7 +11541,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1536 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-0a76fb9ec-20230221",
version: "18.3.0-www-classic-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2059 = {
@@ -11571,7 +11571,7 @@ var internals$jscomp$inline_2059 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2060 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14749,4 +14749,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
compiled/facebook-www/ReactDOMTesting-prod.modern.js
+3 -3
View File
@@ -13856,7 +13856,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1653 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-0a76fb9ec-20230221",
version: "18.3.0-www-modern-212b89fa2-20230221",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2033 = {
@@ -13887,7 +13887,7 @@ var internals$jscomp$inline_2033 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-next-0a76fb9ec-20230221"
reconcilerVersion: "18.3.0-next-212b89fa2-20230221"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2034 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -14214,4 +14214,4 @@ exports.unstable_flushControlled = function (fn) {
}
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-next-0a76fb9ec-20230221";
exports.version = "18.3.0-next-212b89fa2-20230221";
compiled/facebook-www/ReactTestRenderer-dev.classic.js
+1 -1
View File
@@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-classic-212b89fa2-20230221";
// Might add PROFILE later.
compiled/facebook-www/ReactTestRenderer-dev.modern.js
+1 -1
View File
@@ -23749,7 +23749,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-0a76fb9ec-20230221";
var ReactVersion = "18.3.0-www-modern-212b89fa2-20230221";
// Might add PROFILE later.