Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix disableStrictPassiveEffect not working under Suspense (#26989)

Browse Source 
In https://github.com/facebook/react/pull/26914 I added an extra logic
to turn off double useEffect if there is an `Offscreen`
tag. But `Suspense` uses `Offscreen` tag internally and that turns off
`disableStrictPassiveEffect` for everything.

DiffTrain build for [70e998a106](https://github.com/facebook/react/commit/70e998a1064cc1e8e8f9103e0c00d37fbbcf71c1)
This commit is contained in:
tyao1
2023-06-22 20:18:31 +00:00
parent ec1a04575d
commit b52e425597
10 changed files with 10 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiled/facebook-www/REVISION
+1 -1
View File
@@ -1 +1 @@
254cbdbd6d851a30bf3b649a6cb7c52786766fa4
70e998a1064cc1e8e8f9103e0c00d37fbbcf71c1
compiled/facebook-www/React-prod.modern.js
+1 -1
View File
@@ -641,4 +641,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-www-modern-f829eef9";
exports.version = "18.3.0-www-modern-f3a022db";
compiled/facebook-www/ReactART-dev.classic.js
+1 -6
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-classic-786512bb";
var ReactVersion = "18.3.0-www-classic-218ac23d";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -28292,11 +28292,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
compiled/facebook-www/ReactART-dev.modern.js
+1 -6
View File
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}
var ReactVersion = "18.3.0-www-modern-34b19309";
var ReactVersion = "18.3.0-www-modern-a0074376";
var LegacyRoot = 0;
var ConcurrentRoot = 1;
@@ -27952,11 +27952,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
compiled/facebook-www/ReactDOM-dev.classic.js
+1 -6
View File
@@ -33919,11 +33919,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -34214,7 +34209,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0b2d04c1";
var ReactVersion = "18.3.0-www-classic-ea62c16d";
function createPortal$1(
children,
compiled/facebook-www/ReactDOM-dev.modern.js
+1 -6
View File
@@ -33764,11 +33764,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -34059,7 +34054,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-34b19309";
var ReactVersion = "18.3.0-www-modern-a0074376";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-dev.classic.js
+1 -6
View File
@@ -34536,11 +34536,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -34831,7 +34826,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0b64f941";
var ReactVersion = "18.3.0-www-classic-3f09ab7a";
function createPortal$1(
children,
compiled/facebook-www/ReactDOMTesting-dev.modern.js
+1 -6
View File
@@ -34381,11 +34381,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -34676,7 +34671,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-60605377";
var ReactVersion = "18.3.0-www-modern-f6368a4e";
function createPortal$1(
children,
compiled/facebook-www/ReactTestRenderer-dev.classic.js
+1 -6
View File
@@ -24392,11 +24392,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -24565,7 +24560,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-classic-0b64f941";
var ReactVersion = "18.3.0-www-classic-3f09ab7a";
// Might add PROFILE later.
compiled/facebook-www/ReactTestRenderer-dev.modern.js
+1 -6
View File
@@ -24392,11 +24392,6 @@ function createFiberFromSuspenseList(pendingProps, mode, lanes, key) {
return fiber;
}
function createFiberFromOffscreen(pendingProps, mode, lanes, key) {
{
// StrictMode in Offscreen should always run double passive effects
mode &= ~NoStrictPassiveEffectsMode;
}
var fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
fiber.elementType = REACT_OFFSCREEN_TYPE;
fiber.lanes = lanes;
@@ -24565,7 +24560,7 @@ function createFiberRoot(
return root;
}
var ReactVersion = "18.3.0-www-modern-f829eef9";
var ReactVersion = "18.3.0-www-modern-f3a022db";
// Might add PROFILE later.