Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure attribute values are strings

Browse Source 
`jsdom` behavers differently than browsers here and we should ensure
that we are consistent. Browsers should be (and are) converting to
a string first, while `jsdom` doesn't.
This commit is contained in:
Paul O'Shannessy
2013-10-15 10:39:51 -07:00
committed by Paul O’Shannessy
parent 287f5b578c
commit b0455f4670
2 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/dom/DOMPropertyOperations.js
+2 -2
View File
@@ -109,7 +109,7 @@ var DOMPropertyOperations = {
if (DOMProperty.hasBooleanValue[name] && !value) {
node.removeAttribute(DOMProperty.getAttributeName[name]);
} else {
node.setAttribute(DOMProperty.getAttributeName[name], value);
node.setAttribute(DOMProperty.getAttributeName[name], '' + value);
}
} else {
var propName = DOMProperty.getPropertyName[name];
@@ -118,7 +118,7 @@ var DOMPropertyOperations = {
}
}
} else if (DOMProperty.isCustomAttribute(name)) {
node.setAttribute(name, value);
node.setAttribute(name, '' + value);
} else if (__DEV__) {
warnUnknownProperty(name);
}
src/dom/__tests__/DOMPropertyOperations-test.js
+8
View File
@@ -132,6 +132,14 @@ describe('DOMPropertyOperations', function() {
expect(stubNode.role).toBeUndefined();
});
it('should convert attribute values to string first', function() {
// Browsers default to this behavior, but some test environments do not.
// This ensures that we have consistent behavior.
var obj = {toString: function() { return '<html>'; }};
DOMPropertyOperations.setValueForProperty(stubNode, 'role', obj);
expect(stubNode.getAttribute('role')).toBe('<html>');
});
it('should remove for falsey boolean properties', function() {
DOMPropertyOperations.setValueForProperty(
stubNode,