mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Consume the RSC stream twice in the Flight fixture (#28353)
We have an unresolved conflict where the Flight client wants to execute inside Fizz to emit side-effects like preloads (which can be early) into that stream. However, the FormState API requires the state to be passed at the root, so if you're getting that through the RSC payload it's a Catch 22. #27314 used a hack to mutate the form state array to fill it in later, but that doesn't actually work because it's not always an array. It's sometimes null like if there wasn't a POST. This lead to a bunch of hydration errors - which doesn't have the best error message for this case neither. It probably should error with something that specifies that it's form state. This fixes it by teeing the stream into two streams and consuming it with two Flight clients. One to read the form state and one to emit side-effects and read the root. DiffTrain build for commit https://github.com/facebook/react/commit/6a44f352ecdfa93949cade1d2e74755e7d7e9aaa.
This commit is contained in:
+1
-1
@@ -25633,7 +25633,7 @@ if (__DEV__) {
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-canary-ef72271c2-20240216";
|
||||
var ReactVersion = "18.3.0-canary-6a44f352e-20240216";
|
||||
|
||||
// Might add PROFILE later.
|
||||
|
||||
|
||||
+2
-2
@@ -9179,7 +9179,7 @@ var devToolsConfig$jscomp$inline_1018 = {
|
||||
throw Error("TestRenderer does not support findFiberByHostInstance()");
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-canary-ef72271c2-20240216",
|
||||
version: "18.3.0-canary-6a44f352e-20240216",
|
||||
rendererPackageName: "react-test-renderer"
|
||||
};
|
||||
var internals$jscomp$inline_1199 = {
|
||||
@@ -9210,7 +9210,7 @@ var internals$jscomp$inline_1199 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-canary-ef72271c2-20240216"
|
||||
reconcilerVersion: "18.3.0-canary-6a44f352e-20240216"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1200 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
+2
-2
@@ -9607,7 +9607,7 @@ var devToolsConfig$jscomp$inline_1060 = {
|
||||
throw Error("TestRenderer does not support findFiberByHostInstance()");
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-canary-ef72271c2-20240216",
|
||||
version: "18.3.0-canary-6a44f352e-20240216",
|
||||
rendererPackageName: "react-test-renderer"
|
||||
};
|
||||
var internals$jscomp$inline_1240 = {
|
||||
@@ -9638,7 +9638,7 @@ var internals$jscomp$inline_1240 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-canary-ef72271c2-20240216"
|
||||
reconcilerVersion: "18.3.0-canary-6a44f352e-20240216"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1241 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
+1
-1
@@ -24,7 +24,7 @@ if (__DEV__) {
|
||||
) {
|
||||
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
|
||||
}
|
||||
var ReactVersion = "18.3.0-canary-ef72271c2-20240216";
|
||||
var ReactVersion = "18.3.0-canary-6a44f352e-20240216";
|
||||
|
||||
// ATTENTION
|
||||
// When adding new symbols to this file,
|
||||
|
||||
+1
-1
@@ -590,4 +590,4 @@ exports.useSyncExternalStore = function (
|
||||
exports.useTransition = function () {
|
||||
return ReactCurrentDispatcher.current.useTransition();
|
||||
};
|
||||
exports.version = "18.3.0-canary-ef72271c2-20240216";
|
||||
exports.version = "18.3.0-canary-6a44f352e-20240216";
|
||||
|
||||
+1
-1
@@ -586,7 +586,7 @@ exports.useSyncExternalStore = function (
|
||||
exports.useTransition = function () {
|
||||
return ReactCurrentDispatcher.current.useTransition();
|
||||
};
|
||||
exports.version = "18.3.0-canary-ef72271c2-20240216";
|
||||
exports.version = "18.3.0-canary-6a44f352e-20240216";
|
||||
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
|
||||
"function" ===
|
||||
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
|
||||
|
||||
+1
-1
@@ -1 +1 @@
|
||||
ef72271c2d1234c9d1e1358f8083021089a50faa
|
||||
6a44f352ecdfa93949cade1d2e74755e7d7e9aaa
|
||||
|
||||
Reference in New Issue
Block a user