Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove keyMirror in ComponentLifeCycle (#7591)

Browse Source 
See rationale in https://www.facebook.com/groups/2003630259862046/permalink/2097088000516271/
This commit is contained in:
Christopher Chedeau
2016-08-28 10:30:33 -07:00
committed by GitHub
parent 84084153ed
commit a35387c030
1 changed files with 15 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderers/shared/stack/reconciler/__tests__/ReactComponentLifeCycle-test.js
+15 -18
View File
@@ -11,8 +11,6 @@
'use strict';
var keyMirror = require('keyMirror');
var React;
var ReactDOM;
var ReactInstanceMap;
@@ -68,25 +66,24 @@ var POST_WILL_UNMOUNT_STATE = {
/**
* Every React component is in one of these life cycles.
*/
var ComponentLifeCycle = keyMirror({
type ComponentLifeCycle =
/**
* Mounted components have a DOM node representation and are capable of
* receiving new props.
*/
MOUNTED: null,
'MOUNTED' |
/**
* Unmounted components are inactive and cannot receive new props.
*/
UNMOUNTED: null,
});
'UNMOUNTED';
function getLifeCycleState(instance) {
function getLifeCycleState(instance): ComponentLifeCycle {
var internalInstance = ReactInstanceMap.get(instance);
// Once a component gets mounted, it has an internal instance, once it
// gets unmounted, it loses that internal instance.
return internalInstance ?
ComponentLifeCycle.MOUNTED :
ComponentLifeCycle.UNMOUNTED;
'MOUNTED' :
'UNMOUNTED';
}
/**
@@ -407,30 +404,30 @@ describe('ReactComponentLifeCycle', function() {
GET_INIT_STATE_RETURN_VAL
);
expect(instance._testJournal.lifeCycleAtStartOfGetInitialState)
.toBe(ComponentLifeCycle.UNMOUNTED);
.toBe('UNMOUNTED');
// componentWillMount
expect(instance._testJournal.stateAtStartOfWillMount).toEqual(
instance._testJournal.returnedFromGetInitialState
);
expect(instance._testJournal.lifeCycleAtStartOfWillMount)
.toBe(ComponentLifeCycle.MOUNTED);
.toBe('MOUNTED');
// componentDidMount
expect(instance._testJournal.stateAtStartOfDidMount)
.toEqual(DID_MOUNT_STATE);
expect(instance._testJournal.lifeCycleAtStartOfDidMount).toBe(
ComponentLifeCycle.MOUNTED
'MOUNTED'
);
// render
expect(instance._testJournal.stateInInitialRender)
.toEqual(INIT_RENDER_STATE);
expect(instance._testJournal.lifeCycleInInitialRender).toBe(
ComponentLifeCycle.MOUNTED
'MOUNTED'
);
expect(getLifeCycleState(instance)).toBe(ComponentLifeCycle.MOUNTED);
expect(getLifeCycleState(instance)).toBe('MOUNTED');
// Now *update the component*
instance.forceUpdate();
@@ -439,10 +436,10 @@ describe('ReactComponentLifeCycle', function() {
expect(instance._testJournal.stateInLaterRender)
.toEqual(NEXT_RENDER_STATE);
expect(instance._testJournal.lifeCycleInLaterRender).toBe(
ComponentLifeCycle.MOUNTED
'MOUNTED'
);
expect(getLifeCycleState(instance)).toBe(ComponentLifeCycle.MOUNTED);
expect(getLifeCycleState(instance)).toBe('MOUNTED');
ReactDOM.unmountComponentAtNode(container);
@@ -450,11 +447,11 @@ describe('ReactComponentLifeCycle', function() {
.toEqual(WILL_UNMOUNT_STATE);
// componentWillUnmount called right before unmount.
expect(instance._testJournal.lifeCycleAtStartOfWillUnmount).toBe(
ComponentLifeCycle.MOUNTED
'MOUNTED'
);
// But the current lifecycle of the component is unmounted.
expect(getLifeCycleState(instance)).toBe(ComponentLifeCycle.UNMOUNTED);
expect(getLifeCycleState(instance)).toBe('UNMOUNTED');
expect(instance.state).toEqual(POST_WILL_UNMOUNT_STATE);
});