Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[easy] remove isFallthrough arg from mapTerminalSuccessors

Browse Source 
The argument was unused and a confusing boolean argument that's easy to mix up. 
Suggesting to remove it until we see a need for it at which point we might want 
to introduce an enum to make the argument more obvious.
This commit is contained in:
Jan Kassens
2022-11-28 17:48:59 -05:00
parent 0bbb36e1a4
commit 9f7878c7c0
1 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/HIR/visitors.ts
+10 -10
View File
@@ -146,11 +146,11 @@ export function mapInstructionOperands(
*/
export function mapTerminalSuccessors(
terminal: Terminal,
fn: (block: BlockId, isFallthrough: boolean) => BlockId
fn: (block: BlockId) => BlockId
): Terminal {
switch (terminal.kind) {
case "goto": {
const target = fn(terminal.block, false);
const target = fn(terminal.block);
return {
kind: "goto",
block: target,
@@ -159,10 +159,10 @@ export function mapTerminalSuccessors(
};
}
case "if": {
const consequent = fn(terminal.consequent, false);
const alternate = fn(terminal.alternate, false);
const consequent = fn(terminal.consequent);
const alternate = fn(terminal.alternate);
const fallthrough =
terminal.fallthrough !== null ? fn(terminal.fallthrough, true) : null;
terminal.fallthrough !== null ? fn(terminal.fallthrough) : null;
return {
kind: "if",
test: terminal.test,
@@ -174,14 +174,14 @@ export function mapTerminalSuccessors(
}
case "switch": {
const cases = terminal.cases.map((case_) => {
const target = fn(case_.block, false);
const target = fn(case_.block);
return {
test: case_.test,
block: target,
};
});
const fallthrough =
terminal.fallthrough !== null ? fn(terminal.fallthrough, true) : null;
terminal.fallthrough !== null ? fn(terminal.fallthrough) : null;
return {
kind: "switch",
test: terminal.test,
@@ -202,9 +202,9 @@ export function mapTerminalSuccessors(
return terminal;
}
case "while": {
const test = fn(terminal.test, false);
const loop = fn(terminal.loop, true);
const fallthrough = fn(terminal.fallthrough, true);
const test = fn(terminal.test);
const loop = fn(terminal.loop);
const fallthrough = fn(terminal.fallthrough);
return {
kind: "while",
loc: terminal.loc,