Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove ReactTestUtils from refs-destruction-test (#28532)

Browse Source 
```diff
-expect(ReactTestUtils.isDOMComponent(maybeElement)).toBe(true);
+expect(maybeElement).toBeInstanceOf(Element);
```

It's not equivalent since `isDOMComponent` checks `maybeElement.nodeType
=== Element.ELEMENT_NODE && !!maybeElement.tagName` but `instanceof`
check seems sufficient here. Checking `nodeType` is mostly for
cross-realm checks and checking falsy `tagName` seems like a check
specifically for incomplete DOM implementations because tagName can't be
empty by spec I believe.
This commit is contained in:
Sebastian Silbermann
2024-03-11 22:11:40 +01:00
committed by GitHub
parent 58cd0ef35d
commit 9c48fb25ec
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-dom/src/__tests__/refs-destruction-test.js
Vendored
+3 -5
View File
@@ -12,7 +12,6 @@
let React;
let ReactDOM;
let ReactDOMClient;
let ReactTestUtils;
let TestComponent;
let act;
let theInnerDivRef;
@@ -25,7 +24,6 @@ describe('refs-destruction', () => {
React = require('react');
ReactDOM = require('react-dom');
ReactDOMClient = require('react-dom/client');
ReactTestUtils = require('react-dom/test-utils');
act = require('internal-test-utils').act;
class ClassComponent extends React.Component {
@@ -75,7 +73,7 @@ describe('refs-destruction', () => {
root.render(<TestComponent />);
});
expect(ReactTestUtils.isDOMComponent(theInnerDivRef.current)).toBe(true);
expect(theInnerDivRef.current).toBeInstanceOf(Element);
expect(theInnerClassComponentRef.current).toBeTruthy();
root.unmount();
@@ -91,7 +89,7 @@ describe('refs-destruction', () => {
root.render(<TestComponent />);
});
expect(ReactTestUtils.isDOMComponent(theInnerDivRef.current)).toBe(true);
expect(theInnerDivRef.current).toBeInstanceOf(Element);
expect(theInnerClassComponentRef.current).toBeTruthy();
await act(async () => {
@@ -109,7 +107,7 @@ describe('refs-destruction', () => {
root.render(<TestComponent />);
});
expect(ReactTestUtils.isDOMComponent(theInnerDivRef.current)).toBe(true);
expect(theInnerDivRef.current).toBeInstanceOf(Element);
expect(theInnerClassComponentRef.current).toBeTruthy();
await act(async () => {