mirror of
https://github.com/facebook/react.git
synced 2025-11-01 09:12:30 +00:00
Only restore Yarn caches on exact key hits (#26133)
## Summary
[Current Yarn cache size:
555MB](https://app.circleci.com/pipelines/github/facebook/react/38163/workflows/70d0149e-b0bc-44e8-b8c9-e5c744cab89b/jobs/625334?invite=true#step-102-2)
[Used Yarn cache size:
344MB](https://app.circleci.com/pipelines/github/facebook/react/38166/workflows/4825d444-1426-4321-b95b-c540e6cdc6d7/jobs/625354?invite=true#step-104-5)
When we restore a global Yarn cache that's not specific to a lockfile
entry (i.e. a fallback cache), we might restore packages that are no
longer used. When we then run yarn install, we potentially add new
packages to the cache.
For example:
1. we bump a package version
2. lockfile changes
3. cache restore misses for exact key
4. cache restore hits a prefix (fallback) containing the older version,
5. yarn install adds the new version to the cache
Yarn is not clearing the unused packages from the global cache. So when
we then save the cache we now retain the old and new version of a
package in the global cache even though the old version is no longer
used.
This means that the global cache grows indefinitely. Restoring the cache
isn't free so CI install times will degrade over time.
Either we
1. periodically prune the cache
2. just not restore anything unless we have an exact hit.
The chosen tradeoff depends on the
relation of commits changing deps to commits not changing deps.
From my experience, we change deps rarely so I opted to only restore the
cache on exact hits.
## How did you test this change?
- run on `main` has 555MB of Yarn cache:
https://app.circleci.com/pipelines/github/facebook/react/38163/workflows/70d0149e-b0bc-44e8-b8c9-e5c744cab89b/jobs/625334?invite=true#step-102-2
- run on this branch only has 334MB of Yarn cache:
https://app.circleci.com/pipelines/github/facebook/react/38166/workflows/4825d444-1426-4321-b95b-c540e6cdc6d7/jobs/625354?invite=true#step-104-5
DiffTrain build for [c0b0b3a9f8](https://github.com/facebook/react/commit/c0b0b3a9f80fd57e882859afd95c2f08599442ba)
[View git log for this commit](https://github.com/facebook/react/commits/c0b0b3a9f80fd57e882859afd95c2f08599442ba)
This commit is contained in:
eps1lon
@@ -1 +1 @@
|
||||
28fcae062bff2b611cd935911f8666b0627b9551
|
||||
c0b0b3a9f80fd57e882859afd95c2f08599442ba
|
||||
|
||||
@@ -1 +1 @@
|
||||
28fcae062bff2b611cd935911f8666b0627b9551
|
||||
c0b0b3a9f80fd57e882859afd95c2f08599442ba
|
||||
|
||||
@@ -27,7 +27,7 @@ if (
|
||||
}
|
||||
"use strict";
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
// ATTENTION
|
||||
// When adding new symbols to this file,
|
||||
|
||||
@@ -27,7 +27,7 @@ if (
|
||||
}
|
||||
"use strict";
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
// ATTENTION
|
||||
// When adding new symbols to this file,
|
||||
|
||||
@@ -646,4 +646,4 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-classic-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -638,4 +638,4 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-modern-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -657,7 +657,7 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-classic-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -649,7 +649,7 @@ exports.useSyncExternalStore = function (
|
||||
);
|
||||
};
|
||||
exports.useTransition = useTransition;
|
||||
exports.version = "18.3.0-www-modern-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
|
||||
return self;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
var LegacyRoot = 0;
|
||||
var ConcurrentRoot = 1;
|
||||
|
||||
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
|
||||
return self;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
var LegacyRoot = 0;
|
||||
var ConcurrentRoot = 1;
|
||||
|
||||
@@ -9845,7 +9845,7 @@ var slice = Array.prototype.slice,
|
||||
return null;
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-28fcae062-20230209",
|
||||
version: "18.3.0-www-classic-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-art"
|
||||
};
|
||||
var internals$jscomp$inline_1318 = {
|
||||
@@ -9876,7 +9876,7 @@ var internals$jscomp$inline_1318 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
@@ -9510,7 +9510,7 @@ var slice = Array.prototype.slice,
|
||||
return null;
|
||||
},
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-28fcae062-20230209",
|
||||
version: "18.3.0-www-modern-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-art"
|
||||
};
|
||||
var internals$jscomp$inline_1309 = {
|
||||
@@ -9541,7 +9541,7 @@ var internals$jscomp$inline_1309 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
|
||||
@@ -42698,7 +42698,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -42422,7 +42422,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -15575,7 +15575,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1750 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-28fcae062-20230209",
|
||||
version: "18.3.0-www-classic-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2134 = {
|
||||
@@ -15605,7 +15605,7 @@ var internals$jscomp$inline_2134 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2135 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -15853,4 +15853,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -15136,7 +15136,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1718 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-28fcae062-20230209",
|
||||
version: "18.3.0-www-modern-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2109 = {
|
||||
@@ -15167,7 +15167,7 @@ var internals$jscomp$inline_2109 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -15355,4 +15355,4 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -16345,7 +16345,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1824 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-28fcae062-20230209",
|
||||
version: "18.3.0-www-classic-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
(function (internals) {
|
||||
@@ -16389,7 +16389,7 @@ var devToolsConfig$jscomp$inline_1824 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
});
|
||||
assign(Internals, {
|
||||
ReactBrowserEventEmitter: {
|
||||
@@ -16624,7 +16624,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -15896,7 +15896,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1792 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-28fcae062-20230209",
|
||||
version: "18.3.0-www-modern-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
(function (internals) {
|
||||
@@ -15941,7 +15941,7 @@ var devToolsConfig$jscomp$inline_1792 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
});
|
||||
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
|
||||
exports.createPortal = function (children, container) {
|
||||
@@ -16116,7 +16116,7 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
|
||||
if (
|
||||
|
||||
@@ -19,7 +19,7 @@ if (__DEV__) {
|
||||
var React = require("react");
|
||||
var ReactDOM = require("react-dom");
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
// This refers to a WWW module.
|
||||
var warningWWW = require("warning");
|
||||
|
||||
@@ -19,7 +19,7 @@ if (__DEV__) {
|
||||
var React = require("react");
|
||||
var ReactDOM = require("react-dom");
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
// This refers to a WWW module.
|
||||
var warningWWW = require("warning");
|
||||
|
||||
@@ -3634,4 +3634,4 @@ exports.renderToString = function (children, options) {
|
||||
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
|
||||
);
|
||||
};
|
||||
exports.version = "18.3.0-www-classic-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -3548,4 +3548,4 @@ exports.renderToString = function (children, options) {
|
||||
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
|
||||
);
|
||||
};
|
||||
exports.version = "18.3.0-www-modern-28fcae062-20230209";
|
||||
exports.version = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -31215,7 +31215,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -38517,7 +38517,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
function createPortal(
|
||||
children,
|
||||
|
||||
@@ -11356,7 +11356,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1518 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-classic-28fcae062-20230209",
|
||||
version: "18.3.0-www-classic-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2047 = {
|
||||
@@ -11386,7 +11386,7 @@ var internals$jscomp$inline_2047 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2048 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -14903,4 +14903,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
|
||||
);
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -14007,7 +14007,7 @@ Internals.Events = [
|
||||
var devToolsConfig$jscomp$inline_1673 = {
|
||||
findFiberByHostInstance: getClosestInstanceFromNode,
|
||||
bundleType: 0,
|
||||
version: "18.3.0-www-modern-28fcae062-20230209",
|
||||
version: "18.3.0-www-modern-c0b0b3a9f-20230209",
|
||||
rendererPackageName: "react-dom"
|
||||
};
|
||||
var internals$jscomp$inline_2072 = {
|
||||
@@ -14038,7 +14038,7 @@ var internals$jscomp$inline_2072 = {
|
||||
scheduleRoot: null,
|
||||
setRefreshHandler: null,
|
||||
getCurrentFiber: null,
|
||||
reconcilerVersion: "18.3.0-next-28fcae062-20230209"
|
||||
reconcilerVersion: "18.3.0-next-c0b0b3a9f-20230209"
|
||||
};
|
||||
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
|
||||
var hook$jscomp$inline_2073 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
|
||||
@@ -14369,4 +14369,4 @@ exports.unstable_flushControlled = function (fn) {
|
||||
}
|
||||
};
|
||||
exports.unstable_runWithPriority = runWithPriority;
|
||||
exports.version = "18.3.0-next-28fcae062-20230209";
|
||||
exports.version = "18.3.0-next-c0b0b3a9f-20230209";
|
||||
|
||||
@@ -23911,7 +23911,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-classic-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-classic-c0b0b3a9f-20230209";
|
||||
|
||||
// Might add PROFILE later.
|
||||
|
||||
|
||||
@@ -23911,7 +23911,7 @@ function createFiberRoot(
|
||||
return root;
|
||||
}
|
||||
|
||||
var ReactVersion = "18.3.0-www-modern-28fcae062-20230209";
|
||||
var ReactVersion = "18.3.0-www-modern-c0b0b3a9f-20230209";
|
||||
|
||||
// Might add PROFILE later.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user