Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correctly check that element and props are frozen

Browse Source 
This fixes an incorrect way of checking introduced in 95373ce769 (it had no effect).
This commit is contained in:
Dan Abramov
2016-05-26 01:08:29 +01:00
parent a432afa750
commit 919eba3c99
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/isomorphic/classic/element/__tests__/ReactElement-test.js
+12 -6
View File
@@ -53,7 +53,8 @@ describe('ReactElement', function() {
expect(element.key).toBe(null);
expect(element.ref).toBe(null);
var expectation = {};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
@@ -121,7 +122,8 @@ describe('ReactElement', function() {
expect(element.key).toBe(null);
expect(element.ref).toBe(null);
var expectation = {};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
@@ -166,7 +168,8 @@ describe('ReactElement', function() {
expect(element.key).toBe('12');
expect(element.ref).toBe('34');
var expectation = {foo: '56'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
@@ -180,7 +183,8 @@ describe('ReactElement', function() {
expect(element.key).toBe('null');
expect(element.ref).toBe(null);
var expectation = {foo: '12'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
@@ -195,7 +199,8 @@ describe('ReactElement', function() {
expect(element.key).toBe(null);
expect(element.ref).toBe(null);
var expectation = {foo: '56'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
@@ -215,7 +220,8 @@ describe('ReactElement', function() {
expect(element.key).toBe('12');
expect(element.ref).toBe(null);
var expectation = {foo: '56'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(element.props).toEqual(expectation);
});
src/isomorphic/classic/element/__tests__/ReactElementClone-test.js
+4 -2
View File
@@ -345,7 +345,8 @@ describe('ReactElementClone', function() {
expect(clone.key).toBe('12');
expect(clone.ref).toBe('34');
var expectation = {foo: 'ef'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(clone.props).toEqual(expectation);
});
@@ -365,7 +366,8 @@ describe('ReactElementClone', function() {
expect(clone.key).toBe('null');
expect(clone.ref).toBe(null);
var expectation = {foo: 'ef'};
Object.freeze(expectation);
expect(Object.isFrozen(element)).toBe(true);
expect(Object.isFrozen(element.props)).toBe(true);
expect(clone.props).toEqual(expectation);
});