Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed Array.from() usage (#12546)

Browse Source
This commit is contained in:
Brian Vaughn
2018-04-04 13:54:27 -07:00
committed by GitHub
parent d328e362e8
commit 8ec0e4a99d
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactStrictModeWarnings.js
Vendored
+12 -12
View File
@@ -46,6 +46,14 @@ if (__DEV__) {
const didWarnAboutDeprecatedLifecycles = new Set();
const didWarnAboutUnsafeLifecycles = new Set();
const setToSortedString = set => {
const array = [];
set.forEach(value => {
array.push(value);
});
return array.sort().join(', ');
};
ReactStrictModeWarnings.discardPendingWarnings = () => {
pendingComponentWillMountWarnings = [];
pendingComponentWillReceivePropsWarnings = [];
@@ -69,9 +77,7 @@ if (__DEV__) {
const formatted = lifecycle.replace('UNSAFE_', '');
const suggestion = LIFECYCLE_SUGGESTIONS[lifecycle];
const sortedComponentNames = Array.from(componentNames)
.sort()
.join(', ');
const sortedComponentNames = setToSortedString(componentNames);
lifecyclesWarningMesages.push(
`${formatted}: Please update the following components to use ` +
@@ -123,9 +129,7 @@ if (__DEV__) {
didWarnAboutDeprecatedLifecycles.add(fiber.type);
});
const sortedNames = Array.from(uniqueNames)
.sort()
.join(', ');
const sortedNames = setToSortedString(uniqueNames);
lowPriorityWarning(
false,
@@ -148,9 +152,7 @@ if (__DEV__) {
didWarnAboutDeprecatedLifecycles.add(fiber.type);
});
const sortedNames = Array.from(uniqueNames)
.sort()
.join(', ');
const sortedNames = setToSortedString(uniqueNames);
lowPriorityWarning(
false,
@@ -172,9 +174,7 @@ if (__DEV__) {
didWarnAboutDeprecatedLifecycles.add(fiber.type);
});
const sortedNames = Array.from(uniqueNames)
.sort()
.join(', ');
const sortedNames = setToSortedString(uniqueNames);
lowPriorityWarning(
false,