Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add unknown property warning for use of autofocus" (#7684)

Browse Source
This commit is contained in:
Paul O’Shannessy
2016-09-08 13:43:57 -07:00
committed by GitHub
parent 73c50e7d00
commit 8debf524df
2 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderers/dom/shared/HTMLDOMPropertyConfig.js
+1 -2
View File
@@ -41,7 +41,7 @@ var HTMLDOMPropertyConfig = {
async: HAS_BOOLEAN_VALUE,
autoComplete: 0,
// autoFocus is polyfilled/normalized by AutoFocusUtils
autoFocus: HAS_BOOLEAN_VALUE,
// autoFocus: HAS_BOOLEAN_VALUE,
autoPlay: HAS_BOOLEAN_VALUE,
capture: HAS_BOOLEAN_VALUE,
cellPadding: 0,
@@ -205,7 +205,6 @@ var HTMLDOMPropertyConfig = {
},
DOMAttributeNames: {
acceptCharset: 'accept-charset',
autoFocus: 'autofocus',
className: 'class',
htmlFor: 'for',
httpEquiv: 'http-equiv',
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
-17
View File
@@ -1495,22 +1495,5 @@ describe('ReactDOMComponent', () => {
//since hard coding the line number would make test too brittle
expect(parseInt(previousLine, 10) + 12).toBe(parseInt(currentLine, 10));
});
it('should suggest property name if available', () => {
spyOn(console, 'error');
ReactTestUtils.renderIntoDocument(React.createElement('label', {for: 'test'}));
ReactTestUtils.renderIntoDocument(React.createElement('input', {type: 'text', autofocus: true}));
expect(console.error.calls.count()).toBe(2);
expect(console.error.calls.argsFor(0)[0]).toBe(
'Warning: Unknown DOM property for. Did you mean htmlFor?\n in label'
);
expect(console.error.calls.argsFor(1)[0]).toBe(
'Warning: Unknown DOM property autofocus. Did you mean autoFocus?\n in input'
);
});
});
});