Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prep for destructuring, factor out lowerIdentifier()

Browse Source
This commit is contained in:
Joe Savona
2022-12-20 16:57:13 -08:00
parent 079cfe68bf
commit 836211a549
1 changed files with 28 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/HIR/BuildHIR.ts
+28 -20
View File
@@ -723,7 +723,7 @@ function lowerExpression(
switch (exprNode.type) {
case "Identifier": {
const expr = exprPath as NodePath<t.Identifier>;
return lowerLVal(builder, expr);
return lowerIdentifier(builder, expr);
}
case "NullLiteral": {
return {
@@ -1285,30 +1285,38 @@ function lowerExpressionToVoid(
});
}
function lowerIdentifier(
builder: HIRBuilder,
exprPath: NodePath<t.Identifier>
): Place {
const exprNode = exprPath.node;
const exprLoc = exprNode.loc ?? GeneratedSource;
const binding =
exprPath.scope.getBindingIdentifier(exprNode.name) ??
getOrAddGlobal(exprNode.name);
invariant(
binding != null,
`Expected to find a binding for variable '%s'`,
exprNode.name
);
const identifier = builder.resolveIdentifier(binding);
const place: Place = {
kind: "Identifier",
identifier: identifier,
memberPath: null,
effect: Effect.Unknown,
loc: exprLoc,
};
return place;
}
function lowerLVal(builder: HIRBuilder, exprPath: NodePath<t.LVal>): Place {
const exprNode = exprPath.node;
const exprLoc = exprNode.loc ?? GeneratedSource;
switch (exprNode.type) {
case "Identifier": {
// const expr = exprPath as NodePath<t.Identifier>;
// const name: string = expr.get("name");
const binding =
exprPath.scope.getBindingIdentifier(exprNode.name) ??
getOrAddGlobal(exprNode.name);
invariant(
binding != null,
`Expected to find a binding for variable '%s'`,
exprNode.name
);
const identifier = builder.resolveIdentifier(binding);
const place: Place = {
kind: "Identifier",
identifier: identifier,
memberPath: null,
effect: Effect.Unknown,
loc: exprLoc,
};
return place;
const expr = exprPath as NodePath<t.Identifier>;
return lowerIdentifier(builder, expr);
}
case "MemberExpression": {
const expr = exprPath as NodePath<t.MemberExpression>;