Promote inlineUseMemo to stable (remove flag)

Per title, this feature flag is enabled everywhere and is clearly stable, let's 
promote to stable and remove the flag to simplify.
This commit is contained in:
Joe Savona
2023-10-05 09:20:19 -07:00
parent 3fdb237682
commit 80d867d1bd
3 changed files with 2 additions and 18 deletions
@@ -114,7 +114,6 @@ function parsePragma(pragma: string) {
let disableAllMemoization = false;
let validateRefAccessDuringRender = true;
let enableEmitFreeze = null;
let inlineUseMemo = true;
let validateHooksUsage = true;
let validateFrozenLambdas = true;
let assertValidMutableRanges = true;
@@ -137,9 +136,6 @@ function parsePragma(pragma: string) {
importSpecifierName: "makeReadOnly",
};
}
if (pragma.includes("@inlineUseMemo false")) {
inlineUseMemo = false;
}
if (pragma.includes("@validateHooksUsage false")) {
validateHooksUsage = false;
}
@@ -153,7 +149,6 @@ function parsePragma(pragma: string) {
return {
enableAssumeHooksFollowRulesOfReact,
disableAllMemoization,
inlineUseMemo,
memoizeJsxElements,
validateHooksUsage,
validateRefAccessDuringRender,
@@ -106,10 +106,8 @@ function* runWithEnvironment(
pruneMaybeThrows(hir);
yield log({ kind: "hir", name: "PruneMaybeThrows", value: hir });
if (env.config.inlineUseMemo) {
inlineUseMemo(hir);
yield log({ kind: "hir", name: "RewriteUseMemo", value: hir });
}
inlineUseMemo(hir);
yield log({ kind: "hir", name: "RewriteUseMemo", value: hir });
mergeConsecutiveBlocks(hir);
yield log({ kind: "hir", name: "MergeConsecutiveBlocks", value: hir });
@@ -132,14 +132,6 @@ export type EnvironmentConfig = {
*/
validateNoSetStateInRender: boolean;
/**
* Enable inlining of `useMemo()` function expressions so that they can be more optimally
* compiled.
*
* Defaults to false
*/
inlineUseMemo: boolean;
/**
* When enabled, the compiler assumes that hooks follow the Rules of React:
* - Hooks may memoize computation based on any of their parameters, thus
@@ -224,7 +216,6 @@ const DEFAULT_ENVIRONMENT_CONFIG: Readonly<EnvironmentConfig> = {
customHooks: null,
memoizeJsxElements: true,
inlineUseMemo: true,
validateHooksUsage: true,
assertValidMutableRanges: false,