Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ez] Hooks dont escape, their args do

Browse Source
This commit is contained in:
Joe Savona
2023-05-31 16:05:07 -07:00
parent 0ae37f1568
commit 7fddf42d06
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
compiler/forget/src/ReactiveScopes/PruneNonEscapingScopes.ts
+3 -3
View File
@@ -25,7 +25,6 @@ import {
getHookKind,
isMutableEffect,
} from "../HIR";
import { eachInstructionValueOperand } from "../HIR/visitors";
import { log } from "../Utils/logger";
import { assertExhaustive } from "../Utils/utils";
import { getPlaceScope } from "./BuildReactiveBlocks";
@@ -722,8 +721,9 @@ class CollectDependenciesVisitor extends ReactiveFunctionVisitor<State> {
} else if (instruction.value.kind === "CallExpression") {
const callee = instruction.value.callee;
if (getHookKind(state.env, callee.identifier)) {
for (const operand of eachInstructionValueOperand(instruction.value)) {
state.escapingValues.add(operand.identifier.id);
for (const operand of instruction.value.args) {
const place = operand.kind === "Spread" ? operand.place : operand;
state.escapingValues.add(place.identifier.id);
}
}
}