Make new perf unit test pass

This commit is contained in:
Ben Alpert
2015-09-27 14:26:26 -07:00
parent 47de0a8ce6
commit 7938650ca9
8 changed files with 40 additions and 5 deletions
@@ -16,6 +16,7 @@ var EventConstants = require('EventConstants');
var EventPluginHub = require('EventPluginHub');
var EventPluginRegistry = require('EventPluginRegistry');
var ReactEventEmitterMixin = require('ReactEventEmitterMixin');
var ReactPerf = require('ReactPerf');
var ViewportMetrics = require('ViewportMetrics');
var assign = require('Object.assign');
@@ -373,4 +374,9 @@ var ReactBrowserEventEmitter = assign({}, ReactEventEmitterMixin, {
});
ReactPerf.measureMethods(ReactBrowserEventEmitter, 'ReactBrowserEventEmitter', {
putListener: 'putListener',
deleteListener: 'deleteListener',
});
module.exports = ReactBrowserEventEmitter;
@@ -92,7 +92,6 @@ var ReactDOMIDOperations = {
};
ReactPerf.measureMethods(ReactDOMIDOperations, 'ReactDOMIDOperations', {
updatePropertyByID: 'updatePropertyByID',
dangerouslyReplaceNodeWithMarkupByID: 'dangerouslyReplaceNodeWithMarkupByID',
dangerouslyProcessChildrenUpdates: 'dangerouslyProcessChildrenUpdates',
});
+3
View File
@@ -440,6 +440,9 @@ TopLevelWrapper.prototype.render = function() {
* Inside of `container`, the first element rendered is the "reactRoot".
*/
var ReactMount = {
TopLevelWrapper: TopLevelWrapper,
/** Exposed for debugging purposes **/
_instancesByReactRootID: instancesByReactRootID,
@@ -14,6 +14,7 @@
var Danger = require('Danger');
var ReactMultiChildUpdateTypes = require('ReactMultiChildUpdateTypes');
var ReactPerf = require('ReactPerf');
var setInnerHTML = require('setInnerHTML');
var setTextContent = require('setTextContent');
@@ -151,4 +152,8 @@ var DOMChildrenOperations = {
};
ReactPerf.measureMethods(DOMChildrenOperations, 'DOMChildrenOperations', {
updateTextContent: 'updateTextContent',
});
module.exports = DOMChildrenOperations;
@@ -14,6 +14,7 @@
var CSSProperty = require('CSSProperty');
var ExecutionEnvironment = require('ExecutionEnvironment');
var ReactPerf = require('ReactPerf');
var camelizeStyleName = require('camelizeStyleName');
var dangerousStyleValue = require('dangerousStyleValue');
@@ -185,4 +186,8 @@ var CSSPropertyOperations = {
};
ReactPerf.measureMethods(CSSPropertyOperations, 'CSSPropertyOperations', {
setValueForStyles: 'setValueForStyles',
});
module.exports = CSSPropertyOperations;
@@ -13,6 +13,7 @@
'use strict';
var DOMProperty = require('DOMProperty');
var ReactPerf = require('ReactPerf');
var quoteAttributeValueForBrowser = require('quoteAttributeValueForBrowser');
var warning = require('warning');
@@ -247,4 +248,10 @@ var DOMPropertyOperations = {
};
ReactPerf.measureMethods(DOMPropertyOperations, 'DOMPropertyOperations', {
setValueForProperty: 'setValueForProperty',
setValueForAttribute: 'setValueForAttribute',
deleteValueForProperty: 'deleteValueForProperty',
});
module.exports = DOMPropertyOperations;
+11 -3
View File
@@ -165,7 +165,11 @@ var ReactDefaultPerf = {
].totalTime = performanceNow() - start;
return rv;
} else if (fnName === '_mountImageIntoNode' ||
moduleName === 'ReactDOMIDOperations') {
moduleName === 'ReactBrowserEventEmitter' ||
moduleName === 'ReactDOMIDOperations' ||
moduleName === 'CSSPropertyOperations' ||
moduleName === 'DOMChildrenOperations' ||
moduleName === 'DOMPropertyOperations') {
start = performanceNow();
rv = func.apply(this, args);
totalTime = performanceNow() - start;
@@ -198,8 +202,12 @@ var ReactDefaultPerf = {
});
} else {
// basic format
var id = args[0];
if (typeof id === 'object') {
id = ReactMount.getID(args[0]);
}
ReactDefaultPerf._recordWrite(
args[0],
id,
fnName,
totalTime,
Array.prototype.slice.call(args, 1)
@@ -211,7 +219,7 @@ var ReactDefaultPerf = {
fnName === 'updateComponent' || // TODO: receiveComponent()?
fnName === '_renderValidatedComponent')) {
if (typeof this._currentElement.type === 'string') {
if (this._currentElement.type === ReactMount.TopLevelWrapper) {
return func.apply(this, args);
}
+3 -1
View File
@@ -22,7 +22,9 @@ var DOM_OPERATION_TYPES = {
REMOVE_NODE: 'remove',
SET_MARKUP: 'set innerHTML',
TEXT_CONTENT: 'set textContent',
'updatePropertyByID': 'update attribute',
'setValueForProperty': 'update attribute',
'setValueForAttribute': 'update attribute',
'deleteValueForProperty': 'remove attribute',
'dangerouslyReplaceNodeWithMarkupByID': 'replace',
};