Forcibly wrap SVG nodes with <svg> on creation

Forcing wrapping seems necessary here: I compared a <circle> created within a <div> with a <circle> created inside an <svg> and they appear to have exactly the same properties with the exception of .parentNode (and .parentElement), yet the former refuses to show up when appended to an <svg> element. As such, I can't find any useful way to write a unit test (testing getMarkupWrap's output doesn't seem particularly useful to me).

Fixes #311.

Test Plan:
With a component that adds a <circle> after mounting (such as http://jsfiddle.net/spicyj/hxFVe/), verify that the circle appears in both Chrome and IE9.
This commit is contained in:
Ben Alpert authored and Paul O’Shannessy committed 2013-10-14 13:44:36 -07:00
1 parent b45c82c256
commit 7909c3e71b
1 file changed
+40 -11
+40 -11
View File
@@ -32,23 +32,52 @@ var dummyNode =
*
* In IE8, certain elements cannot render alone, so wrap all elements ('*').
*/
var shouldWrap = {};
var shouldWrap = {
// Force wrapping for SVG elements because if they get created inside a <div>,
// they will be initialized in the wrong namespace (and will not display).
'circle': true,
'g': true,
'line': true,
'path': true,
'polyline': true,
'rect': true,
'text': true
};
var selectWrap = [1, '<select multiple="true">', '</select>'];
var tableWrap = [1, '<table>', '</table>'];
var trWrap = [3, '<table><tbody><tr>', '</tr></tbody></table>'];
var svgWrap = [1, '<svg>', '</svg>'];
var markupWrap = {
'*': [1, '?<div>', '</div>'],
'area': [1, '<map>', '</map>'],
'caption': [1, '<table>', '</table>'],
'col': [2, '<table><tbody></tbody><colgroup>', '</colgroup></table>'],
'colgroup': [1, '<table>', '</table>'],
'legend': [1, '<fieldset>', '</fieldset>'],
'optgroup': [1, '<select multiple="true">', '</select>'],
'option': [1, '<select multiple="true">', '</select>'],
'param': [1, '<object>', '</object>'],
'tbody': [1, '<table>', '</table>'],
'td': [3, '<table><tbody><tr>', '</tr></tbody></table>'],
'tfoot': [1, '<table>', '</table>'],
'th': [3, '<table><tbody><tr>', '</tr></tbody></table>'],
'thead': [1, '<table>', '</table>'],
'tr': [2, '<table><tbody>', '</tbody></table>'],
'*': [1, '?<div>', '</div>']
'optgroup': selectWrap,
'option': selectWrap,
'caption': tableWrap,
'colgroup': tableWrap,
'tbody': tableWrap,
'tfoot': tableWrap,
'thead': tableWrap,
'td': trWrap,
'th': trWrap,
'circle': svgWrap,
'g': svgWrap,
'line': svgWrap,
'path': svgWrap,
'polyline': svgWrap,
'rect': svgWrap,
'text': svgWrap
};
/**