Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't double invoke getDerivedStateFromProps for module pattern (#21193)

Browse Source
This commit is contained in:
Sebastian Markbåge
2021-04-07 16:20:25 -07:00
committed by GitHub
parent e90c76a651
commit 782f689ca8
4 changed files with 2 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberBeginWork.new.js
-11
View File
@@ -185,7 +185,6 @@ import {
} from './ReactFiberHydrationContext.new';
import {
adoptClassInstance,
applyDerivedStateFromProps,
constructClassInstance,
mountClassInstance,
resumeMountClassInstance,
@@ -1594,16 +1593,6 @@ function mountIndeterminateComponent(
initializeUpdateQueue(workInProgress);
const getDerivedStateFromProps = Component.getDerivedStateFromProps;
if (typeof getDerivedStateFromProps === 'function') {
applyDerivedStateFromProps(
workInProgress,
Component,
getDerivedStateFromProps,
props,
);
}
adoptClassInstance(workInProgress, value);
mountClassInstance(workInProgress, Component, props, renderLanes);
return finishClassComponent(
packages/react-reconciler/src/ReactFiberBeginWork.old.js
-11
View File
@@ -185,7 +185,6 @@ import {
} from './ReactFiberHydrationContext.old';
import {
adoptClassInstance,
applyDerivedStateFromProps,
constructClassInstance,
mountClassInstance,
resumeMountClassInstance,
@@ -1594,16 +1593,6 @@ function mountIndeterminateComponent(
initializeUpdateQueue(workInProgress);
const getDerivedStateFromProps = Component.getDerivedStateFromProps;
if (typeof getDerivedStateFromProps === 'function') {
applyDerivedStateFromProps(
workInProgress,
Component,
getDerivedStateFromProps,
props,
);
}
adoptClassInstance(workInProgress, value);
mountClassInstance(workInProgress, Component, props, renderLanes);
return finishClassComponent(
packages/react-reconciler/src/ReactFiberClassComponent.new.js
+1 -1
View File
@@ -162,7 +162,7 @@ if (__DEV__) {
Object.freeze(fakeInternalInstance);
}
export function applyDerivedStateFromProps(
function applyDerivedStateFromProps(
workInProgress: Fiber,
ctor: any,
getDerivedStateFromProps: (props: any, state: any) => any,
packages/react-reconciler/src/ReactFiberClassComponent.old.js
+1 -1
View File
@@ -162,7 +162,7 @@ if (__DEV__) {
Object.freeze(fakeInternalInstance);
}
export function applyDerivedStateFromProps(
function applyDerivedStateFromProps(
workInProgress: Fiber,
ctor: any,
getDerivedStateFromProps: (props: any, state: any) => any,