Facebook/react
1
0
Fork 0
mirror of https://github.com/facebook/react.git synced 2025-11-01 09:12:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

move resource acquisition to mutation phase (#25500)

Browse Source
This commit is contained in:
Josh Story
2022-10-17 15:21:06 -07:00
committed by GitHub
parent 500bea532d
commit 71f2c8cf15
2 changed files with 26 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-reconciler/src/ReactFiberCommitWork.new.js
+13 -13
View File
@@ -1089,19 +1089,6 @@ function commitLayoutEffectOnFiber(
committedLanes,
);
if (flags & Update) {
const newResource = finishedWork.memoizedState;
if (current !== null) {
const currentResource = current.memoizedState;
if (currentResource !== newResource) {
releaseResource(currentResource);
}
}
finishedWork.stateNode = newResource
? acquireResource(newResource)
: null;
}
if (flags & Ref) {
safelyAttachRef(finishedWork, finishedWork.return);
}
@@ -2617,6 +2604,19 @@ function commitMutationEffectsOnFiber(
safelyDetachRef(current, current.return);
}
}
if (flags & Update) {
const newResource = finishedWork.memoizedState;
if (current !== null) {
const currentResource = current.memoizedState;
if (currentResource !== newResource) {
releaseResource(currentResource);
}
}
finishedWork.stateNode = newResource
? acquireResource(newResource)
: null;
}
return;
}
}
packages/react-reconciler/src/ReactFiberCommitWork.old.js
+13 -13
View File
@@ -1089,19 +1089,6 @@ function commitLayoutEffectOnFiber(
committedLanes,
);
if (flags & Update) {
const newResource = finishedWork.memoizedState;
if (current !== null) {
const currentResource = current.memoizedState;
if (currentResource !== newResource) {
releaseResource(currentResource);
}
}
finishedWork.stateNode = newResource
? acquireResource(newResource)
: null;
}
if (flags & Ref) {
safelyAttachRef(finishedWork, finishedWork.return);
}
@@ -2617,6 +2604,19 @@ function commitMutationEffectsOnFiber(
safelyDetachRef(current, current.return);
}
}
if (flags & Update) {
const newResource = finishedWork.memoizedState;
if (current !== null) {
const currentResource = current.memoizedState;
if (currentResource !== newResource) {
releaseResource(currentResource);
}
}
finishedWork.stateNode = newResource
? acquireResource(newResource)
: null;
}
return;
}
}